From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91B7DC4345F for ; Fri, 26 Apr 2024 00:19:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00A846B0082; Thu, 25 Apr 2024 20:19:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC9A96B0083; Thu, 25 Apr 2024 20:19:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D90436B0085; Thu, 25 Apr 2024 20:19:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 56CD46B0082 for ; Thu, 25 Apr 2024 20:19:26 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 14D78121242 for ; Fri, 26 Apr 2024 00:19:26 +0000 (UTC) X-FDA: 82049773932.13.F5D3879 Received: from out-177.mta1.migadu.com (out-177.mta1.migadu.com [95.215.58.177]) by imf12.hostedemail.com (Postfix) with ESMTP id 0D4744001B for ; Fri, 26 Apr 2024 00:19:23 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=eGmBUanR; spf=pass (imf12.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.177 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714090764; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iiDAAU9IAxaCzWX8x+M+Xfi0SfQX0lRBqlfJeEKcIHM=; b=cAjrq8bcChpLoILb9e+x6ZwqrsPAOBpNtUb68K49xUcXDUYB87NeOvWfuZwe9n0w6H+wlo 1A1wfsV0mJ3UkOddk6L/xBsbXem2Vkde5ibRgUSXP0mV730qyDX8BVkcqVuB8qu0Zbs46z KJPsUOIm06YjTqVfhLD4H3XL33z/v1g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714090764; a=rsa-sha256; cv=none; b=kzUPWfqNQDpcP2V0RFBVb7ekU29l6qLu90J8OWBFRVOI1CAkPF0XibjVTIgJuTuWB/U54r kqt5kEnBwZo+Y6BzDG96i6WLe0cobFfs2s0ij9zUTwHHiiZp2YzvEhJwE+KzfNQYcw6LdQ C1rXIwmIpy7wD+bKmTSmeNnDmvgWJK4= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=eGmBUanR; spf=pass (imf12.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.177 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Thu, 25 Apr 2024 20:19:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1714090761; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iiDAAU9IAxaCzWX8x+M+Xfi0SfQX0lRBqlfJeEKcIHM=; b=eGmBUanRBVu9815GoHdTQzhhKjtSIv7vsZocN0F2fjdwhao6XUsWARO7DUVb6l/vLmgho0 dTFzMuJmCtFMNOvy9aX5WReuYxeInKldHxRcCDCCw7UfeQZkBXa8Ka37yk3Ua9ve01Hdup 7QXmk4RSshVM8ZfnPC9hkf4YvSuqH7I= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Andrew Morton Cc: Suren Baghdasaryan , Kees Cook , Catalin Marinas , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] mm/slub: Avoid recursive loop with kmemleak Message-ID: References: <20240425205516.work.220-kees@kernel.org> <20240425164917.8c9603387b4cce11121024a8@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240425164917.8c9603387b4cce11121024a8@linux-foundation.org> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 0D4744001B X-Stat-Signature: nzpmwgcq18r8rbs9db76d53f3wd5paqr X-HE-Tag: 1714090763-704100 X-HE-Meta: U2FsdGVkX1/nJWMg9fzCvWFhDizGoWobf0dtD6vyPh54FVyRDcGozKugPbslKa5pYtzI/13hBSwdZDUSxI2ydlH2uWtIsGYN7ZB8rqGEnw38CzXDJW9ZL5fSGXRm3Q4pXfTZU4EUzq1HeXZV5oqBAGZMFybE1440QyGhiTzOLr0ASUgORihTckWPNRSV9uyzSbO32AHBpYZDfcCmhiAYNRR5qjWnJ9+gR7cPsZMIXEtwzWb8bQIJugutGqGlT3Nr5RpwyFzGMg4boJAS8jZuWpANtZ1u8Lakz8zlu1IGnctPHg80GLKMelYFOcZDMihpmMVlQGNLG6aMF0jMzxEWdR4OOynwb8XAfnIlbpzA+3XAmRssMj5VVAeqUO1Eu+B95oXjdxWJqi2coz7GeBnxa3KkFiIduiwex6fka4osY5TpWb9SO7dLPNVqtdIOMbEoGninGtlWy5u15r/LGfJgqvlVT1du/0+1i1N8SwokbgDcvc0V7zUdPVZt/oMRJpbBaOcoKpXDx1aDdE0o0BtkgxpNwywVVCsgDwqdNoXLax78CZ4zLDscv6FnwRpmmuarEPy3SL4pumzWlZHEdAKRap8Ulh6Aa/3El/DsoQOj7almSyyBTLvpP1McqYBNPW604dD5vgKdH8mRRVsQLzkidDYDjcCeHDD1BJ/SUqL0ghtcfx6uZ69JI90iYSaULvPbjHSIfd/Q39V07ytJOTUPRGM3FMFL/nsJtVIklEize5Qt0In2c2KwoCall3tcdQfz8oDxDVfHECRih2ritnT0hvB/s1bfXQgpFzW+CAu+pG4gT5JcbmqjfYwD/iV6rPpdHIVIOQd0S7A0tkjPWBFZJymCE0K2zDpg/FNcb1tx+oMu2BaiFRfU76LhWZshAbrpxfPYA/HauQzrb12sPX7wSybKGM73TnCFkMfjQ6713keXMn5+JyfcRhSkn2RVNsGBh7NCE3ywc7RFwC09xMY 6eEpMNPy PB3Gzkv1PF9tuJkfi92eAA2zeCfgTlMIpOmH8Lrq8Hy4VBGaO7iLYQ7C6JJc19/3dCV8ljkvzdKr5kSODDLBpHkdFlpNfNMbLZTS0xtxcaiRUkZNOo+G0mc2WkPM7UvavN3ugVz4vMBZjxU0rAlIchgKYhgLxT52llQMaVAKcr6hR5Lc/QWZ2lFlZyA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 25, 2024 at 04:49:17PM -0700, Andrew Morton wrote: > On Thu, 25 Apr 2024 14:30:55 -0700 Suren Baghdasaryan wrote: > > > > > --- a/mm/kmemleak.c > > > > +++ b/mm/kmemleak.c > > > > @@ -463,7 +463,7 @@ static struct kmemleak_object *mem_pool_alloc(gfp_t gfp) > > > > > > > > /* try the slab allocator first */ > > > > if (object_cache) { > > > > - object = kmem_cache_alloc(object_cache, gfp_kmemleak_mask(gfp)); > > > > + object = kmem_cache_alloc_noprof(object_cache, gfp_kmemleak_mask(gfp)); > > > > > > What do these get accounted to, or does this now pop a warning with > > > CONFIG_MEM_ALLOC_PROFILING_DEBUG? > > > > Thanks for the fix, Kees! > > I'll look into this recursion more closely to see if there is a better > > way to break it. As a stopgap measure seems ok to me. I also think > > it's unlikely that one would use both tracking mechanisms on the same > > system. > > I'd really like to start building mm-stable without having to route > around memprofiling. How about I include Kees's patch in that for now? Agreed