From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7D96C25B78 for ; Tue, 28 May 2024 19:01:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E6AEE6B0099; Tue, 28 May 2024 15:01:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E1A7E6B009A; Tue, 28 May 2024 15:01:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CBB416B009B; Tue, 28 May 2024 15:01:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AD8F96B0099 for ; Tue, 28 May 2024 15:01:54 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 200D6C0247 for ; Tue, 28 May 2024 19:01:54 +0000 (UTC) X-FDA: 82168724148.15.C739553 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by imf15.hostedemail.com (Postfix) with ESMTP id B56A2A000C for ; Tue, 28 May 2024 19:01:49 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=ttWKuENY; dmarc=pass (policy=none) header.from=samsung.com; spf=pass (imf15.hostedemail.com: domain of da.gomez@samsung.com designates 210.118.77.11 as permitted sender) smtp.mailfrom=da.gomez@samsung.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716922910; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HoBAqzCYnFZWUFCnY9A1juVwqBBHmfP+U4Tja7baPBM=; b=nb39VZ9bA3g1BAIzkN6avmxZ5u8NITfZCR388GuK0VZJ7ukkG1a8XyxEROkMUmkOyyHqlS 0EIpPtYj0TgPw1aYQqxHpJfy+Wp6VdbnAGbU4T+6ZhbSLCg59omjjTi3SxuA2eAqmqnspn 78bRdg7I/4Xfif1nT3BNGIUDEwMt5AM= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=samsung.com header.s=mail20170921 header.b=ttWKuENY; dmarc=pass (policy=none) header.from=samsung.com; spf=pass (imf15.hostedemail.com: domain of da.gomez@samsung.com designates 210.118.77.11 as permitted sender) smtp.mailfrom=da.gomez@samsung.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716922910; a=rsa-sha256; cv=none; b=jhC1xjwU8LEOvcW6wUih9zicHyVZ468q2h9Uq56jII4o+x2EWECZ1yMeppqfp6Y9M5gVnO zBWpJ4K+NzRYSSk0CLvEX6cd2KP9SUeMXcPD/mnzBmpwjos1Yhqo99lIDx+iM3GpXEwjkt kDv5Qoh81NPRsMSB42UX0Sypq2yQyYM= Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20240528190147euoutp0103b22575696a5eb985a9f7c9b66f655c~TvEmcULMf2791727917euoutp01r for ; Tue, 28 May 2024 19:01:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20240528190147euoutp0103b22575696a5eb985a9f7c9b66f655c~TvEmcULMf2791727917euoutp01r DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1716922907; bh=HoBAqzCYnFZWUFCnY9A1juVwqBBHmfP+U4Tja7baPBM=; h=From:To:CC:Subject:Date:In-Reply-To:References:From; b=ttWKuENYwmCb0DgUfiqwHZ94nEfyl+MY6nkZ+dzYylzJ3U/4vTcfVzKPEAexDaIXS WNZXgCLBrMqgfV3IDxB/4GGO3OI7ue9uprm+GKCuodGt61zEjhpIok7nOPSVInfreE piRnJvzQC4D80NKg6Zikvn4XN2b/2v4WqhsH8Seo= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20240528190146eucas1p2299f2e87c3ab0067b02c0a9a943d9f56~TvElcyrX11587915879eucas1p2a; Tue, 28 May 2024 19:01:46 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id E6.06.09624.A1A26566; Tue, 28 May 2024 20:01:46 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20240528190145eucas1p1481c99394a28dc2ce06adb60f411b73d~TvElEqUqg2782127821eucas1p13; Tue, 28 May 2024 19:01:45 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20240528190145eusmtrp2ead789bc1e8f3770264c3bfa9898812a~TvElEMaIP0986809868eusmtrp2U; Tue, 28 May 2024 19:01:45 +0000 (GMT) X-AuditID: cbfec7f2-bfbff70000002598-e6-66562a1a5574 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id B4.22.08810.91A26566; Tue, 28 May 2024 20:01:45 +0100 (BST) Received: from CAMSVWEXC01.scsc.local (unknown [106.1.227.71]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20240528190145eusmtip2b1c04cf777bbc989ac9b037d53b9c4e0~TvEkwDrWx0757207572eusmtip20; Tue, 28 May 2024 19:01:45 +0000 (GMT) Received: from CAMSVWEXC01.scsc.local (2002:6a01:e347::6a01:e347) by CAMSVWEXC01.scsc.local (2002:6a01:e347::6a01:e347) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 28 May 2024 20:01:44 +0100 Received: from CAMSVWEXC01.scsc.local ([::1]) by CAMSVWEXC01.scsc.local ([fe80::7d73:5123:34e0:4f73%13]) with mapi id 15.00.1497.012; Tue, 28 May 2024 20:01:44 +0100 From: Daniel Gomez To: Matthew Wilcox CC: Christoph Hellwig , Trond Myklebust , Anna Schumaker , "linux-nfs@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" Subject: Re: [PATCH 1/2] filemap: Convert generic_perform_write() to support large folios Thread-Topic: [PATCH 1/2] filemap: Convert generic_perform_write() to support large folios Thread-Index: AQHasRMEv8C0Tteo9UiuY4wdfWDY+LGsy3MAgAAklwA= Date: Tue, 28 May 2024 19:01:43 +0000 Message-ID: In-Reply-To: Accept-Language: en-US, en-GB Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [106.210.248.226] Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA02SaUwTURSF8zpLpzXVoaC9YpBYlyhCxSVaF8QfRuuORk1cEm1kCihUM6W4 olUjKBqExgWqSEEsAoZgBdOqoFZREVzjAiguWIyCmMqigEJlGEj677v33HvPecmjMGkh4UtF aWMZVquOlpNi/PqDzmdBvgFrNcF3LYTyiN2NK/MKygXKW6UVuPLDFTehfH6nklC6q0OVfzvO k/OEqn+Oq0LVtcsBKmv+MVJlbTEKVTdrDKSq1ToyjFwvnhPOREfFMeykuZvFkY8aHMIdOeJd pw+/Iw0olUpCIgroaXAq5bggCYkpKX0ZQXepDeOLNgQNz22IL1oR2E48JQZWLpQWEbyQi6A1 /TvGCX1TqR/ieK5CcH7gbh4CY24L4gSSngBlFVZhEqIoH3o8/Ciews1gdI4APjbUk9yMN70B /jk+97EPvRF6cq7iPM+CpsYyktvF6bGQ3KHm2hJ6GbyxlPe1Rb3hEg0s10a0H9TndQk5xmgZ 1DozBXx+L8g+dwvjeRj03OCdgA6EJ2+diOdgKLlUhvM8Gr7lvCf4O4FgvtlC8jwTnhQ0C3ie CJasJoyP4wUV6U6cexbQ9SK4fvB0v8F8sBov9rM3ND4sFqagQJNHPpOHh8nDw+ThYfLwMCMi H8kYvS4mgtFN1jI7FTp1jE6vjVBs2R5jRb1fqrLnYYsNZTT+UjiQgEIOBBQm95FUGddopJJw 9e49DLt9E6uPZnQONILC5TLJ2HB/RkpHqGOZbQyzg2EHVAEl8jUIMuWsvrq+eV2HX23i/TTX ScXhonLj3q8Tc4ce3Z1l3JdgXc24Fi2dG1aS4Fqj0Za0ddV1nijLeFyTvFijcfv6v2DzPoXV iJ9OPyQMIRbag1tFrmcHCgsDLDL7q6Abo15erAuy6rfNaD+zbmFDl+Vk7RBn2Jmp0h/Dj1WZ g/+62jfaGsm7ivjAQ1l2x/3383elxb+VOZd7Jcnz65b8+S0pnrJ12ewX8V/GfZZ5h17o1mVL QzS2fKYpO9Xs99ESvspJ1Q4Kaq+OPXv79dLxhkr/EM21A35xePOm5Snxdmm2PLRowejB5e6a lfdeZuw3p6zKNUiWrPg5prNkhmNoQXdyZtydNjmui1RPDsBYnfo/2KHx4MEDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrOKsWRmVeSWpSXmKPExsVy+t/xe7qSWmFpBn8naFm07vzPYrFy9VEm iz17T7JY3Fvzn9XiwoHTrBb/b9hb/P4xh82B3ePPoY3sHptXaHlsWtXJ5rHp0yR2j903G9g8 Pm+SC2CL0rMpyi8tSVXIyC8usVWKNrQw0jO0tNAzMrHUMzQ2j7UyMlXSt7NJSc3JLEst0rdL 0Ms48fQQe8ESroqpzbfZGhgncnQxcnJICJhIzNu7gbWLkYtDSGApo8S+ng1sEAkZiY1frrJC 2MISf651gcWFBD4ySnz9JQnRcIZRYs6u50wQzkpGifdLN4FVsQloSuw7uYm9i5GDQ0RAQ+LN FiOQGmaBJUwS958+AqsRFoiW+HPoIZgtIhAjcWz7VGYI20ri9at9bCC9LAKqEn0/EkHCvAK+ EteWHWWD2DWbSaJr6zVWkBpOoBfaG4pAahgFZCUerfzFDmIzC4hL3HoynwniAQGJJXvOM0PY ohIvH/+DekxH4uz1J4wQtoHE1qX7WCBsZYkXS+6wQszRkViw+xMbhG0pcXb1WyYIW1ti2cLX zBC3CUqcnPmEZQKjzCwkq2chaZ+FpH0WkvZZSNoXMLKuYhRJLS3OTc8tNtQrTswtLs1L10vO z93ECExB24793LyDcd6rj3qHGJk4GA8xSnAwK4nwnpkUmibEm5JYWZValB9fVJqTWnyI0RQY dBOZpUST84FJMK8k3tDMwNTQxMzSwNTSzFhJnNezoCNRSCA9sSQ1OzW1ILUIpo+Jg1OqgSm6 UcjgmGn3cpfPZWtPJhp2HROY+zCExWxq36zeFzO6zGM6Tx7u8SzaPuXhr6dukQ/Ni4/N4jm1 Ov/ZzEiWlh93N+33mrqOSeK8ccb1fXvNmcPvW1b0rWx7saAqJ1flx4SwCs8aleyFH0L27Cmy D9ZyZnoSvm2ZeqLqid91xYvmmy9/pnpX627Ub9VzlSp35Gesinb4HRBnd8Lt/yXNN+UKhb9/ 5H6QE/m8qao5ec/O799/PtlY9nplYVpx6BVOr3n8xUY90ZIvVYRl1SK1j17U1GJIkrov4TdZ 8xrTQavdBzXrAi8v+R9nMG2zwuO0PRbR70WMLBiVGt215+8/47y68MfG61kCi8+mKG+/nqfE UpyRaKjFXFScCADgEUOcygMAAA== X-CMS-MailID: 20240528190145eucas1p1481c99394a28dc2ce06adb60f411b73d X-Msg-Generator: CA X-RootMTR: 20240528152340eucas1p17ba2ad78d8ea869ef44cdeedb2601f80 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20240528152340eucas1p17ba2ad78d8ea869ef44cdeedb2601f80 References: <20240527163616.1135968-1-hch@lst.de> <20240527163616.1135968-2-hch@lst.de> X-Rspamd-Queue-Id: B56A2A000C X-Stat-Signature: fbb73ijyhxmn7m3d5ok1t6nn63jxpqfx X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1716922909-793790 X-HE-Meta: U2FsdGVkX1/k0VPiUXHoSf+X8xWShjx/SN31BIoGLxdyQzFQNyQ1PjDT0ww3HkJSHxIGPe2K7lgiRji1eLiL0Nd70AtIhNW/A0dA3mt2Um8fktUpdmTBuMFta9Yb6m587RieSpbcZw6k7vew+thhmnZjkYMxTHbyisLKSYnIJPYsLz2vHQnh+hQX2cs6C+UnjhaxutfRuWufywsK8W37WgVJ9oDWzqDtKZ+hHske/ReS9DKfJYBLxcHOX/rbOIsVbKLO0LSbI/WmT3ywKe7NPcTG5dYmxUJp6tdek7/jkrJpWDh6OW5DtqeuXcxpSymu2K3/idO+4zIDZlQ6tTEoqPQ80mbqUUThxSyUaGlyC0TlUzJFo0SI+8uLW4yY74qZhXlR8Sm/hQFogf03Ofl/Zqzk96HtLqZfxbUXfmy2mhaHccOZSfZSvACQqGWn/ORU8tS6n46rw6a4Htc6yHiuxRLKEz+Em1KwO2bHm8LEH9P+raRKEDAIBKQYBlXvps0yS2oqQykQi4ZDTAoxUFhQijxl4Z86dkJKH959RZisU0v4lLe2dbI8YRTmVaV4lsGVrIDiH+jHo6h6TLyuODpAGDx4xly3GXxyX2LS+TGbYYuZq9YXvPCsVgcgf1um77JxB2pJmFeR7q4ArkOKhmSPcExvBmMc7bCBnJ8V4DcTKItSjbXcocIHzE6OYGyqMHNtnD1SwQ/umkhL/QbizMk4dRjhgxnD0KsgfzCT3C0OpyW1mpB3Tsw1IxsWEHg58lsV6vqsdJ1NiF+f7DBnxsb0UIgTQMiioPxPHqI/6VXhNu9AfgqmKdUUS0ycQrXYIlXTVQHEyU/uvjcaJ109gWQN/f9hD7vOjzNAyv1AblgMzJ2Q7g0Zf0/Twzi3o2SG8Lal/pVCHHo3Fo/LlwCVu0cQ0SVGTwcFUYTV3ijh2YLa2gbrPXFuPW4RPxOfp71mze1DkyJUOmxuQbEsl71AAKE 2eujVBjq QkwAD3jQzKVJr5cRqa3VRaN6TXW2ezo86jdzuhzTNwo8gVgN/6VRMCWD7QE09ETsWacyEeI3SxYybg2Lk1gwLwZcHXEm7a0pgpF9sDYv2k7NHgN6LB8Mo69ggzemAP6rG1xWwiUAio44V7OsCIScerFMoDTCh5DkCrlLXUnZ2k77lfLk/3YTPQhySYPwOuwXm2aRbpJ/8Rkx3lBA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 28, 2024 at 05:50:44PM +0100, Matthew Wilcox wrote: > On Tue, May 28, 2024 at 03:23:39PM +0000, Daniel Gomez wrote: > > I have the same patch for shmem and large folios tree. That was the las= t piece > > needed for getting better performance results. However, it is also need= ed to > > support folios in the write_begin() and write_end() callbacks. >=20 > I don't think it's *needed*. It's nice! But clearly not necessary > since Christoph made nfs work without doing that. I see. We send anyway the length with bytes and the folio allocated inside write_begin() is retrieved with folio_page(). I did test this patch (+mapping_max_folio_size() patch) for shmem an it wor= ks fine for me. >=20 > > In order to avoid > > making them local to shmem, how should we do the transition to folios i= n these > > 2 callbacks? I was looking into aops->read_folio approach but what do y= ou think? >=20 > See the v2 of buffer_write_operations that I just posted. I was waiting > for feedback from Christoph on the revised method for passing fsdata > around, but I may as well just post a v2 and see what happens. Interesting. I think it makes sense to convert tmpfs to buffered_write_operations as well. Can you add me to the v2 so I can add/re= view it for tmpfs? Thanks=