From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE75CC4828F for ; Wed, 7 Feb 2024 16:43:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 496536B0078; Wed, 7 Feb 2024 11:43:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 446066B007D; Wed, 7 Feb 2024 11:43:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 30EE66B007E; Wed, 7 Feb 2024 11:43:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 23D246B0078 for ; Wed, 7 Feb 2024 11:43:49 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DC8D4A0E1D for ; Wed, 7 Feb 2024 16:43:48 +0000 (UTC) X-FDA: 81765579336.27.5C9E480 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id B79B91C0014 for ; Wed, 7 Feb 2024 16:43:46 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=K5OTcUzI; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of jsnitsel@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=jsnitsel@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707324226; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GJlJ97KV983cCFAs8Hh+z+jAcflqZylPwBHCx3rSV0I=; b=2Bql+6usEdbrNaDSj+MWe82IGrNPmEcyaNhHZiaLDBQHahkH/2TcgaPgbZBueKfX6hE5wz vKKJsFA3irYe/+EfxYiVjTqHP7FR7x53WUxki+jLb8AV0HkXkaq8lq4bm8DJ/ENM3unIlD Xzg++OQ6A+7V6g/YslYWOH3j0Y7S6Hs= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=K5OTcUzI; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf18.hostedemail.com: domain of jsnitsel@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=jsnitsel@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707324226; a=rsa-sha256; cv=none; b=LXDTj1XBY8+4fwYd/SoKk5kAtKm+MsU5CtjKY/O31u3MCPEz7G/kHm1XslxiqWK2BNqJGH Ne6lmRoVG4EzXJ5Zd3LEqg3QVuv4Wx2AKaUeoUuKja6MQOkS9pdjMu2wmYZFskUAeUWe7O kgEh9j/6spZdeXA7oERcRiuB846QfYA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707324226; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GJlJ97KV983cCFAs8Hh+z+jAcflqZylPwBHCx3rSV0I=; b=K5OTcUzItAh1fu17VePZ0wJ2kFNQ57w+zm+DUcZcmL2BThdVvqU0qeYLYbRPkx/+cS8deG g0G+rCDDsq/M6nh1UPLPHgzHv61Rsb+eYUS5TCpmRzCkWrJrh32MBV7sBX2K00dC55d2Yv 2TQuwXIv7QDYHTMADC//RhPloI1za2I= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-172-A5VCUYZjMHOFnsSORQ8qaQ-1; Wed, 07 Feb 2024 11:43:44 -0500 X-MC-Unique: A5VCUYZjMHOFnsSORQ8qaQ-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-68c53f2816dso10599386d6.0 for ; Wed, 07 Feb 2024 08:43:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707324224; x=1707929024; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GJlJ97KV983cCFAs8Hh+z+jAcflqZylPwBHCx3rSV0I=; b=m9XPtI53SDRWC+oAjQIqABhUu8OnpgZ61hIibIo8wV0JgD9uRRPKTXrxeOk14XB2W7 MTkTzXAfwpLVqLuDKYoDOK4+v393ApA1giXM9d41+hz55b4YF2+Q3HQevP7K/8SFqR19 EfBJwnr6E17MigMavhpXNX7WgiXgChz8EILZTfKemweDyMILBSGaTr2R5gg4rjVboASU 43DodZVlZkIW8xr4JxqwN6DNntWUxAqk1aD+whCDcTx785bVnYNGm4K4IIqrKyxctOLK jU63Lp/QZHa+0OFi+18zZS4UIO0PIFQFCJq8lLzOATXmafEVelGsJPrqsBy3A399v7il SYBQ== X-Gm-Message-State: AOJu0YwpdBWxg3q33Lwqdgxng4gZrRyl2tS+99DhjizD4c/G4VyadEHK YPdbgTPmhb/ADI1tQEls0afZSp9PgcuPd485tuGjfRTKW3b0AY0rTRVjl7w656EozIGO7sGhSyM w2zMCH3he83ooV/S6Pqy5Sg+Y06iecRhNgxiWAaA8SM5r4/0/ X-Received: by 2002:a05:6214:529e:b0:68c:a92f:6fe with SMTP id kj30-20020a056214529e00b0068ca92f06femr6411191qvb.19.1707324224495; Wed, 07 Feb 2024 08:43:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IFViM+VvNQsCrUuHVYLtV3yxtqkEeZd5GyiCCUjD0K9kKsflJ7U8nzX+CfETK3aRB4UrWsGpQ== X-Received: by 2002:a05:6214:529e:b0:68c:a92f:6fe with SMTP id kj30-20020a056214529e00b0068ca92f06femr6411179qvb.19.1707324224248; Wed, 07 Feb 2024 08:43:44 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCVCug54+TMCrXgydIYnzZkcK8Zf+AEMYZcoUGAdVLQVsL6BrXRj/S/4zRvIwTHA7jOzFr8r9be2oB4GTtwwomjS4kbabSeK7Yav/4jUB6rUnFIdGCP1w0Q8eZf+ylYfw0dE+LMMDUYDRqhKRvTylGRXkv1aByYwyLrSVOspdW2Fi6kEnOjQA0nLLEzIvDg2oYKpb+zOz3040erLaiBRZ69/2odnG33B8khpJ0WKY8TYZGBHX/6iPpHJ6eD5qRmpCEkOwZeCxwrzUcY+xU62v0KEB09biS9dCCz10/8EBcBn7XYNVT4WQBkg Received: from localhost (ip70-163-216-141.ph.ph.cox.net. [70.163.216.141]) by smtp.gmail.com with ESMTPSA id ny12-20020a056214398c00b006869c05a875sm750260qvb.32.2024.02.07.08.43.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 08:43:43 -0800 (PST) Date: Wed, 7 Feb 2024 09:43:42 -0700 From: Jerry Snitselaar To: Robin Murphy Cc: joro@8bytes.org, will@kernel.org, pasha.tatashin@soleen.com, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, rientjes@google.com, yosryahmed@google.com, john.g.garry@oracle.com Subject: Re: [PATCH v3 3/3] iommu/iova: use named kmem_cache for iova magazines Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Queue-Id: B79B91C0014 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 4ee78amkrxrjwxqhntxiskzpbgps5rqz X-HE-Tag: 1707324226-497480 X-HE-Meta: U2FsdGVkX1+Ny1XUuVfMcKZ2ivcnCnN+tfSSVjMDQc4nPKaVWfENA0RWOmG36/3WZvZ1MWpxVblKkFPLFzpX7qcg04DSCuOVAvArwa0X+d9YS3Eks2dbmF1gftL9YKSiP3o9NhKFe8oyrS3kuga3Qpo7vz6zLiZycDuiMo25Q/bfVrgGisv24fcj0QTNhem4xp11RZ18Z+/fTTqindDDFY39T88hztu4vUpVLnGzkD1mYvtRIgkrcadtUhyPCAVKHrMNpQ5ntRH42eu2xbJiqFHahmUq7n5qFh7FF+dkC9So6hBmgdRKFM7yZ1GLudog3ANUIi+XePy2XVhhC1AaUV63Nwdm/lGpmCE4zT34q+DCcQ/UhNLU/oNKv4R1+pUE9KQh9tffBajJywGqt7YTVZegPUGYi0O0Z88jM/LCYjgdELE3+q2IgmAiHbxENpUhHb468yDjhL1asluXnoROCa5dFEtpYQLvSYxDkPvePVPqEdlPDLNhMPODBV2zcJRSunFQvyfpIPWkt6JHjEmMGf8IrqRrk5fkcN9y0/R8QGmg1YS/0CsVTErYH0qgjbzmaysyZo8iZ7F69mcUaI2M/BjaCGyUBc8EpsCnQzIkJkaVtIa9WiGJsNikw4gsEFmyrILvPPrlosr6D3QYenvDZGQkdmHTkvFqEmyfYdXkamrow4TbcLIwjvAC2p85n/as4doJHSojKqjI86NbQlWlMfdMdsEK7bp0Xo6I127W4uavZZq3+UD4dUEYGKGQfdkHdehl9FowWUQiXT3oA0GyhNue99iTEAO9QLvumHXGhGo1CTDSWpy+3loyeN302oVgkdM3S+kW6HocRNlmzoRLBbdbY9KsRnEIh+eWSEFKqknwD0pXx2ndvXKdh67WK2F8RIU/UTK7TzKysRsXVy3jttZLCoX7TBx1KH+C+3/rRvak6TIlEoE/0HgpoY0250pItZn+NnazvFT7crsrALe nJceCQ02 2zne9sNpcWAWl5eNTdikHFM+1RD3T2ITLjQNotn+84idT/5dSyRtvqzXkFwLO2e35D3ZOFkTUdrmU8l2jZ9JoxSWmv9YWoIeNO7kKvv60SFnW1psUL9ySNVW7CvkAiDQgZ2D12GfResSK7NZZAiUb19CfLkBhNRMpJBj4HJPTFyrZZ1rwVl/D60WBgNaQcupTA0WQekMba1jnOMIPRoDG/ysTALVsqIxVB0md4vDrhIWte9PH4Qwx5oFHUHIKk2NghNYEij1pQ+LSA43/w0xGkneD1QzUvMgUioAawhu+GdGirDfHbJK6rXXTJvRmJeWZkedc4Hh5wPsjtSrF88fiQFxXTw1SE8nnLcAJPW0CchPyFapPO72UHydj5rhJ+U+MPgZhFRwg1CE1+YC6cUTMWWysr+0gczgLsct1WR9IWeh4sZFyzYjpCp5u/FMhSwgBsd1uszWvVJLCKutPJLpfAbymEbnMhj9Lj4SYVHDJDRXL9z+lCVWlFHeRdoE+E8yw5oTXzJPfI9FpU052wPUA6U3FmTV3c2bO/Kaqmjh6lGrqkRMnV7WTBGsoxVnEMYQ2UKUy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 05, 2024 at 03:32:41PM +0000, Robin Murphy wrote: > From: Pasha Tatashin > > The magazine buffers can take gigabytes of kmem memory, dominating all > other allocations. For observability purpose create named slab cache so > the iova magazine memory overhead can be clearly observed. > > With this change: > > > slabtop -o | head > Active / Total Objects (% used) : 869731 / 952904 (91.3%) > Active / Total Slabs (% used) : 103411 / 103974 (99.5%) > Active / Total Caches (% used) : 135 / 211 (64.0%) > Active / Total Size (% used) : 395389.68K / 411430.20K (96.1%) > Minimum / Average / Maximum Object : 0.02K / 0.43K / 8.00K > > OBJS ACTIVE USE OBJ SIZE SLABS OBJ/SLAB CACHE SIZE NAME > 244412 244239 99% 1.00K 61103 4 244412K iommu_iova_magazine > 91636 88343 96% 0.03K 739 124 2956K kmalloc-32 > 75744 74844 98% 0.12K 2367 32 9468K kernfs_node_cache > > On this machine it is now clear that magazine use 242M of kmem memory. > > Acked-by: David Rientjes > Signed-off-by: Pasha Tatashin > [ rm: adjust to rework of iova_cache_{get,put} ] > Signed-off-by: Robin Murphy > --- Reviewed-by: Jerry Snitselaar