From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7216DE77173 for ; Sun, 8 Dec 2024 05:21:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B7086B0370; Sun, 8 Dec 2024 00:21:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 266516B0371; Sun, 8 Dec 2024 00:21:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 155646B0372; Sun, 8 Dec 2024 00:21:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EC6E76B0370 for ; Sun, 8 Dec 2024 00:21:20 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1445F1603F9 for ; Sun, 8 Dec 2024 05:21:20 +0000 (UTC) X-FDA: 82870642890.30.3083CC8 Received: from mail02.habana.ai (habanamailrelay.habana.ai [213.57.90.13]) by imf09.hostedemail.com (Postfix) with ESMTP id 350D6140002 for ; Sun, 8 Dec 2024 05:21:03 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; spf=fail (imf09.hostedemail.com: domain of dafna.hirschfeld@intel.com does not designate 213.57.90.13 as permitted sender) smtp.mailfrom=dafna.hirschfeld@intel.com; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=intel.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733635266; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3xt1/MndGH0L6wSbe0nAqcZk6hsetmoQZ9sNviP9pMs=; b=Q2k2Nyn5zb/KmbCzoYB3noaK0l/4wsVdue1ezyBt9Jol0NWMhl/umObOghipeeF7t2qF12 9YeeLTZDl/YHYv7SHMR1Q6x0gEudGooRoDNCr1Cq632vhb0OMKTogsdpsssa+r6xpdHwWq X07BZfyUwIoVKxcM3ptLy74vswjRwG4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733635266; a=rsa-sha256; cv=none; b=h64C8h1HGBB4TXjbsdYLRf0mb43h6lGf1EyvdjTh8RrB7lPPIjFdjOUt+qNjMCsKRrE0uk 3KYgbJulbeD6SRxxMKlRaeTpyAAHRlLB9oWxjvR9AdIkwKmr1cz1t7aQBj4wPpXoo4BIcX zWcleeL59LnMABLiNxxJS+umUDHj9ew= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; spf=fail (imf09.hostedemail.com: domain of dafna.hirschfeld@intel.com does not designate 213.57.90.13 as permitted sender) smtp.mailfrom=dafna.hirschfeld@intel.com; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=intel.com (policy=none) Received: internal info suppressed Received: from dhirschfeld-vm-u22.habana-labs.com (localhost [127.0.0.1]) by dhirschfeld-vm-u22.habana-labs.com (8.15.2/8.15.2/Debian-22ubuntu3) with SMTP id 4B85KuFn205240; Sun, 8 Dec 2024 07:20:56 +0200 Date: Sun, 8 Dec 2024 07:20:56 +0200 From: Dafna Hirschfeld To: Muchun Song Cc: linux-mm@kvack.org, akpm@linux-foundation.org, willy@infradead.org Subject: Re: [PATCH] mm/hugetlb: change ENOSPC to ENOMEM in alloc_hugetlb_folio Message-ID: References: <20241201010341.1382431-1-dafna.hirschfeld@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 350D6140002 X-Stat-Signature: eydkmo77pa8maekmcdd76du51sroo4oy X-Rspam-User: X-HE-Tag: 1733635263-504994 X-HE-Meta: U2FsdGVkX18b6dp0lHjGE4sppA3YCARsoKpR2b13SSaP4oTNAbQlu+1lPekT3KGOxcSVSWXgErBicTPAGydvohV1aoxe4+dfTsNuNEW3ua4MQa1T/V1p77ECAA/tmsWS3PkAqMSUqk//xHNwbjdwUXaJdn4HveOgpRcZm1hiN6gk9HN4NMGLiUtsKWaWpA8o5O1QXo10Fgcxiwp7k9YfRTfzT3DWCKuQLQ6+/hkdeueOnWiUiH/0cduaS/cilRWuADbFx2hWTWE8Vjnf7zWQxmxs5EXsuybGpZQVQ8hTXp6VywpHJf/yRvcED0M5vCHboUGkAqHIoxFOLukPKPM0xJ1+u5vvSyrCutidunI039IQYthulNipA+yx7aodwGfQccww60FCc5RS9kcvtmBpGkBV+HSs5qDWX8924A+hIrUHOV8fjxzLFjjWDDVFxKNROHINAbaGCE+X4iMx0mI+zjCFb9Pju614MAoUXlSpZLUmT+IFIVvSz6qofpVyOxlU/X5JM2dyOHGgS5QipvFvIDtRraGmcQ2E1jb5ZCNl+h22UK5D1plfIC/WgAiWZWN6EdGf/8WgoOL0dDd1Jb8dQJt8vQvM66pL2Us5wZk4QEnUNz2E/z1ydyM7kPTdRTWgTmk6bsMwpE9TmHCN0//W5WmRS8fIkfmS/ZV035uwr03G/JmEQuftE43YkcS59EzNbRUpmS7uH7TUvBs9E32MJAuAAi5ctDn3BunMBNucfEdcD+Z8OvAulP+gNOJflfKl3rtUI6GBwG5RIHFLQ1e1iW1Z/ZjSxm6SagDF6enLUerjlWIhZQ/kEXeOPrOC4Nv6V0JzEPjhlNmY5jOYPg5azT9v2tZuuhEbRSTdVrLPf3qWe94TnKYOcB6x0m3YpfGGo4GaYvpp6WR2MdcBMgrDtOQhA0oJqp8KkJFHipIIloiNtt0F6Wb1MtWFRvStHqGHjKvN5lP96hJ0wbwY1Jh DeIxUzW2 ONtSEdqXhEMzjO2Pl+WNrFJ/mkUld6JhURycCU+MMi5lQl2SSoRJayb94TKuJXZIR+CqUkhgjo4UHg3IbZmJDx3286UDaHPLXlRpV80O7S5NwapD6AapW67NVqTXDF/+wNBfGPhWyUJOvlMOFQzeoOcMf6+tfTJPqPcqnT/4Xpb7GrRqfNIlj7pzYBH/eW9AjIw71nC/+E7eRR6+pxZGNhUreUtdz462HiNztGkdvU01gKMx2YhjwQnbJ7aYLJCYTdD+h40d3vH56VF0TBwSJQW+uKldyeTwY0COXn2LdeWsivBm2OfL/xWCoQOu5SbRUut0/wrXcR31QC16mMG2FqhrXDMl3eteqQuWXN+cU+ZJGehSYNA4DlBeEtOkWBDKlqMDg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.12.2024 11:49, Muchun Song wrote: > > >> On Dec 1, 2024, at 09:03, Dafna Hirschfeld wrote: >> >> The error ENOSPC is translated in vmf_error to VM_FAULT_SIGBUS which is >> further translated in EFAULT in i.e. pin/get_user_pages. >> But when running out of pages/hugepages we expect to see ENOMEM and >> not EFAULT. > >Hi Dafna, > >Refers to Documentation/mm/hugetlbfs_reserv.rst. I saw: > > If no huge page exists at page fault time, the task is sent > a **SIGBUS** and often dies an unhappy death. > >Seems SIGBUS is expected since it is introduced. Hi, I see that mlock do return ENOMEM when out of hugepages. It has the function "__mlock_posix_error_return" that converts EFAULT returned from "get_user_pages" to ENOMEM. So callers to "get_user_pages" can override EFAULT with ENOMEM but then it obscure cases where EFUALT should really be the return code. thanks, Dafna > >Thanks.