From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FBB3C25B75 for ; Mon, 3 Jun 2024 15:59:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF9456B008C; Mon, 3 Jun 2024 11:59:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA9836B0093; Mon, 3 Jun 2024 11:59:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B98096B0095; Mon, 3 Jun 2024 11:59:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A2E0D6B008C for ; Mon, 3 Jun 2024 11:59:18 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 096E1A172C for ; Mon, 3 Jun 2024 15:59:18 +0000 (UTC) X-FDA: 82190036796.19.2AC9477 Received: from out-182.mta1.migadu.com (out-182.mta1.migadu.com [95.215.58.182]) by imf20.hostedemail.com (Postfix) with ESMTP id 5B56B1C0017 for ; Mon, 3 Jun 2024 15:59:13 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="j/ffXtuA"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf20.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.182 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717430355; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MKoGptTMXtcmB2eFFZ/7XY8rNOgdyqaqmNPZWvIzDO0=; b=j3uOF2f16k8MulJpF6Orx+ORW9TER+qmbnF6ge59hPjvWRDZkTIUAdxUSzDnlP/bLlvFxE 9DKmk1o6OTaTnaVkTmAPO7mJMi1ioTEhyo1gK2fa25YsmTZNp2xRzXnpuN2V1mcM5H5OIx GEoOOrewB5ofAdZHSFYRbV+AneRHVog= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="j/ffXtuA"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf20.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.182 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717430355; a=rsa-sha256; cv=none; b=fVRxbhiGK1apgHKt0s5ytTIFKS7fWHuzlyWW/VMWjgs7vxXgaBTYjYTw3eboUyjTLSugxX UQv3awbEkvP56BhGldEcbtgGrUDHFbAOW2KhkiI3215a0aLrg7aFX6K08dp/A8FpEzCaNP edPINTaNiYirY9w5ZMUadGdy5WSg6U8= X-Envelope-To: hch@infradead.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1717430348; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MKoGptTMXtcmB2eFFZ/7XY8rNOgdyqaqmNPZWvIzDO0=; b=j/ffXtuAchUU9doHCLdXQra117sSslmTmLouztI03iMUCHHhKnCiG7fjtjSCIOZQqc1Ngo UIyxgqT0eVHivgaIDNVMmet2YK971dSuV/22x2uIlNtu9otWsKQR5JehH5rxEpMDXB3jfe eF57evHOLwmXdO17Lud7ye8kAbckYMQ= X-Envelope-To: bschubert@ddn.com X-Envelope-To: miklos@szeredi.hu X-Envelope-To: amir73il@gmail.com X-Envelope-To: linux-fsdevel@vger.kernel.org X-Envelope-To: bernd.schubert@fastmail.fm X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: linux-mm@kvack.org Date: Mon, 3 Jun 2024 11:59:01 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Christoph Hellwig Cc: Bernd Schubert , Miklos Szeredi , Amir Goldstein , linux-fsdevel@vger.kernel.org, bernd.schubert@fastmail.fm, Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH RFC v2 06/19] Add a vmalloc_node_user function Message-ID: References: <20240529-fuse-uring-for-6-9-rfc2-out-v1-0-d149476b1d65@ddn.com> <20240529-fuse-uring-for-6-9-rfc2-out-v1-6-d149476b1d65@ddn.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 5B56B1C0017 X-Stat-Signature: mq4p3mfqmxaq3oz3qx8repxw1iqms458 X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1717430353-848705 X-HE-Meta: U2FsdGVkX1/tlM+2HO7dtIbAJhQLk9NB4ZcXzrR6lCe8hKjZ0l8tPQbntGncscu7CYsOxml9STrBW27+uqY89gw+v4nHdmXaHWZJLcUGLRBm3ynstbTWw1ECfbxcuB3tdSujCtSEMK65FfkMbDAVJXhZH/Dq3IaxHR+cZ9X6ZQTWbH99D0uJFx/WUQfsLz26UCDOBb3VaVE3o8FI8vN3gYs2iGrY74arSYn7bhnMUNeI6G+7jB7lkU/6imj9dTO/Xna5flKQFuEKNAzF1na6pPznZ6/ikeZR8Nn7j4MKCghG8PkclFA2y9HtJfMwdx/G9/YsLtLxQXfnrLdp0BAYpDrC8pGmPVyyyr+n1a6y3zhXGsgr++WxdjLvxPp/wBtsLbu2W0rcRCtSlxRnWl4ova1MOaU41ojUxM8pU1KQMVsJEWEnrlQFbXHP2UMB00/uuFriCuVHrIT0j9CyCfAehKUHyNPTsp8UoUOA5slilBYDcR6GIKvqt+TRUb27OeZT7BDMWFfg3fXziWVwxVmYWvPGTr1sTYo4MjL5GYgcDq6zsVPzw2wqpEQdlL5aM4b9OSXX+lit9drmc0Fe2TPAWW5dTowYN6se7yKJsIltJOE1ey4yCrX0R1J1PGVzuesOU34YlJm1pwCDo6Np0mFbVcRKCLQiMCUEfNLtvLnMN07SUcfzhpLymOQv7HgB4YGgVDMVdyx74vZySnO9Bl9gbgCnAwPuGko6jxw7EgEuRVHaXpxyS5JITWWBh3g3p5wahfGQQbwNg5/qdSdvASeO4bZwjwlNvlwxnWlpPqS2P7i/PFfKq5GdxSgZNUwMAkvzaaPGm4M0ZhnbeyBaaOuLd1fPduUu33INx4ISpcGQMr/i4ku7hYOmVa2WEBiXQ/IFMTfxtrkeFvGSUVDoXF5aU8Cz03VWsSJHSxAJHK8OJOZrEHwUW7zMfXkk/Rm/USk8rmsL25/K+9zubwfvCpW mwAXrMxe MIMwf3rW+NhhUqA97QLbyfST08yQsdu9srgBk/bUVAQjiegiQs9Fn8JgYDQfd6G3zUD8bVaj0nWU/PXaC2u2QCyOwp/bFoYpb++Z9HVQpdhC+D3qbTY+ZUtyG8OM8hcwHmHP2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 31, 2024 at 06:56:01AM -0700, Christoph Hellwig wrote: > > void *vmalloc_user(unsigned long size) > > { > > - return __vmalloc_node_range(size, SHMLBA, VMALLOC_START, VMALLOC_END, > > - GFP_KERNEL | __GFP_ZERO, PAGE_KERNEL, > > - VM_USERMAP, NUMA_NO_NODE, > > - __builtin_return_address(0)); > > + return _vmalloc_node_user(size, NUMA_NO_NODE); > > But I suspect simply adding a gfp_t argument to vmalloc_node might be > a much easier to use interface here, even if it would need a sanity > check to only allow for actually useful to vmalloc flags. vmalloc doesn't properly support gfp flags due to page table allocation