linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Pankaj Raghav (Samsung)" <kernel@pankajraghav.com>
To: David Hildenbrand <david@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	 Jonathan Corbet <corbet@lwn.net>,
	linux-kernel@vger.kernel.org, willy@infradead.org,
	 linux-mm@kvack.org, Bagas Sanjaya <bagasdotme@gmail.com>,
	da.gomez@kernel.org,  mcgrof@kernel.org, gost.dev@samsung.com,
	linux-doc@vger.kernel.org,  Pankaj Raghav <p.raghav@samsung.com>
Subject: Re: [PATCH v3] docs: update THP admin guide about non-tmpfs filesystem support
Date: Tue, 8 Apr 2025 11:44:22 +0200	[thread overview]
Message-ID: <spuuu4rg3awuakis2qepqob33nj6ex2w2p7u4jbdv4fhvicnxe@dcec3e3eaz53> (raw)
In-Reply-To: <f4924ad4-c70b-4999-b595-01c488607189@redhat.com>

On Fri, Apr 04, 2025 at 09:16:10PM +0200, David Hildenbrand wrote:
> On 04.04.25 16:06, Pankaj Raghav (Samsung) wrote:
> > From: Pankaj Raghav <p.raghav@samsung.com>
> > 
> > THP support for non-tmpfs filesystem has been around for some time now.
> > Update the admin guide to reflect it.
> > 
> > While we are at it, move FilePmdMapped to previous paragraph for clarity,
> > and clarify ShmemPmdMapped & ShmemHugePage.
> > 
> > Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
> > Acked-by: David Hildenbrand <david@redhat.com>
> > ---
> 
> BTW, we should go over the whole document and bring it up to date.
> Interestingly, it starts with
> 
> "Performance critical computing applications dealing with large memory
> working sets are already running on top of libhugetlbfs and in turn
> hugetlbfs. Transparent HugePage Support (THP) is an alternative mean of
> using huge pages for the backing of virtual memory with huge pages
> that supports the automatic promotion and demotion of page sizes and
> without the shortcomings of hugetlbfs.
> 
> Currently THP only works for anonymous memory mappings and tmpfs/shmem.
> But in the future it can expand to other filesystems."

As a part of this patch, I do change 2nd paragraph:

-Currently THP only works for anonymous memory mappings and tmpfs/shmem.
-But in the future it can expand to other filesystems.
+Currently, THP only works for anonymous memory mappings, tmpfs/shmem and
+filesystems that support large folios.

Do we need to add more changes to the first paragraph as well?

--
Pankaj


  reply	other threads:[~2025-04-08  9:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-04 14:06 Pankaj Raghav (Samsung)
2025-04-04 15:32 ` Luis Chamberlain
2025-04-04 16:18   ` David Hildenbrand
2025-04-04 17:58     ` Luis Chamberlain
2025-04-04 19:07       ` David Hildenbrand
2025-04-04 19:44         ` Daniel Gomez
2025-04-04 20:01           ` David Hildenbrand
2025-04-04 16:31   ` Pankaj Raghav (Samsung)
2025-04-04 18:02     ` Luis Chamberlain
2025-04-10  9:31       ` Daniel Gomez
2025-04-04 19:16 ` David Hildenbrand
2025-04-08  9:44   ` Pankaj Raghav (Samsung) [this message]
2025-04-04 23:55 ` Bagas Sanjaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=spuuu4rg3awuakis2qepqob33nj6ex2w2p7u4jbdv4fhvicnxe@dcec3e3eaz53 \
    --to=kernel@pankajraghav.com \
    --cc=akpm@linux-foundation.org \
    --cc=bagasdotme@gmail.com \
    --cc=corbet@lwn.net \
    --cc=da.gomez@kernel.org \
    --cc=david@redhat.com \
    --cc=gost.dev@samsung.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mcgrof@kernel.org \
    --cc=p.raghav@samsung.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox