From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47A6BEEE25C for ; Thu, 12 Sep 2024 21:22:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D5EB26B0083; Thu, 12 Sep 2024 17:22:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D0E306B0088; Thu, 12 Sep 2024 17:22:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD58E6B0089; Thu, 12 Sep 2024 17:22:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9F7146B0083 for ; Thu, 12 Sep 2024 17:22:12 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 439A716098C for ; Thu, 12 Sep 2024 21:22:12 +0000 (UTC) X-FDA: 82557359304.23.2C23CE2 Received: from mail-oo1-f50.google.com (mail-oo1-f50.google.com [209.85.161.50]) by imf17.hostedemail.com (Postfix) with ESMTP id 6DFAA4000B for ; Thu, 12 Sep 2024 21:22:10 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=T5HLYCGh; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of justinstitt@google.com designates 209.85.161.50 as permitted sender) smtp.mailfrom=justinstitt@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726176044; a=rsa-sha256; cv=none; b=utjiXu9fBk6SFf00WE/+QXtMWiF3UUoqG1BqVWv0VwewtlZeRsk07RYJj6aPVtpU7wxZ9J uV0WAsJywNG8fvd2CVdHqBdWaTMEneqN4w0MbsUVneVTusDFIF1pjwQ74nNFujzJx6/3tL 7C6GUjVQEJIS30iZeJl1CGzUSAhNXXc= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=T5HLYCGh; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf17.hostedemail.com: domain of justinstitt@google.com designates 209.85.161.50 as permitted sender) smtp.mailfrom=justinstitt@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726176044; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zuU9UIhvXjSz78840FaGp7kb94KPeUI24x6/4WDdi4o=; b=e7yx0mhvzF/tmeXriqXXeHtH0u4dB0fCBGRAks3ixJ2p9BA/FZcLRZVRcVcbwvTOfVfEbK yfYDfcdjDtVFUMebmFQAxjvz9HitVtsGHwaE/B6i9KoWrSwBpxc0cH9kp34RyKe/O8l3Fv tLTObsQ3P0lF4EVfdHd8d90DJf+ts4A= Received: by mail-oo1-f50.google.com with SMTP id 006d021491bc7-5e1c49f9b9aso108689eaf.2 for ; Thu, 12 Sep 2024 14:22:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1726176129; x=1726780929; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zuU9UIhvXjSz78840FaGp7kb94KPeUI24x6/4WDdi4o=; b=T5HLYCGhs+5d4prjDO1dAVV3Uu4VleGA4foZQ4znVqH63458XOfC4+nS6IaLWxJYBd y6sOJhL+/PfwtzwpQxh3T4KK1Sr0dfDRdOP7A/F03Uq1DLcSfSifBVMQNVolA1xFIxb/ pixVpkINwF83UKOtAfj1Lw4Iuf3vZpooUcSQ0lXmfYF9G3q36xeGmxz+rAjHhjSG9qwO vEfZgaoYoZCYapqbLGf6PMS6D12+9zZVI4lMh3LPBNAA1iTCw5nI4o9HEbd+QT5f3Y5O WqIaYcu5L7hSl0OdiSViOx6c7EFEYMJO7x0vcMdzqaeLvRz286QB6RMl3cz3Xu7r93kI EXaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726176129; x=1726780929; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zuU9UIhvXjSz78840FaGp7kb94KPeUI24x6/4WDdi4o=; b=G91kGcjVcIUUFW4ywr0Vw/G70Fc1TvcXrLedJCJ9jLWcvhAKBH8kxoxSJ/MOe63QBp vEdPGOaPxak9QBOm5mWp1p8Xntq8v73D2aXeMZzcS812el+Uo3wQck81sstO9pwCusxU pnZMwUUdQgLVcY1xuqGg44dQtMYKUhWrIotiCFoclol+4owe1320sH7h1y2hQSzZAFlS gJKHRKAMd7wbQsPniB1KhFIT7TSaTJYCphOhcDH490ndNKgveRecIVUM/2xCYfu5u688 UkucIjpVGo6dOLRcr1lAdhoEs9SfNjV/4xuwT16IrAzhyv/fkJngh6UDHRQO8DzgbSnL xLDA== X-Forwarded-Encrypted: i=1; AJvYcCVkScJ1X2D1GO/yknWb+4SJneMLQmgmp/XRCNMjjCHuNU9II1OQdq6fTJPl+3iQzvO/pvgkBooHhw==@kvack.org X-Gm-Message-State: AOJu0Yz0y/d5Ylt26G2hTWMzO4+j+zNwREpUUx/ECGt6TEDbH1IwckA9 gSmc7ncBD6Bo0tfQHDXP/gl2IQjPMOdfQiSZgjd0A99IbyxKcvRhEYSYVsLzng== X-Google-Smtp-Source: AGHT+IFkVoD/Nk+SYy04kMCW6WhfdrSdzd/PRUZlVwBXDw7def1QUPBiiqZ1N65kkjgIJI+qKHmPfQ== X-Received: by 2002:a05:687c:2c2a:b0:260:ebf7:d0e7 with SMTP id 586e51a60fabf-27c68955c20mr593311fac.15.1726176129175; Thu, 12 Sep 2024 14:22:09 -0700 (PDT) Received: from google.com (30.64.135.34.bc.googleusercontent.com. [34.135.64.30]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-27ba3ebabfcsm3299170fac.24.2024.09.12.14.22.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Sep 2024 14:22:08 -0700 (PDT) Date: Thu, 12 Sep 2024 14:22:05 -0700 From: Justin Stitt To: Yafang Shao Cc: akpm@linux-foundation.org, torvalds@linux-foundation.org, alx@kernel.org, ebiederm@xmission.com, alexei.starovoitov@gmail.com, rostedt@goodmis.org, catalin.marinas@arm.com, penguin-kernel@i-love.sakura.ne.jp, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, audit@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, "David S. Miller" , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: Re: [PATCH v8 7/8] net: Replace strcpy() with strscpy() Message-ID: References: <20240828030321.20688-1-laoar.shao@gmail.com> <20240828030321.20688-8-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240828030321.20688-8-laoar.shao@gmail.com> X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 6DFAA4000B X-Stat-Signature: k4isqnnxzpkzjtb9njfose6dh5cgaq4k X-Rspam-User: X-HE-Tag: 1726176130-143201 X-HE-Meta: U2FsdGVkX1+zTC2hkFX3gB95LeLoynHnyuowN2fD6HOsYE2Bq46eWjssdPHPXZ+fH7dFK/nqCT+HpVbFob8ZDfQ/Wh0CakzuGyGyhYJxJOZsmqVm/8mhHSHN9sep4zZ1UCzQL4PhIHs5O2KISwGrJ+vZEfYb41gy3/tdpaFrQPqPUJJbfNg43DCaEQ7hp1hSqNDPE4lUc6ehvVbOnI6nuRJCv8fMtcMdrLyVTB5ivJv3NYAC6fe46+UOfBxBENCIcrLz3XrdhXHEjUCFHs2b/hSzrKNX+aMCkId5dkxHj0D4dp+yhh/0d8JVrne0fS58JHTX53LqtmQw8sIeQjHJ0DpOBj/arT0aaCUSPWPF7iKEdIGsJe03k7CFzsPh3WgmkFO3xhDrkXdQrSoZC1QfWWoOLp23BwhrT434Vy0ykQgcKt4GEH5xMtVT+L3jh7xRy3Kle0O3fBsOftgPA5L2GrHdhzQ5aI2yKLU10q9CuycqZ7WcWbMD9E287rr2Yu8yYbg45U2yBWRg6cQYAunETOtO+H94iVH4PxIGOJ1w7oieeUZVRgyxdWF5RdQl9AzSfKZQ0m0P5X2cotKaLoaQCgT1ZBtfF0UDJ9TUDO/SwYcT61ZqO8ge5JtlGNjCIzcBbBVpssmjvuA2omIoPsvaBeFMHs0gMdo3D5JDk/1L+esb6fRBAXRoSfBie1ORVYZRN0PMg+23ILlAC+stdTwnEkExUp+wh7j+pdPKY5CzXtNZXrBBIa0/mNf9YuUUY60ctyfthPB0rKo4xnmm2RPxqYgk3AaxJqZTAQ9kw14+mtPZLMMxGK/6bC5LOckTLgf5np95ukTwTkama90ytWAtDtv81qfbsUDQJwfOW6mp/7YLfnzXEdfEtVN+13KPsYToEnhX4DhtXSQNOutVSTDJifiVUvpYvVAhsABOUOjY/LeFO5I4U3WvAX4AR86LX2zsvFsSAyc28KZdIGU3CqJ UlypkQdf iwMCMwnZRF8iPwnNnn/IJtfpSMxdNfok42vKXUbaPsB50LWAuKzClRdAaGAbE/fwlpVCOv4JR8S3I2679jQ8/sZ4TggaC4QgZvQ9KjRs86O9djIn8XXpAselk+nET0YwFIms7SL5hjs9Kk8Y8CO0Lsle8fgBDmxauuCelRFSZnS41GFfb6g2cvJGNohfyBLtgIgo6TCx+GNmIMYNz4skTTGWOWMxvoz31r27Sp11kiglbe2xnMWx1fFKvLv3/4GcP9h3t2/w1HNJDN+8l3zg3Cf5aZwuOXv/F6U2ZJP+mOXxP7QM3VUTFUSrkkLyWBphJ04IcnxfewqYRR70njooY1cF9GmTMKPDVxHdtOc+ZLDHKRckt6BJZrQDNjcgOG39p9LhOoBEDBswWTzjNJaMN2erKjinFlasKk8eFwBF+ymK0gPR5bOiC02Fsx3A8F1zbnAQ2K5fqdP3iuv5VL2m5frTXHgYnNWyYuoGXIBazZHYUkRgBL7DSU8JVqUumegxw6U9EVLiegLigOYIjpvG9tD2/yTR34DdH72XSueCYE5zzFmk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Wed, Aug 28, 2024 at 11:03:20AM GMT, Yafang Shao wrote: > To prevent errors from occurring when the src string is longer than the dst > string in strcpy(), we should use strscpy() instead. This approach > also facilitates future extensions to the task comm. > > Signed-off-by: Yafang Shao > Cc: "David S. Miller" > Cc: David Ahern > Cc: Eric Dumazet > Cc: Jakub Kicinski > Cc: Paolo Abeni > --- > net/ipv6/ndisc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c > index b8eec1b6cc2c..cf7c36463b33 100644 > --- a/net/ipv6/ndisc.c > +++ b/net/ipv6/ndisc.c > @@ -1944,7 +1944,7 @@ static void ndisc_warn_deprecated_sysctl(const struct ctl_table *ctl, > static char warncomm[TASK_COMM_LEN]; > static int warned; > if (strcmp(warncomm, current->comm) && warned < 5) { > - strcpy(warncomm, current->comm); > + strscpy(warncomm, current->comm); > pr_warn("process `%s' is using deprecated sysctl (%s) net.ipv6.neigh.%s.%s - use net.ipv6.neigh.%s.%s_ms instead\n", > warncomm, func, > dev_name, ctl->procname, > -- > 2.43.5 > > Reviewed-by: Justin Stitt Thanks Justin