From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01820C369AB for ; Mon, 21 Apr 2025 23:37:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BC2D66B0005; Mon, 21 Apr 2025 19:37:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B47666B0007; Mon, 21 Apr 2025 19:37:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E9376B0008; Mon, 21 Apr 2025 19:37:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 807086B0005 for ; Mon, 21 Apr 2025 19:37:30 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BA8AC1211DD for ; Mon, 21 Apr 2025 23:37:30 +0000 (UTC) X-FDA: 83359665060.02.049BCD8 Received: from out-176.mta1.migadu.com (out-176.mta1.migadu.com [95.215.58.176]) by imf15.hostedemail.com (Postfix) with ESMTP id 228CEA0006 for ; Mon, 21 Apr 2025 23:37:28 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=BNgBdr8x; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf15.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.176 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745278649; a=rsa-sha256; cv=none; b=u/Qne5flbxOVrOdPFfI+kQSjUHYYRv8SSHRn9SATZ53OSngThjXMIBe8bEkzMwmkbBiP2u KVwKqi7SUGBuJUnCcuhCl4Vc5fkb3aGoznUltf18iciOX3jSuFK0AZDYXgs7wXx2TKYN2q M/n4a2qKZbVn+JMUAKJYoFnJwAgtdu8= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=BNgBdr8x; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf15.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.176 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745278649; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6iW0sWcGO1gvbOk/e+2PSHbPGtHAbNinELqlnlzCeUE=; b=j53up3MKNOOln7Xph5adbZRzEgSjKS0WtBC6Yvxb/3AoIakdLkO+mMgYWbbIF8nzjyYrnl Hc6u35277n9ORH/MYBlzh+3mbeV3/ieQiZ5SAQGGSlnSuEA/7zEbJrE+siPDo0LRpjxk8L zOMFoJCpP4NqmGGhoV7Ay0mChQqaifM= Date: Mon, 21 Apr 2025 16:37:20 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1745278646; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6iW0sWcGO1gvbOk/e+2PSHbPGtHAbNinELqlnlzCeUE=; b=BNgBdr8xLToLSABGJHQDRuIA1Sq5RmsJowUKjIfx8BKCbe6T5+LPm7rBUKmpR3OuqUJ7aI t3lscJp1GXo+um63hz1T9nA6zl8Y+Syh0+xRWNRQLEPLJZENn8R8zf2JogqBNBs2h0Vq5W R8g3EF3ywZlfQzMPMlm6P29ANQ7yXy8= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Gregory Price Cc: linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, longman@redhat.com, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, muchun.song@linux.dev, tj@kernel.org, mkoutny@suse.com, akpm@linux-foundation.org Subject: Re: [PATCH v3 2/2] vmscan,cgroup: apply mems_effective to reclaim Message-ID: References: <20250419053824.1601470-1-gourry@gourry.net> <20250419053824.1601470-3-gourry@gourry.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250419053824.1601470-3-gourry@gourry.net> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Queue-Id: 228CEA0006 X-Rspamd-Server: rspam04 X-Stat-Signature: uaek1h6ugq9fo18dui7stkuegc5dayyp X-HE-Tag: 1745278648-354522 X-HE-Meta: U2FsdGVkX1+jKHaH1zWePi6l6/UYARNCsfAik1uwCBSEUQtsMajow0iWyyYNKhNORh1btk08S7iRfQDcu5CPTPKIB0gjXhfa1hDkNXCkdB9d2ERt6VYY1AXXOLWJOW5vS9SqOPA+xyN35o3l1E67dTKOM3aIvgGrBLnRjDtbKz20z7qYLC+0U7uq3J1W7xJx9tLJ+US79iFI9olv9kamStildtM2xIEOM4ebhrbdUo6mI/K4eTL290IOG07pagCYlwopFsgIe+NLlGMvui9nbO3CIiu0OGV3fnmO80oiEaeTSeVscEqI5Xg/adLPc0jpqN+te6papRWsLG7awoDVHDe6PtSWkpWiGTAPptZvdikSlkRtXohmNXm2WwNcwZQOiXUi1zsk1wn3Fu8EMMQb7p6c8NVINF33Cz25kjcci2PJpi8if6iIK8Imy9kTqf2cyPLGTWy0g+QBh8pIA6ge0pOIgjoQraxEi2qi4E/VG+vS5ih7XYBJverHMj1CCz7BEZW0E2LWPNT9vCsDZd5A1NB7dyHJgzw4jggrYje15aTV5G3zfllAdWy226UJ2I8ZPHFQA/W3knkod8BTWs3zmmrtaThEnLtwyYOouCyoClcpx/rTv3W12MmP0+ZH+hxd0duYZojXvI7ngvlcV0y8dSMccZoUEyl0rTfxzcHCjcH3g1wyDduNwItBVKJwH4JMXpjF22ND0eS0KnHLOVX8GSiShPNcWVa+H/qxFwU04jmhvgPBzkZNyN5vR0C2Mkwqgoibddz3uTnq845Z2xjsbUbN92m5mUIJ23CP8iZa4phLkef3cvv4uQUhpUzsbRJA+mMOniSR1h0W+g/LLbE0BI76+zz9TQekjrKpS/5oe48ldwZM9Inb1bXwK4f4uKRFYZbQhaua9vT3OK1XRORxbzeuOLm9d7uD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Apr 19, 2025 at 01:38:24AM -0400, Gregory Price wrote: > static unsigned int shrink_folio_list(struct list_head *folio_list, > struct pglist_data *pgdat, struct scan_control *sc, > - struct reclaim_stat *stat, bool ignore_references) > + struct reclaim_stat *stat, bool ignore_references, > + struct mem_cgroup *memcg) > { > struct folio_batch free_folios; > LIST_HEAD(ret_folios); > @@ -1109,7 +1116,7 @@ static unsigned int shrink_folio_list(struct list_head *folio_list, > folio_batch_init(&free_folios); > memset(stat, 0, sizeof(*stat)); > cond_resched(); > - do_demote_pass = can_demote(pgdat->node_id, sc); > + do_demote_pass = can_demote(pgdat->node_id, sc, memcg); For code paths where we might have folios of different memcgs in folio_list, should we look at individual folios for their memcgs or is it ok to ignore such cases? If we are ignoring then let's add a comment about that.