From: Shakeel Butt <shakeel.butt@linux.dev>
To: Gregory Price <gourry@gourry.net>
Cc: linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-team@meta.com,
longman@redhat.com, hannes@cmpxchg.org, mhocko@kernel.org,
roman.gushchin@linux.dev, muchun.song@linux.dev, tj@kernel.org,
mkoutny@suse.com, akpm@linux-foundation.org
Subject: Re: [PATCH v3 2/2] vmscan,cgroup: apply mems_effective to reclaim
Date: Mon, 21 Apr 2025 16:37:20 -0700 [thread overview]
Message-ID: <snxed24sts5vsrcgi3aajxgngaswe2dtzf4kacfq7nyzc4aayt@4fmqp7i4gs3b> (raw)
In-Reply-To: <20250419053824.1601470-3-gourry@gourry.net>
On Sat, Apr 19, 2025 at 01:38:24AM -0400, Gregory Price wrote:
> static unsigned int shrink_folio_list(struct list_head *folio_list,
> struct pglist_data *pgdat, struct scan_control *sc,
> - struct reclaim_stat *stat, bool ignore_references)
> + struct reclaim_stat *stat, bool ignore_references,
> + struct mem_cgroup *memcg)
> {
> struct folio_batch free_folios;
> LIST_HEAD(ret_folios);
> @@ -1109,7 +1116,7 @@ static unsigned int shrink_folio_list(struct list_head *folio_list,
> folio_batch_init(&free_folios);
> memset(stat, 0, sizeof(*stat));
> cond_resched();
> - do_demote_pass = can_demote(pgdat->node_id, sc);
> + do_demote_pass = can_demote(pgdat->node_id, sc, memcg);
For code paths where we might have folios of different memcgs in
folio_list, should we look at individual folios for their memcgs or is
it ok to ignore such cases? If we are ignoring then let's add a comment
about that.
next prev parent reply other threads:[~2025-04-21 23:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-19 5:38 [PATCH v3 0/2] vmscan: enforce mems_effective during demotion Gregory Price
2025-04-19 5:38 ` [PATCH v3 1/2] cpuset: rename cpuset_node_allowed to cpuset_current_node_allowed Gregory Price
2025-04-19 18:37 ` Shakeel Butt
2025-04-19 5:38 ` [PATCH v3 2/2] vmscan,cgroup: apply mems_effective to reclaim Gregory Price
2025-04-19 18:48 ` Shakeel Butt
2025-04-20 0:14 ` Waiman Long
2025-04-21 17:39 ` Shakeel Butt
2025-04-21 22:59 ` Gregory Price
2025-04-21 23:15 ` Shakeel Butt
2025-04-21 23:58 ` Gregory Price
2025-04-22 0:10 ` Shakeel Butt
2025-04-22 0:39 ` Waiman Long
2025-04-22 0:35 ` Waiman Long
2025-04-22 1:00 ` Gregory Price
2025-04-22 0:10 ` Waiman Long
2025-04-22 0:16 ` Shakeel Butt
2025-04-20 0:31 ` Waiman Long
2025-04-20 23:59 ` Gregory Price
2025-04-21 23:37 ` Shakeel Butt [this message]
2025-04-19 17:21 ` [PATCH v3 0/2] vmscan: enforce mems_effective during demotion Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=snxed24sts5vsrcgi3aajxgngaswe2dtzf4kacfq7nyzc4aayt@4fmqp7i4gs3b \
--to=shakeel.butt@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=gourry@gourry.net \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=longman@redhat.com \
--cc=mhocko@kernel.org \
--cc=mkoutny@suse.com \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox