From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD2E0C28B28 for ; Wed, 12 Mar 2025 20:53:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E7461280004; Wed, 12 Mar 2025 16:53:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E24DD280001; Wed, 12 Mar 2025 16:53:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D1410280004; Wed, 12 Mar 2025 16:53:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B008E280001 for ; Wed, 12 Mar 2025 16:53:11 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A2447121670 for ; Wed, 12 Mar 2025 20:53:13 +0000 (UTC) X-FDA: 83214099066.19.AA5C890 Received: from out-171.mta1.migadu.com (out-171.mta1.migadu.com [95.215.58.171]) by imf23.hostedemail.com (Postfix) with ESMTP id D3D12140004 for ; Wed, 12 Mar 2025 20:53:11 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=UsGLiJTX; spf=pass (imf23.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.171 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741812792; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xx6hDBqC7+beBO1/VfyQkCDCm7ON1f33mSCbGvlmfNI=; b=yAn3W7rCLFJLd1AreKxaGkyrF9IFUSocoA4hYGIJ5vobWghVJiCNkwM3fBqqERh78Yp95y XVmuVZJQjrVlsiiw//p4dIOnjJyyXuU231cP7Gkl3cYpBxXQwHI41izavf1uxMIKaZaQuJ loBBMVX7o7LaDVc/7Ihsb4wIE6dUh/I= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=UsGLiJTX; spf=pass (imf23.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.171 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741812792; a=rsa-sha256; cv=none; b=OOPL8BbVpL8bBADmbNjgzgRo2bZAEevvsA05zNwsB9VP1hk2GM9WiUfRWlOeXTNHG34euS +lDoBhcCW0oXObizgYozDq2+X02pJ09PlXY7fsMS3/nNhtd7SCGKSKYuSVlZTNMBhldSlB AyggfJVkOBao0LaNg1qKxiYW1gZTP0E= Date: Wed, 12 Mar 2025 13:53:05 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1741812789; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xx6hDBqC7+beBO1/VfyQkCDCm7ON1f33mSCbGvlmfNI=; b=UsGLiJTX1GaOzd1cKuRZ+jd6dDCOro8uvPOiZsGzJBoqnxePWoIlM83JRLQYfOMK44WTL6 TS3TV+uz3bxaHwrKghs7FcvUDu274mlmkCsbjrYYha9ITmWwydoVq+v3rFfDr6FTDHzqJt V/6DFKsf06zx9JrXkss29DS4xLC9Vfg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: SeongJae Park Cc: Andrew Morton , "Liam R. Howlett" , David Hildenbrand , Lorenzo Stoakes , Vlastimil Babka , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/4] mm/madvise: split out populate behavior check logic Message-ID: References: <20250312164750.59215-1-sj@kernel.org> <20250312164750.59215-3-sj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250312164750.59215-3-sj@kernel.org> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Queue-Id: D3D12140004 X-Rspamd-Server: rspam03 X-Stat-Signature: zjb9foxwcwcj7fmwr8w1cd6qzkese1mj X-HE-Tag: 1741812791-291365 X-HE-Meta: U2FsdGVkX18Yp10dWV1KHZ3UTL80DqtamO4wl6oszINuyhSJLh6HBTCjjyqYhrbcFUDnS7bwHUKZBdqkjTXFaeIXy6PFgv9IG6y8LM+T9UEd7/Rp+2yFB7jMnwrp36MaIU+qsu3CM6GbsjOk5S5KM1yuZ0TDf8aHPyyCcvSX+A6yv4dqnZlkdKLDPD+fl3KHmQD2H7upgrNQdgIv7iq0cuM149PHVdsgc37i5OovHhMH1OCU67xaELWmW7/dia0oBv5dp9H8j+5S7BBpfqpMNNQECcoQPkMZnHFACqKfupVtZvDeRtofD/Dcn7JtXTlgC6rJ5iwrWAv5QxGh9Rm6C0JFlhHkHAyVVYy3O5U8oVpBPXs/dkAnu/IzEH5df+dqBpabOmrx+f/Xkv+x+QzULcC/s+eD3pTAVO5SJjLZTNf+1LX3KPbTmYPXKj4Gq/SIBEbP5sdcmtDGNYwC3FUMXsgGK8RQ1PspYXs/gh/XIae1GE2WjQmTMjdZdKlPSuOJ616H7mEaneRLB7E3krok6if7a4XzPCJ3dBR7pjU5M0w+KdK1CNK+t0I2oUNJIctNQjmf1GfaJlu9m39+R7onQffmJrit6pUL8/z8urpi7FezSCcPWKRydTj39e7nGpyINkJ+SFgx2uV+71XeswA6PIE16L9SjA2fYDbgmrlYuBGu58bEABsi3ml6Sud5wIOK0tPTM/10t7nV4muu3wDeMWlR8YYchixk+WdXkx/3Zpna1G/x3ngj+V9pvgQwUumBKjeurv6ZmyZdMIZPKNjOhoLVe1wqi/jpsH0Qvzy0J6S4Awo5pFbjBtGc4aIfgAmW+NoFEhISyzppvOcaN2Tk0BzSgD780rJ9HfsO70oZ/IM5HaAf5rrwQGP63xw755H4bOrMUpHpmlPrSDFMUrB364nd5aD5AP9XgfwVthr5xuxG/62J2k75pWJA3KZva9vEXEU/271KLprAqEgal2n svAFfYS/ pS0pVsz0jbbfF8a7m2wgmp1zHDbXEGMBAxe9i9Fs8BB/XDY1vYC9Z0ypg1sGRk2upqIBzP0GxY+dem71ltmAHlZBgktoBvzADZ8phQMxvlrix/seJtYwuwz1eUQ5GMQoUrpaBkgjhQt9uoMLy+dWvNmtT9NyxMeLMKdOlcr0AYQLCVjbH51LwCzsFJYNP5G56Czbfj0UP7zlRkNVFv+6cbb3NcTmSIz34+Czx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 12, 2025 at 09:47:48AM -0700, SeongJae Park wrote: > madvise_do_behavior() has a long open-coded 'behavior' check for > MADV_POPULATE_{READ,WRITE}. It adds multiple layers[1] and make the > code arguably take longer time to read. Like is_memory_failure(), split > out the check to a separate function. This is not technically removing > the additional layer but discourage further extending the switch-case. > Also it makes madvise_do_behavior() code shorter and therefore easier to > read. > > [1] https://lore.kernel.org/bd6d0bf1-c79e-46bd-a810-9791efb9ad73@lucifer.local > > Signed-off-by: SeongJae Park > Reviewed-by: Lorenzo Stoakes Reviewed-by: Shakeel Butt