From: Shakeel Butt <shakeel.butt@linux.dev>
To: SeongJae Park <sj@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Liam R. Howlett" <howlett@gmail.com>,
David Hildenbrand <david@redhat.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>,
kernel-team@meta.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 2/4] mm/madvise: split out populate behavior check logic
Date: Wed, 12 Mar 2025 13:53:05 -0700 [thread overview]
Message-ID: <sjgymc3obocmguvggi3eotsl2dpw5qannvi6dh5hez4ake6idt@xot7rfb5z4uy> (raw)
In-Reply-To: <20250312164750.59215-3-sj@kernel.org>
On Wed, Mar 12, 2025 at 09:47:48AM -0700, SeongJae Park wrote:
> madvise_do_behavior() has a long open-coded 'behavior' check for
> MADV_POPULATE_{READ,WRITE}. It adds multiple layers[1] and make the
> code arguably take longer time to read. Like is_memory_failure(), split
> out the check to a separate function. This is not technically removing
> the additional layer but discourage further extending the switch-case.
> Also it makes madvise_do_behavior() code shorter and therefore easier to
> read.
>
> [1] https://lore.kernel.org/bd6d0bf1-c79e-46bd-a810-9791efb9ad73@lucifer.local
>
> Signed-off-by: SeongJae Park <sj@kernel.org>
> Reviewed-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Reviewed-by: Shakeel Butt <shakeel.butt@linux.dev>
next prev parent reply other threads:[~2025-03-12 20:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 16:47 [PATCH 0/4] mm/madvise: cleanup requests validations and classifications SeongJae Park
2025-03-12 16:47 ` [PATCH 1/4] mm/madvise: use is_memory_failure() from madvise_do_behavior() SeongJae Park
2025-03-12 20:52 ` Shakeel Butt
2025-03-12 16:47 ` [PATCH 2/4] mm/madvise: split out populate behavior check logic SeongJae Park
2025-03-12 20:53 ` Shakeel Butt [this message]
2025-03-12 16:47 ` [PATCH 3/4] mm/madvise: deduplicate madvise_do_behavior() skip case handlings SeongJae Park
2025-03-12 20:53 ` Shakeel Butt
2025-03-12 16:47 ` [PATCH 4/4] mm/madvise: remove len parameter of madvise_do_behavior() SeongJae Park
2025-03-12 20:54 ` Shakeel Butt
2025-03-13 5:30 ` [PATCH 0/4] mm/madvise: cleanup requests validations and classifications Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sjgymc3obocmguvggi3eotsl2dpw5qannvi6dh5hez4ake6idt@xot7rfb5z4uy \
--to=shakeel.butt@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=howlett@gmail.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=sj@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox