From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: "Juan J. Quintela" <quintela@fi.udc.es>
Cc: linux-mm@kvack.org, linux-kernel@vger.rutgers.edu
Subject: Re: PATCH: Bug in invalidate_inode_pages()?
Date: 09 May 2000 02:29:32 +0200 [thread overview]
Message-ID: <shsbt2gh8gj.fsf@charged.uio.no> (raw)
In-Reply-To: "Juan J. Quintela"'s message of "09 May 2000 01:39:18 +0200"
>>>>> " " == Juan J Quintela <quintela@fi.udc.es> writes:
> Hi
> I think that I have found a bug in
> invalidate_inode_pages.
> It results that we don't remove the pages from the
> &inode->i_mapping->pages list, then when we return te do the
> next loop through all the pages, we can try to free a page that
> we have freed in the previous pass. Once here I have also
> removed the goto
> Comments, have I lost something obvious?
Unfortunately, yes...
Firstly, you're removing the wrong page (viz. curr = curr->next).
Secondly, we're already removing the page from the mapping using the
inlined function remove_page_from_inode_queue() which is again
called by remove_inode_page(). This also updates mapping->nrpages.
So invalidate_inode_pages() is correct as it stands.
Cheers,
Trond
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/
prev parent reply other threads:[~2000-05-09 0:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-05-08 23:39 Juan J. Quintela
2000-05-08 23:51 ` Linus Torvalds
2000-05-08 23:55 ` Juan J. Quintela
2000-05-09 0:29 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=shsbt2gh8gj.fsf@charged.uio.no \
--to=trond.myklebust@fys.uio.no \
--cc=linux-kernel@vger.rutgers.edu \
--cc=linux-mm@kvack.org \
--cc=quintela@fi.udc.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox