From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0064AC2BD09 for ; Sat, 29 Jun 2024 00:52:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B33C6B009D; Fri, 28 Jun 2024 20:52:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 763B16B009F; Fri, 28 Jun 2024 20:52:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DCD66B009E; Fri, 28 Jun 2024 20:52:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 416526B009A for ; Fri, 28 Jun 2024 20:52:42 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E051740822 for ; Sat, 29 Jun 2024 00:52:41 +0000 (UTC) X-FDA: 82282100922.30.B8EC6C8 Received: from out-187.mta1.migadu.com (out-187.mta1.migadu.com [95.215.58.187]) by imf27.hostedemail.com (Postfix) with ESMTP id C7B2F40008 for ; Sat, 29 Jun 2024 00:52:39 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="ll/8mQxs"; spf=pass (imf27.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.187 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719622342; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ff7tgazsT1nDgKOq79Cr0QpW2ZWTgrWkaozuK1JvS3Y=; b=xcFVh714jIENKt38pQi6hPUZRzbcRqdOLZgaqhxNFtEv5MzcmuXKKPcY/gmcyoc9U0h0wz xeIVvx8RMdP4mFW7G9VitVk27bo+T+TxeWigzyCQfOCBhrDkap43Csv55ytMqUR7Hp8vsH v/Hw+d0uCqc2w0+T17Uhl/vDctHmrJU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719622342; a=rsa-sha256; cv=none; b=NRAk/bVr7eygnPICmGQPw9Q4LHJtQtYcPKcEnN9ApMPb7izegUo9K3kMXKQ68bYAgzt5zr v/kFQ4cRKbFFnA8Fh+xBjXKdSm2aMyNGe0qSzC5fQdfzfeDahsjtKOxUT/Ey+TvfJurO4E XwoMKAyidK2Af2hr2V8jr2O81XoIk60= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="ll/8mQxs"; spf=pass (imf27.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.187 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Envelope-To: roman.gushchin@linux.dev DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1719622358; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ff7tgazsT1nDgKOq79Cr0QpW2ZWTgrWkaozuK1JvS3Y=; b=ll/8mQxsXlF/QH5BVlusnu5oJPHaCMPL7A5SSZFVIIFzYWduMYqo5CvFbBV0asAQxdNeiM lc/uYs4zpEqv1kC5WwOgYlkDi+hYiBMz4GbCTB5xl9azSSBxAZ35WGqPR1qRE2JPFYFZ8N Lld56mIXUuvcz9wHhS2hkmxkqz+xCN8= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: mhocko@kernel.org X-Envelope-To: muchun.song@linux.dev Date: Fri, 28 Jun 2024 17:52:33 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Roman Gushchin Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Michal Hocko , Muchun Song Subject: Re: [PATCH v1 7/9] mm: memcg: guard memcg1-specific members of struct mem_cgroup_per_node Message-ID: References: <20240628210317.272856-1-roman.gushchin@linux.dev> <20240628210317.272856-8-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240628210317.272856-8-roman.gushchin@linux.dev> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: C7B2F40008 X-Stat-Signature: adbhiaegyndkbooqase5sxzjism85poe X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1719622359-876068 X-HE-Meta: U2FsdGVkX1+lXywgvCvLP1l6GgoYQpOmDfhbevdTFWxu9qfjr9rLYf1nuSoqoRKoFSacOfsUFauWytvaoap8PBKx5JcLIO4YcA4YmqhPB/fEgtUV7VYnxd43JYt/rYb4pGpJfhWOS5RT+XnBxU4lF00LY3D7TcOcFm2blQvHZ0Hv6iBYsE9gq0D1rEJEstLWUiYNSgcYa/JM5NMieV2X3skNnJgYIp4C602h0WTBcwwTrfDSmcQ09UVUu6cJtHZ/J7ihmSG9mmtTL1tYcxFlZcmVVrOS7L55ogYvK2ZiPOziqSNC1CoXeuvI0fNlP62a7RyV5RI3w4fNVT0FHFVxlLNt2GOJwus92pIq/b/pUdoyOOu6Aip8gE4CgyZJsHoQ3OtsCBEXQgAXS3mu4BcfCLuH/k80G20XR4tlUYcHBnUvRLVF/TeL9XE8/NPf/jJEf2/cegjmf60OMd47DrQeTiPn9ctKtt/kr2z0VFZh5lemViy2AeNxCkc/PN2nUWRDZ3fwScPPWmu+bDRfL+hnDjy7YS/G4batEwioCKjiKnG8P5Cille7ilc2Vmj2lYEY4Q2K0oTruaoIMNHGnffjedA1gS9WVAepvxuEMLln5YYnfb8627NwgvQhG6R1i+p00Vd33I+xWdzOaW1h2v94+TB1bKioNTVt21VGbgOI1f2yd/XRJWWo97yFbZ21y4ZDCKJ1wABhFzq2Sn28mX1R2n+9fUN39GOgVkau5BndsbfOj8ztBnIx/NW7lkKmO3SaHx6hE5ob6XpFkP3ebzmiRYXQSkgPoHMVWCtn3v/xgP9HTtrdxv8idlIX0iiF2hQzHmG3Edz8D3/LMSUa9Rn7aubgNQgUq6xDQc5h4Gx/u3yX7Tw3Vn4hIO8sLEL+hJsQoB5fJukCDFUBfXzxndg/V+7HmIhO0qBj7yP4dlRF2JmXXQoerOdulq5gP99dqlxf8tmt4X8XZeHmS12m+Hf ag26hf7B 2JYQ7QZNck5C53NaROxWCkHtR7uQrGLgjvDqNlwY8SRE9l67X7MtoHdyYCcDM/nPgHrrDdRYkzUhDK2j3V5+YRLIdIBiHfGpQ8RWx4Q950JsQOAk1ez7zaMD4glzox801v1oQYejEkd7C76c1I6Jj0LzYaZUH6Y/NsAee X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 28, 2024 at 09:03:15PM GMT, Roman Gushchin wrote: > Put memcg1-specific members of struct mem_cgroup_per_node under the > CONFIG_MEMCG_V1 config option. > > Signed-off-by: Roman Gushchin > --- > include/linux/memcontrol.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index 107b0c5d6eab..c7ef628ee882 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -92,6 +92,7 @@ struct mem_cgroup_per_node { > struct lruvec_stats *lruvec_stats; > struct shrinker_info __rcu *shrinker_info; > > +#ifdef CONFIG_MEMCG_V1 > /* > * Memcg-v1 only stuff in middle as buffer between read mostly fields > * and update often fields to avoid false sharing. Once v1 stuff is > @@ -102,6 +103,7 @@ struct mem_cgroup_per_node { > unsigned long usage_in_excess;/* Set to the value by which */ > /* the soft limit is exceeded*/ > bool on_tree; Here we definitely need a padding after the pointers and before the lruvec. We can add a #else to the #ifdef CONFIG_MEMCG_V1 and put a cacheline padding in it. > +#endif > > /* Fields which get updated often at the end. */ > struct lruvec lruvec; > -- > 2.45.2.803.g4e1b14247a-goog >