From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 187C2C5AD49 for ; Thu, 29 May 2025 10:51:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D6826B012D; Thu, 29 May 2025 06:51:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3872F6B012E; Thu, 29 May 2025 06:51:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29CA66B012F; Thu, 29 May 2025 06:51:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0A2AA6B012D for ; Thu, 29 May 2025 06:51:59 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9AEE0C0DA5 for ; Thu, 29 May 2025 10:51:58 +0000 (UTC) X-FDA: 83495630316.08.584B977 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by imf25.hostedemail.com (Postfix) with ESMTP id 610ABA0005 for ; Thu, 29 May 2025 10:51:56 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="D3cr/Aiv"; spf=none (imf25.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.198.163.16) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748515916; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1u9CDCRUlY0DAIdBTAqR8ea0gMwXlqUpp7QpyDfG0l8=; b=zq2pCVUmrMXipAuU5vIfnuLp4v8DmHKZSzJ5JpXqwFNBsbBaERXe0+0lX0zhFg6/MrjyTL K4Hrh5kcA4mll/PjhPXxF2eKCRZEAhzzoFmxZl+Oem4jfO4a94Q+WF0Bzkmg9HLzBiPPzd I+GzoPwIky05KG0AW7QDpSFhdmtw+b8= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="D3cr/Aiv"; spf=none (imf25.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 192.198.163.16) smtp.mailfrom=kirill.shutemov@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748515916; a=rsa-sha256; cv=none; b=e1cJupPu55jD0O2YrUwhhw5vLOOgWDf3pmkQp3FINl25eCDIy637J4HIRlnX4/8HA04roz sH6N3mywBhHTC/B2ZsxiDeexsOPJ2IJ0j1v8QpHcmD6edVo7sNnBO3fiKRtefDJ6K0an4s kg9ZocSnOSoaQcpPMC+4LHd3hsmKZj4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1748515916; x=1780051916; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=CV3Segr+veKxtyhySTzj+LnOToA4J4nvptR6pD+VoRE=; b=D3cr/AivU2cmoclyZK+wicu9OkTmcjA4TklIepDvMGrboewZHH2/TIqM eTiBUSIVbAr2cZpyK/JUjU3+2aArna7OFsfLr01AKK8JTNNHgy5YE6UWM icejfI60AUeqNsOfoOjvrkAkYhKTJoKRWNtOLk7NAhk9VayIkvC61u1kW nGFAdAcoeUssURXll9S2UlOGEIfAenjGVATFK5uSRnowtmYv00VavwnUG RsrPNfNlfVbmWhAhhs17wajKyboTJmDnMmxk+ERSmnvfNTVferHL7HBzm Ib817oW3EStgEzqil0UQQgS/Pqw1G7VbsdggOxB4sHGDRGAClILFzMyTU A==; X-CSE-ConnectionGUID: go/159MDQtSEu8Q+a2zMtw== X-CSE-MsgGUID: BFqBto5VTQe+mgQ1gvfDzg== X-IronPort-AV: E=McAfee;i="6700,10204,11447"; a="38193290" X-IronPort-AV: E=Sophos;i="6.15,192,1739865600"; d="scan'208";a="38193290" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 May 2025 03:51:55 -0700 X-CSE-ConnectionGUID: zDBZD/qxTgOe40wSfVsqqw== X-CSE-MsgGUID: l4kaQccHQHq7ivgnE+yDOA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,192,1739865600"; d="scan'208";a="180722481" Received: from black.fi.intel.com ([10.237.72.28]) by orviesa001.jf.intel.com with ESMTP; 29 May 2025 03:51:50 -0700 Received: by black.fi.intel.com (Postfix, from userid 1000) id B8FE914B; Thu, 29 May 2025 13:51:48 +0300 (EEST) Date: Thu, 29 May 2025 13:51:48 +0300 From: "Kirill A. Shutemov" To: Vlastimil Babka , Konstantin Khlebnikov Cc: Andrew Morton , David Hildenbrand , lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, rppt@kernel.org, surenb@google.com, mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hongyu Ning , stable@vger.kernel.org, Christoph Hellwig , Hannes Reinecke , Johannes Thumshirn , Jens Axboe Subject: Re: [PATCH] mm: Fix vmstat after removing NR_BOUNCE Message-ID: References: <20250529103832.2937460-1-kirill.shutemov@linux.intel.com> <7ae9e9f9-80e7-4285-83f0-a0946d238243@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 610ABA0005 X-Stat-Signature: wcar4ogjjyepkjsiizm1cr9d354hoj4m X-Rspam-User: X-HE-Tag: 1748515916-522320 X-HE-Meta: U2FsdGVkX19Um7H4FCYj+JVHPdmty9W7MTtIxcwHRtVJJ6z/J1LAsaamPYEWc5J4ofjCrPzz86c+7hzkLe2+6Q/EHuaA8ykufokZExBjEQa3wr+cF62GNfSSmUjof3a/BEAhWnJYawZ5fN7aS2gbCuoUslfc5uKFCLefLCpJ/t4OPMiv1MiuSFzq5se41+g5SjPUZuYKv5wjJTv9V1s9oX1wTLd31zZFr2PnruBSlGAwt0a5qTInoOavXPRFGfgUPqHf65VtSD9jjX62Tm50ozjZK1t1YZPZwcDpbQ7zhH2YQl/tY/EAtrvMCtS3vZcWHphkapv6WGrGqdI54kG9nm7JJG1N7vt+0UXMmTQrwrENzI4woosRmZoZNo12OFHVBssxjo99MHSkWWyJVqWN9nha8KTXDpYs+TPGFhjmuLhILzZFFfi1mL2IVoMMJ5MNXAQmCPzCTIthw6Eo/YsfmeW7Ws7yBwGhum6uFsO0QhRCKRblKw0B5kx3DxQw2ZeQqEat6k56fwBWsvg8odGFrTL9VDEQQ0Duir1nwArHQlhZQsv0pBuPP9jhJVhP0emGlVMs7INFW1KO6BkbXRUbfdnNfvPaxMFMlRf6WU1cPvBnTONV5KXctXsqkyBiyjWrp1AniNBspju2ph6Orcn8yobBQOqu5kALYZaznMP0WgzoKOFOFWGTmWAVi5jmKFnZ1pQc/8kYF2125EQ8LTq7/ITLmr49BDp2KRUAL6kQPIY+9sCKIwzGoa3ZtIsiViW5xTdBcrVuvatGpt2L/heMLVFPtBOHNX2xCqnpBR6390yfnINbLlWZx6zUb9OPtGBeuECLTVX7zpagdaWngTiXk13Y4hlVa843y8Emrs8ssh1qJJaElwgssgfCrAS+bk7mQ+alGr6inzVvRDhDMPoMDlirltHS6UKzGxUGHRnMAJAvzBA3nUbq3UpVmddAvM2bDazN1x97eptmz63qtuT 3lniVb0Y s65Lv1J03tkbsxA1BK1USFRL0DJ+W4C2oA/pwC+rsN3MFQuXbe7zhPry0RwdslXvCMaE3dypVN1jsO+12gTxpnTgGhoQqfOqUPM5g/RspLFdRE4jj/UaERKkdR1sfq2KeMq7mqdJXFlQrrKgGaa4W38NJ1C4EjnzjvxD7M8EsQpKWRGpkN+9llJcjMsAKDlL6VMq9LDbbb3Ehhymnc0jXTVH3YmucBz5blXaSpI80XzTehgPZgMU0Ml/ry7sHlz3a5iefUrou7i6Ux4UHrttBXJUhjNqoWH35H+gpAunpiZxEs5LPl9ICzFQYZ6m/1Oavag89CkG/ay0eb5/9Ycq7RYn5DQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 29, 2025 at 01:47:10PM +0300, Kirill A. Shutemov wrote: > On Thu, May 29, 2025 at 12:40:21PM +0200, Vlastimil Babka wrote: > > On 5/29/25 12:38, Kirill A. Shutemov wrote: > > > Hongyu noticed that the nr_unaccepted counter kept growing even in the > > > absence of unaccepted memory on the machine. > > > > > > This happens due to a commit that removed NR_BOUNCE: it removed the > > > counter from the enum zone_stat_item, but left it in the vmstat_text > > > array. > > > > > > As a result, all counters below nr_bounce in /proc/vmstat are > > > shifted by one line, causing the numa_hit counter to be labeled as > > > nr_unaccepted. > > > > > > To fix this issue, remove nr_bounce from the vmstat_text array. > > > > > > Signed-off-by: Kirill A. Shutemov > > > Reported-by: Hongyu Ning > > > Fixes: 194df9f66db8 ("mm: remove NR_BOUNCE zone stat") > > > Cc: stable@vger.kernel.org > > > Cc: Christoph Hellwig > > > Cc: Hannes Reinecke > > > Cc: Johannes Thumshirn > > > Cc: Jens Axboe > > > > Is there a way to add a BUILD_BUG_ON to catch a future case like this one? > > There's > > BUILD_BUG_ON(ARRAY_SIZE(vmstat_text) < NR_VMSTAT_ITEMS); > > in vmstat_start(). > > Making it strict != seems to do the trick for my config. But it requires > wider testing. > > I can prepare a patch for that. There was a strict check before 9d7ea9a297e6 ("mm/vmstat: add helpers to get vmstat item names for each enum type"). Not sure if changing != to < was intentional. Konstantin? -- Kiryl Shutsemau / Kirill A. Shutemov