From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08560D5D682 for ; Thu, 7 Nov 2024 18:58:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6DD116B0082; Thu, 7 Nov 2024 13:58:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 68CD96B0083; Thu, 7 Nov 2024 13:58:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 57B9E6B0085; Thu, 7 Nov 2024 13:58:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 394016B0082 for ; Thu, 7 Nov 2024 13:58:31 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9EA6240AD3 for ; Thu, 7 Nov 2024 18:58:30 +0000 (UTC) X-FDA: 82760209602.02.AA29DB7 Received: from out-170.mta0.migadu.com (out-170.mta0.migadu.com [91.218.175.170]) by imf26.hostedemail.com (Postfix) with ESMTP id ED2DF14000C for ; Thu, 7 Nov 2024 18:57:59 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="lt/XvT3v"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf26.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.170 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731005739; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oOrEHRshDF9blVgV66yZ84VAGXSGB+VroUL5spNDfyI=; b=4C2zrQVaJM/HloZzTdSqUrWKDT+SKUvQku5pqi8ePvDXbmJB1QQYVtrz3gqdoNjPB2l5IU jnMrwnoEcxLSoUU7719AhfgZ6AE9j+v/KOGsaX5CcAlf+ve+5IucMLU+6mymGXisd3tXOH gcm44WBOKuI9BH0clE5EN77mHnK2dzA= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="lt/XvT3v"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf26.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.170 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731005739; a=rsa-sha256; cv=none; b=34XVCa7UV0bdj1NmvWWPLrTPjfEksQ7sRY7WqdVcpb8dcOkUVFsXl5+rSoxwcLsdLN4+90 VWu1qzIbfdhHUzHGaC+63ev51W2OVMCw6o7y1c1V/rv0X+5p7OfodH5/LDs1V+XdT3xe7G PrOh0mZ8Qe1p87tDvg7bMWMMRpVRSx4= Date: Thu, 7 Nov 2024 10:58:17 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1731005903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oOrEHRshDF9blVgV66yZ84VAGXSGB+VroUL5spNDfyI=; b=lt/XvT3viqqoO4qw155IHqD/uzvQ8lQGEBq4ok96xykQQflmLF+gKGfpOiwZ5o2M+/fmhd Znl3cQI/dA9BGrheuG8Y+SLtTNe+r1c/7gA04JpVWkmMQWGrOdk6Q8Ne0avPzFdgStcKPQ lWqD8OJVLsK7Ers/IZG4RfrL0k+Zk6E= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Joshua Hahn Cc: hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 2/2] memcg/hugetlb: Deprecate hugetlb memcg try-commit-cancel charging Message-ID: References: <20241106221434.2029328-1-joshua.hahnjy@gmail.com> <20241106221434.2029328-3-joshua.hahnjy@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: ED2DF14000C X-Stat-Signature: 5pj74paqgsycktpj7kd5gw8f4sxhmnkt X-Rspam-User: X-HE-Tag: 1731005879-855725 X-HE-Meta: U2FsdGVkX19AATw5FsE27rg6pWEH6nvdDFPHI2iQpYvvmRYndniPZhbaMpZFMGYSPk/BivHczD5S+wE+tU7csVMDSfSzOTJ/RtBDWiLIo6NpAkwQRgXN3mDpdZ6ioUm59hs82BKoF6yBCpBJU85kq2/0ZKu8i78L10g2cDaR0eeNZAP+GWnDGI/t9TcMDckM0/lONHpoQeXAo/pd7Lqbe6yXcxqzUxuBGCvlfWT5Ub8zkIaXuUcpRJ2o9I1bAyWC02A2XUrRaIY3DJ0j+QOWHnnULm5PS8ldlc0Nk5+ZkINkRJgS6dKtXz63krqvKQkA4Zr1LBDQWjc3a5Aa/+X6Tx1bzlJZ7+vbHX8lZkoZAOMzX6qkLbGJEBm1z9rW7isf5VwsLDFfkO46IRyE5NNR0Vy0Az31VvV+Yp7BymE+AVm0KF326pwymbB9trOi6ekz/1XqVNFbiHS9KntV02bvN4K5VCbFbLJYImos/3xTHVk4tjhAA+HNCZD+k0MTZP0Duz1VmPD+za7HHaF/eDvERgWy7XhuMhc8TLY/OR+judTA71ZIUl+3HraAPGZrYsyB/K8Gc04KugWqP7+0pWibKv0k8XXu+zuHTRtF309agQBzW1axC4FQRBkCUoMShVBPLzwkKz6v+k4qcq9tKxY5zmjxvuwlMOQp1zTj4MHyb8e6K/57iid91BToWWnze26ZKGlD1tfCbiRO6NiDCyDWLsCXvnLdOuUcADRkNkRuFZ96mU3Tz8pUdF4frTKfL5KZAODordpkvuHicL3ayQqwrBAigXKeIrEiUFsH03jHYj7QsO4m90lhJbqex3SnSDSweAQ8OZ77cRDO8kMtTA50Mk2r56taqgydakncsy/t4gZrY+9mKiSKJpWFx/gaHROwEd9O8QBOat1mYAQoXZtPjbCeft9h1lxkgrUCSON8XhK6NNdALuP5Cv3arLwMZMEv/nyT/k9ZbG9jA50aocF cnmHyEZR c918oPBKk3nkxqnI/1ezd7PcXGZjsOYMALH9NTXIF1i4Nq5MvYZWC29Q1J/J9JNNIhM4SMSA+/0jjUWhr1WXpYaHzT73tGXU7ySS5WU6AxVb49KPc3z1pCnM2mPd8GbAAQv35alvnx55eIDgL4rACaebqvzSshBHfSSWw1l2tG9Q/mG5QcovwbzcNn24hR5FuOulFoKLT7QH5Kqf9ddu04fNpSzTUHWWc/5SM74nh+SiFrdK6U6mvIJ0d5w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000102, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 07, 2024 at 01:27:53PM -0500, Joshua Hahn wrote: > On Wed, Nov 6, 2024 at 6:50 PM Shakeel Butt wrote: > > > > Please cleanup mem_cgroup_cancel_charge() and mem_cgroup_commit_charge() > > as well as there will be no users after this patch. > > > > Hi Shakeel, > > Thank you for your feedback. Unfortunately, it seems like even after this > patch removes the references from hugetlb.c, there are still some > references from other files. > > mem_cgroup_cancel_charge: > - memcontrol-v1.c~__mem_cgroup_clear_mc(void) __mem_cgroup_clear_mc() is gone. No more reference to mem_cgroup_cancel_charge after your patch. > > mem_cgroup_commit_charge: > - memcontrol.c~charge_memcg(struct folio *folio, struct mem_cgroup...) > > In fact, in my patch, I add an extra call to charge_memcg. I think for this > case, it makes sense to just extract out the functionality from > mem_cgroup_commit_charge (3 lines) and expand it out inside charge_memcg, > and get rid of mem_cgroup_commit_charge. Yup just inline mem_cgroup_commit_charge into charge_memcg and remove mem_cgroup_commit_charge.