Re: [PATCH 3/5] sound: query dynamic DEBUG_PAGEALLOC setting

[Takashi Iwai <tiwai@suse.de>]

On Thu, 04 Feb 2016 06:56:24 +0100,
Joonsoo Kim wrote:
> 
> We can disable debug_pagealloc processing even if the code is complied
> with CONFIG_DEBUG_PAGEALLOC. This patch changes the code to query
> whether it is enabled or not in runtime.
> 
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>

Acked-by: Takashi Iwai <tiwai@suse.de>


Takashi


> ---
>  sound/drivers/pcsp/pcsp.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/drivers/pcsp/pcsp.c b/sound/drivers/pcsp/pcsp.c
> index 27e25bb..72e2d00 100644
> --- a/sound/drivers/pcsp/pcsp.c
> +++ b/sound/drivers/pcsp/pcsp.c
> @@ -14,6 +14,7 @@
>  #include <linux/input.h>
>  #include <linux/delay.h>
>  #include <linux/bitops.h>
> +#include <linux/mm.h>
>  #include "pcsp_input.h"
>  #include "pcsp.h"
>  
> @@ -148,11 +149,11 @@ static int alsa_card_pcsp_init(struct device *dev)
>  		return err;
>  	}
>  
> -#ifdef CONFIG_DEBUG_PAGEALLOC
>  	/* Well, CONFIG_DEBUG_PAGEALLOC makes the sound horrible. Lets alert */
> -	printk(KERN_WARNING "PCSP: CONFIG_DEBUG_PAGEALLOC is enabled, "
> -	       "which may make the sound noisy.\n");
> -#endif
> +	if (debug_pagealloc_enabled()) {
> +		printk(KERN_WARNING "PCSP: CONFIG_DEBUG_PAGEALLOC is enabled, "
> +		       "which may make the sound noisy.\n");
> +	}
>  
>  	return 0;
>  }
> -- 
> 1.9.1
> 
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>