From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E881AC433EF for ; Tue, 26 Oct 2021 06:27:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7192C60D07 for ; Tue, 26 Oct 2021 06:27:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7192C60D07 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id EA61780007; Tue, 26 Oct 2021 02:27:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E2D3F940007; Tue, 26 Oct 2021 02:27:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCE2980007; Tue, 26 Oct 2021 02:27:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0195.hostedemail.com [216.40.44.195]) by kanga.kvack.org (Postfix) with ESMTP id B4C96940007 for ; Tue, 26 Oct 2021 02:27:11 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 7108A8249980 for ; Tue, 26 Oct 2021 06:27:11 +0000 (UTC) X-FDA: 78737606262.20.A288547 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf23.hostedemail.com (Postfix) with ESMTP id 648169000093 for ; Tue, 26 Oct 2021 06:27:03 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 915751F770; Tue, 26 Oct 2021 06:27:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1635229629; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zum/nlaTphM4YirzX7PPgUjDcanzAhyEkY6cBJS/lpY=; b=XNVdB7MkxRNe8Uy1sGEJc2/0Gji29DXnZ9BVERKUNAHU52j2a07ba8dBlRi65PBMRLpacR BT0voFi4wV4F459DgwF9KvLRBW+3xITNm9clx8DQk4dIEo/nY7KEjGnJIOLRUAfafGAPVe 7KfE+o20LbpFeNoxvYM1T3foCG32pZQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1635229629; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zum/nlaTphM4YirzX7PPgUjDcanzAhyEkY6cBJS/lpY=; b=2/QZnMKfMGNYqgdfGcwSxlzOiDxUj1ZdFqmm5p2DYUhowTYN4vee9VnAGdj0yLLqV0d7WH Anoy3Ywdk/p6hXDA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 79106A3B81; Tue, 26 Oct 2021 06:27:09 +0000 (UTC) Date: Tue, 26 Oct 2021 08:27:09 +0200 Message-ID: From: Takashi Iwai To: Julia Lawall Cc: Jaroslav Kysela , kbuild-all@lists.01.org, Linux Memory Management List Subject: Re: [linux-next:pending-fixes 241/297] sound/core/oss/mixer_oss.c:300:1-11: second lock on line 316 (fwd) In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Stat-Signature: 197tdza3jpku7uc76mqzbih1tph89ep6 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 648169000093 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=XNVdB7Mk; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="2/QZnMKf"; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf23.hostedemail.com: domain of tiwai@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=tiwai@suse.de X-HE-Tag: 1635229623-768181 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 24 Oct 2021 18:54:52 +0200, Julia Lawall wrote: > > Line 316 needs to be an unlock. Right, the fix is already queued. thanks, Takashi > > julia > > ---------- Forwarded message ---------- > Date: Sun, 24 Oct 2021 22:51:40 +0800 > From: kernel test robot > To: kbuild@lists.01.org > Cc: lkp@intel.com, Julia Lawall > Subject: [linux-next:pending-fixes 241/297] sound/core/oss/mixer_oss.c:300:1-11: > second lock on line 316 > > CC: kbuild-all@lists.01.org > CC: Linux Memory Management List > TO: Takashi Iwai > CC: Jaroslav Kysela > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git pending-fixes > head: 9344874edebc5f4360a045cdef5e4ab3cf42e5bd > commit: 411cef6adfb38a5bb6bd9af3941b28198e7fb680 [241/297] ALSA: mixer: oss: Fix racy access to slots > :::::: branch date: 3 days ago > :::::: commit date: 3 days ago > config: arm-allyesconfig (attached as .config) > compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > Reported-by: Julia Lawall > > > cocci warnings: (new ones prefixed by >>) > >> sound/core/oss/mixer_oss.c:300:1-11: second lock on line 316 > > vim +300 sound/core/oss/mixer_oss.c > > ^1da177e4c3f41 Linus Torvalds 2005-04-16 290 > f956b4a3ae790e Takashi Iwai 2005-11-17 291 static int snd_mixer_oss_set_volume(struct snd_mixer_oss_file *fmixer, > ^1da177e4c3f41 Linus Torvalds 2005-04-16 292 int slot, int volume) > ^1da177e4c3f41 Linus Torvalds 2005-04-16 293 { > f956b4a3ae790e Takashi Iwai 2005-11-17 294 struct snd_mixer_oss *mixer = fmixer->mixer; > f956b4a3ae790e Takashi Iwai 2005-11-17 295 struct snd_mixer_oss_slot *pslot; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 296 int result = 0, left = volume & 0xff, right = (volume >> 8) & 0xff; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 297 > ^1da177e4c3f41 Linus Torvalds 2005-04-16 298 if (mixer == NULL || slot > 30) > ^1da177e4c3f41 Linus Torvalds 2005-04-16 299 return -EIO; > 411cef6adfb38a Takashi Iwai 2021-10-20 @300 mutex_lock(&mixer->reg_mutex); > ^1da177e4c3f41 Linus Torvalds 2005-04-16 301 pslot = &mixer->slots[slot]; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 302 if (left > 100) > ^1da177e4c3f41 Linus Torvalds 2005-04-16 303 left = 100; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 304 if (right > 100) > ^1da177e4c3f41 Linus Torvalds 2005-04-16 305 right = 100; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 306 if (!pslot->stereo) > ^1da177e4c3f41 Linus Torvalds 2005-04-16 307 right = left; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 308 if (pslot->put_volume) > ^1da177e4c3f41 Linus Torvalds 2005-04-16 309 result = pslot->put_volume(fmixer, pslot, left, right); > ^1da177e4c3f41 Linus Torvalds 2005-04-16 310 if (result < 0) > 411cef6adfb38a Takashi Iwai 2021-10-20 311 goto unlock; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 312 pslot->volume[0] = left; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 313 pslot->volume[1] = right; > 411cef6adfb38a Takashi Iwai 2021-10-20 314 result = (left & 0xff) | ((right & 0xff) << 8); > 411cef6adfb38a Takashi Iwai 2021-10-20 315 unlock: > 411cef6adfb38a Takashi Iwai 2021-10-20 @316 mutex_lock(&mixer->reg_mutex); > 411cef6adfb38a Takashi Iwai 2021-10-20 317 return result; > ^1da177e4c3f41 Linus Torvalds 2005-04-16 318 } > ^1da177e4c3f41 Linus Torvalds 2005-04-16 319 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org > [2 ] >