From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 04 Jul 2008 15:26:55 +0200 Message-ID: From: Takashi Iwai Subject: Re: [bug?] tg3: Failed to load firmware "tigon/tg3_tso.bin" In-Reply-To: <1215177471.10393.753.camel@pmac.infradead.org> References: <20080703020236.adaa51fa.akpm@linux-foundation.org> <20080703205548.D6E5.KOSAKI.MOTOHIRO@jp.fujitsu.com> <486CC440.9030909@garzik.org> <1215177471.10393.753.camel@pmac.infradead.org> MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: David Woodhouse Cc: Hugh Dickins , Jeff Garzik , KOSAKI Motohiro , mchan@broadcom.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , netdev@vger.kernel.org List-ID: At Fri, 04 Jul 2008 14:17:51 +0100, David Woodhouse wrote: > > On Fri, 2008-07-04 at 13:06 +0200, Takashi Iwai wrote: > > Hmm, I got this error even with CONFIG_FIRMWARE_IN_KERNEL=y. > > > > Through a quick look at the code, the firmwares are not built indeed. > > I guess the fix like the following needed for building firmwares for > > modules. Now trying to build the kernel again to check this... > > For modules, you just need run > 'make INSTALL_FW_PATH=/lib/firmare firmware_install'. > > I should... > > 1. Change the default to /lib/firmware so that you don't have to set > INSTALL_FW_PATH. > 2. Add that to the 'make help' text. > 3. Look at making 'make modules_install' installl the firmware required > by the modules it's installing, so you don't even need to do > _anything_ new. Ah I see. I thought you implemented the built-in firmware even for modules, but apparently it's not. Is mkinitrd clever enough to put all needed firmware files to initrd automatically? Otherwise this can still break the existing setup... thanks, Takashi -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org