From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01504C7EE39 for ; Mon, 30 Jun 2025 09:50:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 986446B00A4; Mon, 30 Jun 2025 05:50:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 95E6D6B00A5; Mon, 30 Jun 2025 05:50:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89B616B00A6; Mon, 30 Jun 2025 05:50:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7762B6B00A4 for ; Mon, 30 Jun 2025 05:50:19 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 24869105BB0 for ; Mon, 30 Jun 2025 09:50:19 +0000 (UTC) X-FDA: 83611596558.23.6066BC8 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by imf24.hostedemail.com (Postfix) with ESMTP id 911BF180003 for ; Mon, 30 Jun 2025 09:50:16 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=LXhXt573; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf24.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 198.175.65.15) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751277017; a=rsa-sha256; cv=none; b=7NBZkAOzh6nDIvWHwdxGU8yNys1kc5mu8QX7hhKQRTuXXUDUFQpv7u9BZDm+GXCkZZjhVS E3uzZagDCqcE3PcoK/4yIN0PhBD0DtWkwnpVoF3/zKdULYYpxwRUBEsh7iK+43a/LDssCN ZtIsQC9hXbGVI90EdzPWzUIAN5z2dcQ= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=LXhXt573; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf24.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 198.175.65.15) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751277017; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jV/7S8GIyheIzqRGzn9j+tu5k90Bnv8Pf7D/4bJTMT8=; b=s8LdzR5N68XG6GKZJXbUu55g8vX5iCSXL0GMPI1S1FutFMWDhnuRhAi2p+mUu782n/AB2N TolJqjtIQyorzGqJmxRo+eM8tMF6kgNVsHTxDIHHuqb5hcvplT3knD5ilGWs5tJv/NcVpw fDW2J1nvoaoTJF/JBY4aQdGQVXcEyck= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1751277016; x=1782813016; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=fn460stx93A77T5TqdGbNur4jkXpBAZ87mWiNl6p0wI=; b=LXhXt573ZtM7ZUGScnT+rPT47bBBaOZjxob5lAgZYoKnvvy38cEwWmiM RpVSX0D6k+aUeyrTrjh/hjqif8c1bSqaSaIK/0zbZbhZfPDwr1NbGfU9y AGRHBj8fX7e7GlX1t9JT4mRsKCUMjY9qsmm9wKEy4Neu+fODxm1dk6wlh jJTXvlnoFosgGCqse0x942amneLL0VEnXNhExlvPv3dZ8owIq4/2FE3n0 biO/hKFI8+ohzAuKYw76Pb0F6HrfeJfWeb4m5U47LWEpELU8AMYWrBIxf Ah5yyqV2JFGX2SBDBK/fFlrtWZ0K6Nyy7QYDLbvYCD8y03q3iZRcI7lBw Q==; X-CSE-ConnectionGUID: Ld5FdU8iSbGzU1ghfYRDOw== X-CSE-MsgGUID: U8PYeolgR/6VXosug1jdsg== X-IronPort-AV: E=McAfee;i="6800,10657,11479"; a="57176086" X-IronPort-AV: E=Sophos;i="6.16,277,1744095600"; d="scan'208";a="57176086" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jun 2025 02:50:15 -0700 X-CSE-ConnectionGUID: gVyBjp6QTu+7QkD3gRl1qQ== X-CSE-MsgGUID: 5n68rlX2S2GVeR4e7LSPsA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,277,1744095600"; d="scan'208";a="158922500" Received: from black.fi.intel.com ([10.237.72.28]) by fmviesa004.fm.intel.com with ESMTP; 30 Jun 2025 02:50:04 -0700 Received: by black.fi.intel.com (Postfix, from userid 1000) id 1AC2D1FE; Mon, 30 Jun 2025 12:50:03 +0300 (EEST) Date: Mon, 30 Jun 2025 12:50:02 +0300 From: "Kirill A. Shutemov" To: David Laight Cc: Xin Li , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Ard Biesheuvel , "Paul E. McKenney" , Josh Poimboeuf , Xiongwei Song , Xin Li , "Mike Rapoport (IBM)" , Brijesh Singh , Michael Roth , Tony Luck , Alexey Kardashevskiy , Alexander Shishkin , Jonathan Corbet , Sohil Mehta , Ingo Molnar , Pawan Gupta , Daniel Sneddon , Kai Huang , Sandipan Das , Breno Leitao , Rick Edgecombe , Alexei Starovoitov , Hou Tao , Juergen Gross , Vegard Nossum , Kees Cook , Eric Biggers , Jason Gunthorpe , "Masami Hiramatsu (Google)" , Andrew Morton , Luis Chamberlain , Yuntao Wang , Rasmus Villemoes , Christophe Leroy , Tejun Heo , Changbin Du , Huang Shijie , Geert Uytterhoeven , Namhyung Kim , Arnaldo Carvalho de Melo , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv7 13/16] x86/traps: Handle LASS thrown #SS Message-ID: References: <20250625125112.3943745-1-kirill.shutemov@linux.intel.com> <20250625125112.3943745-15-kirill.shutemov@linux.intel.com> <20250630093027.38cd1ebc@pumpkin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250630093027.38cd1ebc@pumpkin> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 911BF180003 X-Stat-Signature: waasxb3szgnp1d1fsfup4joq819tkbrj X-HE-Tag: 1751277016-583205 X-HE-Meta: U2FsdGVkX18s1lJg385iYVpjqdSWgsbmGDSIvlLyQlC+82rRncyFakyC177QuGBCtdak+WOtJ3BNh0DpQhNGlBCxoAT6sO0sit/Zdp2ZS7XC7MkZ7jVg79Liwxloz2iDu/oLrjRW/cJiFByVISnZFIDPj2U4T+7V0BdWAFlTdyGtOafApUdRbF2Y0C4trvtL4iI8kNfQDakA8UjjnSs+BlWYCUINp6ulBkdURes+JaA4rlFakkywqE+lvx24SmvrYlAPA9A7E6/Y4aRzN7PP6AJdFGfk92XXJZgnLQjSh+5SkUai0dAXP2rraaiS9ct3KpuNhVFt3DwxkUUGP8U3GUPTa1yhboePeKCNpjQ1idpJqhoTuldHS/9We6BSStcuFJKYuqQTptQ5yIo4K47xx6z9BAwBFytOiM7sBJBBmtEU/IjNf0aBubmoG2YQRhaaFuOmbCHvAZ9lrru2uVPnR3+b40vVSjVlecK/opGcguUVV6J90yaMth9XyE57E1GCh89UvPcbT6i48qgEc+eLtNiG4GtNRsVTE5NIUz9i37hHM15nhlWTa0Qpl96nybV2e7QWPbuOpdUlaInYWm7Tc4bJHWDH4+IqrKhmDpaF92LocX9F9IJ/eLAENTYN8Gefzr/G6ObYhnBOaUgQALWp5twsxahlBh9yZkj5bDAajyHJI6xeaBzrehqLClXbyWdPgHyq7wnGVUvHP4Lhq56jFGVhMlhbKof6JO9Wxo0vDMN/jNuVNTjQHOI4pBG0YXqbEV7BM1JlrrEUPozbdNd7ZloLcuKqS2N9Ahzibt6dx3+LmgZawed5CV3weyR7ROrbdVq7zcPMYUjIYvQSESNHQXAh2OG+oinUamxJe9PdeMcFzpOra0uvr6hDMONwO8uoYW61nv3iGCQgvqplnD0LWBNFAIsQgzrxdIkEixM85H2fAf2KaFB2KBy2Q3NOP8M4WJYMoDCLPJXm9IgHuQe OvnuRqDo HVUAtkemK2P311ZNcYFs1Qpb2BwoV0p5hpSJQsxW7+SQM0qbI3tekmfAdL1S8NvBxkM0duspNo+Zr1cl1jhfV8Wtk9eVR6pojJIxL9uqsjHULjRps5JYWgjR6/E2cekgga1TJdkNBV6QOlCSKlidxCznFrE8kE3icNDt6NcVjYgVwTR7PXCj7e+HqdPmRFlbihP7UOUAucxf7JR5Pdp2BfsfpCpd7ZivUiYTqmhhq3sm0izWKhA7IpdP59me2kOHw0aHfgjqeFgS/sTAeZhXfTI27Ef6mOkE3Irj8/uUPx2qnPNvyk4jnDrqdwRDUGULBcLOp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 30, 2025 at 09:30:27AM +0100, David Laight wrote: > On Fri, 27 Jun 2025 13:31:44 +0300 > "Kirill A. Shutemov" wrote: > > > On Thu, Jun 26, 2025 at 10:57:47AM -0700, Xin Li wrote: > > > On 6/25/2025 5:51 AM, Kirill A. Shutemov wrote: > > > > LASS throws a #GP for any violations except for stack register accesses, > > > > in which case it throws a #SS instead. Handle this similarly to how other > > > > LASS violations are handled. > > > > > > > > In case of FRED, before handling #SS as LASS violation, kernel has to > > > > check if there's a fixup for the exception. It can address #SS due to > > > > invalid user context on ERETU[1]. See 5105e7687ad3 ("x86/fred: Fixup > > > > > > Forgot to put the link to [1]? Maybe just remove "[1]"? > > > > I will add the link. It is important context. > > Will the link still be valid in 5 years time when someone > is looking back at the changes? Re-reading the commit message I wrote, it is obvious that I reconsidered putting the link and referenced commit instead. I will drop [1]; -- Kiryl Shutsemau / Kirill A. Shutemov