From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B211C3601E for ; Thu, 10 Apr 2025 13:40:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09A276B0332; Thu, 10 Apr 2025 09:40:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 01FFC6B0333; Thu, 10 Apr 2025 09:40:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDB896B0334; Thu, 10 Apr 2025 09:40:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C0B566B0332 for ; Thu, 10 Apr 2025 09:40:43 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 37AF91CC034 for ; Thu, 10 Apr 2025 13:40:45 +0000 (UTC) X-FDA: 83318244450.16.32D333B Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf27.hostedemail.com (Postfix) with ESMTP id E4F4D40015 for ; Thu, 10 Apr 2025 13:40:42 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qcxx7Lkr; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=pHJaBBi5; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qcxx7Lkr; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=pHJaBBi5; spf=pass (imf27.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744292443; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lEW/4t0fah9hh4ytyQQ4jogiOr/8+G0+ynUBVfQmIL0=; b=tSNZiv03Ds9o/qMtz4nXFyPXrDooncAf3BMN1onjrxlCKEApFYD5AifCcWsvUCjlJVReNP +o+jvHEobidAoF4voftFHrU174BYO1ysFKf83nqkdAvUwPryAof4vphEZ3uTgNKDvPBAwy 5naqNNCgHmf9uV/FJLHAw+8Av+CqY58= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qcxx7Lkr; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=pHJaBBi5; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qcxx7Lkr; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=pHJaBBi5; spf=pass (imf27.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744292443; a=rsa-sha256; cv=none; b=caxiU9YDxHm9vY9fvN9IekOq0520RcnWlfDkrNH/bSPjqq7MyagFCqKoVq0xhxNS29JYws q2UnOSPjHCdlZd89nL21Bi4AgAOpzKT3FHhK+oa2r5nijpOtH3JWTVGGMuD53r0rNfTdjk iY0LM1gKK00zDiPnebZEqzsDTvZPOD4= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 76E6B1F38C; Thu, 10 Apr 2025 13:40:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1744292441; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lEW/4t0fah9hh4ytyQQ4jogiOr/8+G0+ynUBVfQmIL0=; b=qcxx7LkrBge3ML8u/3xGayWdW+uSIJpUrCghWo+4xJ/SYGD5HSRa1CYU9AtlcXv0iE40lD QFugZjjpa3mhIKWobHz7xpbARuSaEiG8D5xogNgMWX/+rpDyLenwX6YoLidp4tYBLBDFkq w+lKj0PcFrFHHsCpMs1+sXyKx9q4/PI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1744292441; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lEW/4t0fah9hh4ytyQQ4jogiOr/8+G0+ynUBVfQmIL0=; b=pHJaBBi5BKo95YTHZLOK8XrhXGX6mRe1JPV+Aj7hI3VboiFPJuJiQZYUiiT8uso8L8q0Ln QvQ0spqVY8MiJ6DA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1744292441; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lEW/4t0fah9hh4ytyQQ4jogiOr/8+G0+ynUBVfQmIL0=; b=qcxx7LkrBge3ML8u/3xGayWdW+uSIJpUrCghWo+4xJ/SYGD5HSRa1CYU9AtlcXv0iE40lD QFugZjjpa3mhIKWobHz7xpbARuSaEiG8D5xogNgMWX/+rpDyLenwX6YoLidp4tYBLBDFkq w+lKj0PcFrFHHsCpMs1+sXyKx9q4/PI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1744292441; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lEW/4t0fah9hh4ytyQQ4jogiOr/8+G0+ynUBVfQmIL0=; b=pHJaBBi5BKo95YTHZLOK8XrhXGX6mRe1JPV+Aj7hI3VboiFPJuJiQZYUiiT8uso8L8q0Ln QvQ0spqVY8MiJ6DA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 69B5A132D8; Thu, 10 Apr 2025 13:40:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 18ndGVnK92d0bAAAD6G6ig (envelope-from ); Thu, 10 Apr 2025 13:40:41 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 17607A0910; Thu, 10 Apr 2025 15:40:41 +0200 (CEST) Date: Thu, 10 Apr 2025 15:40:41 +0200 From: Jan Kara To: Luis Chamberlain Cc: brauner@kernel.org, jack@suse.cz, tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, riel@surriel.com, dave@stgolabs.net, willy@infradead.org, hannes@cmpxchg.org, oliver.sang@intel.com, david@redhat.com, axboe@kernel.dk, hare@suse.de, david@fromorbit.com, djwong@kernel.org, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com Subject: Re: [PATCH v2 7/8] mm/migrate: enable noref migration for jbd2 Message-ID: References: <20250410014945.2140781-1-mcgrof@kernel.org> <20250410014945.2140781-8-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250410014945.2140781-8-mcgrof@kernel.org> X-Rspamd-Action: no action X-Rspamd-Queue-Id: E4F4D40015 X-Rspamd-Server: rspam05 X-Rspam-User: X-Stat-Signature: to8s5rqwiikaj6ty4onk4gqux5xygg5t X-HE-Tag: 1744292442-815566 X-HE-Meta: U2FsdGVkX19hCz1wZatOFmKlnAxCfsUb/FPv3RlyFhhND/Gu6MAVn62vvhu62vIPPbHR9E18KSqiXSHs5xx6D/EKUSZ+ORTVtJgvzvjZvuPscYAdJbQnPVSNZ8xr6pEgosDp3BYAQTaRuAbrt/mJIm+16dh77v47mP1C3ieFx83RPv2yYkLo96yl0hjzN5LA44PEYymjTIf1Ki/hUb/vWoHg8AUDpcZgxa7sQaQQDZzGKesQ2U4suZEGktPqC3qOtgabivfnKSl7vN+TyYlsg51qeRBO1BEC3jBvn2JSayRn7MlbsbivKHsjq1EEJn8yC9tSptlfkQubdCb/SFhxFQFLGt1v1D7ffscAXmBfx5nDCLCgN2bMyvZJ99iqICFt0hp12fYpJoA50xRqpnu0c9WrapLE107kblfpgx8qVLGrmMUrsqKXAfiAiO8AEjYKhVJifJvbZQUggY1N7O8E/2FN5h98nrDfMwa0/r75FnUGQmwkZDpUwNhEPG90HrpXFDxkrxHGk14i+hcdyCv5RuPr67qlglyvSRLQMJWSX27zoa9dSKOMfR7Xh9Dy1NJarz9uMbQRMljoqY1RJkupaoxflDmIYJ8/g0RB69uXDwgzRGoAcsFeTIaQLJunjZufKhEceZjkBi3In1jOrg8fg15O2DFHL/4pFGZF2x4hXT3y65/cSlqVA7l/IGJR+3C9DmIejTwwfkK1O4LUFaziONIudED171Ixo4I5PCME/kQHdBCOsplbhNvvWbH2nGLNR0Qe8clhFgICgskhqYVMv4doFYOe87LQEENL+pcSYW6SjsLFq4GKFGxJgbVyORmJMcEDVyJJy2ZcgNYh13lUL7on5lQ2fGHPFUy1dXcClQYBGqUQ2LXI6/MTwh/w1xjXYl1sN+plooOjUhVo3eHU9hLzH0yLyoBFFtvFijW8npwUU25Ybq4qdWz07tejAvz56ps2zE4YuS+zghj8+85 scHIcNiU 1Xfl5iRT/VSDOmo9y9UGUnb4rtol6SDpEDfZXKpGkrhanIKYbjhCG2roeppvVhueC7vLC5rzGp0YJF9PTPCUHXN15OW+D8MVyqtov1fMAUvVUysWQPMl63iYS39WPuDMtt6FoWZuebtfpttHuiDR3UTQxxJbCqyOgGsOCLlUCIYghxOoa5xCGZzm+cZgji+IilJ19YWuMEXq61aqDbGSW3v1rwmmNv8IUk92zzYbKw1AM4TTIDfmjzAqQ8EgCdWidj53qrF/tPz9bsEsMPrqm63r9sFLFp0b+GPCo44B+fH2De7YXGGpQxW84zFsgAmwpSvfZXBKF+PfD0UZvK4dHxqxL2NJQ/4aRt0Nwdy63YFsGDHh2s97cvS6f/JCaIMFOtVDgXF5+2ql4wVEsM2QWu3eq+TyK9SjJnbzK8rFLgMeZezuSa9EboOahG34vBPku4egJZu/sxRQSeEFNIwxDf+dECYo784Hv7rdGL5mfmOE7j0k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 09-04-25 18:49:44, Luis Chamberlain wrote: > From: Davidlohr Bueso > > Add semantics to enable future optimizations for buffer head noref jbd2 > migration. This adds a new BH_Migrate flag which ensures we can bail > on the lookup path. This should enable jbd2 to get semantics of when > a buffer head is under folio migration, and should yield to it and to > eventually remove the buffer_meta() check skipping current jbd2 folio > migration. > > Suggested-by: Jan Kara > Co-developed-by: Luis Chamberlain > Signed-off-by: Davidlohr Bueso > Signed-off-by: Luis Chamberlain .. > diff --git a/mm/migrate.c b/mm/migrate.c > index 32fa72ba10b4..8fed2655f2e8 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -851,6 +851,8 @@ static int __buffer_migrate_folio(struct address_space *mapping, > bool busy; > bool invalidated = false; > > + VM_WARN_ON_ONCE(test_and_set_bit_lock(BH_Migrate, > + &head->b_state)); Careful here. This breaks the logic with !CONFIG_DEBUG_VM. Honza -- Jan Kara SUSE Labs, CR