From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2742E7718B for ; Mon, 23 Dec 2024 11:52:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D93066B00AF; Mon, 23 Dec 2024 06:52:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D414C6B00B0; Mon, 23 Dec 2024 06:52:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C309F6B00B2; Mon, 23 Dec 2024 06:52:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A67606B00AF for ; Mon, 23 Dec 2024 06:52:26 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3AA2B1A0D68 for ; Mon, 23 Dec 2024 11:52:26 +0000 (UTC) X-FDA: 82926060714.14.BB2A173 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf16.hostedemail.com (Postfix) with ESMTP id A6EB818000F for ; Mon, 23 Dec 2024 11:51:45 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lPUYPHzk; spf=pass (imf16.hostedemail.com: domain of karansanghvi98@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=karansanghvi98@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734954718; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dBh3YvvN16OcYmfxJCy0fHcAiIaYK4pqdDKtqAa5I6g=; b=kPXHs/Q3wQPBU/nQD4ErxwYZCEap/nwB7cwIE3IVgNgUp80B8RIdMhGlU5Vlk9nDBDVIAK nYGBSC/MFb18j/JR7dF4C6sgwZHW0xHBD43yAdoky3L+OZd0tqpigG+mjs5V/99CZLa11C JZgdlpTyM3d2JXWStjP/fmMYrGHinVk= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lPUYPHzk; spf=pass (imf16.hostedemail.com: domain of karansanghvi98@gmail.com designates 209.85.210.177 as permitted sender) smtp.mailfrom=karansanghvi98@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734954718; a=rsa-sha256; cv=none; b=UBeYKfPx8f6tRlGuPKu/Fb7MHr9sdrzoqcxbadAIwvBkyRLFk2b1c5sT95a+AkeYXYazH/ /X+iOjsOKYmeRDZT0UaRmsHEdII1XMMtMhw8lcGRX13vdGDABcEb8BHCnhqXfdkl5Kau1z 5sP/2N/0T+AbUv0tOC7jPUnwq02n9sM= Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-725dac69699so3568125b3a.0 for ; Mon, 23 Dec 2024 03:52:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734954743; x=1735559543; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=dBh3YvvN16OcYmfxJCy0fHcAiIaYK4pqdDKtqAa5I6g=; b=lPUYPHzk4eliDuY9Ms/htx2XFbr2/U2zyrYv4lhC7VjNhKz/rqL45j8dkwXydQP2Wb K7ADXOUZCe21Ovzg1VUDRZZC7Njl65ZZEIT0KXqEcL8SJrgB5iQdKbes1KCwxWJGoS0L tvL4dlsd5svyBgXxCA6MDo8JMKrDxseBFYNHe4HmELoptuOnDgae5SiK4JLNbEkFQtPn 3TSzAGnBsvqTLbVrXS2ZmQbaFFao1ihot6SbZWBTxJNFcx4x+mDyF1jq1/0hmPdRClqO EjQcT3A1svWaqXDZEUIS6ISRx4EHGgTk9zbmZ/cf6wsn8jmIwK77qrF7roH12R6MzVv0 Uxlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734954743; x=1735559543; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dBh3YvvN16OcYmfxJCy0fHcAiIaYK4pqdDKtqAa5I6g=; b=By9CrOqLstn6Xf92oPPBUHcVLr5nQvBYvaeXM1+c4H+mhU/U5ERs99PFvoMbSq0qHz I/VA6FFrLMNfgkh+fZOdoFVEzVe3ReWpGa/q8w1aqunkeoblex6cR0XOz+z+LvgOYIS6 iR7+U/031Vu92FXK1ae5BqEyfCtAuXE1Rk8kJdLYH3wGtiRZMyMCx9YJ/uAKA0elG3Z+ X0qNhfFWLUKvX/4ZASEPRPPzhGzhBLoXPiAb5/UpRXQpRvozOrFOcnoO8pUEtlxo1lxb NGSRNXOkWXCTqu5RXOnHm4wwB3znmeEkUK2GguX92I0siUrxC6mNQ8RYCq9tbyEeW5e1 cORQ== X-Gm-Message-State: AOJu0Yzf1l45TQkors8knSzVdHJF/TVqSfBDsFUTT1Viw2w3JDr3Of2f K34GlfGlnIaPtugpBGRE3zxa1MPmI5uAXWyO77U4JHZEbku35P2P X-Gm-Gg: ASbGncvtmMGxMoRkfNqaprq9VN3eyUd2LUNUcBkz57AvEHbfmBuDC0uQVHB9pmCP+OT L2gjr4WVArjeQg3HOLJrLhQH7MhmAxSWyHynWkWpamg4KnABrgIS9MY6nDxwZUrWjbTckackyLu OML/o0N4xPZmwua1XUlnHX0g5hczw6UsD4FP4StXszBfHWJiBHtuWbjnASCJVCC2XM5SrqIjw4+ Akl7zQtSnH6Mubd/ELh2Y7Is2vCooQCEeUUpchwmhytvqxYWtGt+Yc= X-Google-Smtp-Source: AGHT+IHszT/hoGzwk3BVjUGaEOwUnV6XshKukdC6iWtN7bzYAldUOXJcxrahWo8GXOvtg4Lp18dosw== X-Received: by 2002:a05:6a20:394b:b0:1e1:e2d8:fd3a with SMTP id adf61e73a8af0-1e5e07ffb23mr24518365637.35.1734954742806; Mon, 23 Dec 2024 03:52:22 -0800 (PST) Received: from Emma ([2401:4900:1c97:3652:5054:ff:fe53:2787]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad90c244sm7660680b3a.195.2024.12.23.03.52.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Dec 2024 03:52:22 -0800 (PST) Date: Mon, 23 Dec 2024 11:52:15 +0000 From: Karan Sanghavi To: Hugh Dickins , Andrew Morton , Gabriel Krisman Bertazi , =?utf-8?B?QW5kcsOp?= Almeida , Christian Brauner , Markus Elfring Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Shuah Khan Subject: Re: [PATCH v2] mm: shmem: Fix variable type to int to evaluate negative conditions Message-ID: References: <20241127-unsignedcompare1601569-v2-1-e85098fb02b2@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241127-unsignedcompare1601569-v2-1-e85098fb02b2@gmail.com> X-Rspamd-Server: rspam05 X-Stat-Signature: abgewci3isif8kotebc5dxbp163k1y8m X-Rspamd-Queue-Id: A6EB818000F X-Rspam-User: X-HE-Tag: 1734954705-146925 X-HE-Meta: U2FsdGVkX1+JHN27gIf0JSP4A426ZQkxPFRtzhArp4pbTAJt0WOCwDUIF93zs8e/O6PlXEbYr+Uv6ZMnl2YQnrSMz+s1veDeCgSQabci4kd0khqBDeKbwr7DakorlBUsSfMm5yhRxAluazEuefBiZqNHup3ox8jv1mqd/k+745QJs4rAxQZ8f+oSKRCDTZ5bWIeHsQbw+yeh+2RqvvHAS+R0byA7GHUXKQHScjwNU3yGWJ2c1AEE1Cc7+FD0o71TZGWlBnuD0AcIUeBXkztpSH4n3gTH2GVd7BNa1CrSr3RkU7KeUiIHKh1hEwD61wGI6vbuJCZOiZpNqXLJRZeJGUOfI6TavtMikVhxk0TV0K+Bd1/7NfPJne4prs8sieBJPSpNsynnHpFRu1ou1A9m5LVT8FhymBJYMUiCmqm/QcVeNb/IgkYVCRecM9WUmIu91QAGw0s5BgcHAj4IHOzSv2YyXJ9w9sYtJjLmRlsd5OaUQ9Oaybyw+x9pv1ICgYBjobESAjoNAX7QJ9HauLyEAwhDwXRQZ4MySo410QRTcuVwFchPh/49H2kGwPlYhPyyXy/RdbHqHyfU0n1RjUDrHqtrLxzTuToLkl4SjgDp4PhQdpxojDHTWRjBIP7Y/iGPS9nbl7jUMLmswR/mf82pN9Qv0orOdi4XnTtLtTUwMKuJF7NX9KnKXC70XV2wMclQzfmUJaCjK+Yp8cOGdtP7m3AnnPYl09xtika3Z8hC1O+5L7vcl/yovSUOXsxCeUU4HVksnGt6RSP0mkLvJDhfo+rxv1F2sTYDHG9xN1/8B3w6SQgrqsYyvzdCMCfFe9iv47PDpSUyu+vYtfzTJF7xinnU+TYHUGDQFwSygLXcQGEEBDbK3EPMWMaUiH9Bqft4/O3sfpiAxmI27hWo11K1esMtSpZvWuzNAMX99DjD2e2K3gH5G50XtTfd2HKFWsL5YStqn+2UWejc1ztLqbN sI8t4q6b fq1fC9uNq2tqz6eI1g1QRgaWy93dpRMY4PJw0XoVBRmPq0dn2wGjQmLtiYdTsunxNhvKpFzvL51FBPq3NAKDKVtgDayMsa8+kE6iHJF3UdyM8+kacId9Dk6lDcbTm6LfbLItLf7NC2+ts1NVvsmMzuwSJa1H5Dwn4XD4rRlbUKrXkYfFrrMKyEW6Ft77I+mAMH1z3+1UMQr7OWRZYpGwuKWw3UREzx2zk2MTVf6p39d2pqI1CwmmVZSsujfoQd0nMKcGH9ZgY+ICfmVxlZdLbmI39RRLyACLO0uEztUf9FF5QlAf5GGOV4ZJ3Igf5bo3k4w2gd2anSsZapZPwjA/AEnCsMqwfLkyhoUxT9WjwBetvzYucKYiKr2d2bv+ZGqZ15FtkqqIc7jmqSHNMam5MT3O4CVVldkTIFoC8DSoXw8QgTLe2j0YXPNxgu8E3t0cSH2/t4T+gHDdK+OJss6zmt758xX8NYAZcD9wdM06JciQbIsVPbyMcx2jfOpBFvdd0w9f1v4Qr0PTMSye1wcgyKuMO6QAJF0k5QBsPZRIHmE3b9Wq8P4Q1sbGz627zCxuctmTy1DcMBWX4nkXnY7qckcJ7uw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.448213, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 27, 2024 at 06:07:25PM +0000, Karan Sanghavi wrote: > Use signed data type for version handling > in shmem_parse_opt_casefold() > > Fixes: 58e55efd6c72 ("tmpfs: Add casefold lookup support") > Reviewed-by: André Almeida > Reviewed-by: Gabriel Krisman Bertazi > Signed-off-by: Karan Sanghavi > --- > Coverity Message: > CID 1601569: (#1 of 1): Unsigned compared against 0 (NO_EFFECT) > unsigned_compare: This less-than-zero comparison of an unsigned > value is never true. version < 0U > > Coverity Link: > https://scan7.scan.coverity.com/#/project-view/10043/11354?selectedIssue=1601569 > --- > Changes in v2: > - Updated the log summary. > - Link to v1: https://lore.kernel.org/r/20241111-unsignedcompare1601569-v1-1-c4a9c3c75a52@gmail.com > --- > mm/shmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/shmem.c b/mm/shmem.c > index 7987deb2be9b..17a1d4fa8870 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -4367,7 +4367,7 @@ static int shmem_parse_opt_casefold(struct fs_context *fc, struct fs_parameter * > bool latest_version) > { > struct shmem_options *ctx = fc->fs_private; > - unsigned int version = UTF8_LATEST; > + int version = UTF8_LATEST; > struct unicode_map *encoding; > char *version_str = param->string + 5; > > > --- > base-commit: 6d59cab07b8d74d0f0422b750038123334f6ecc2 > change-id: 20241111-unsignedcompare1601569-05b5932145ef > > Best regards, > -- > Karan Sanghavi > Hello Markus, I hope you are doing great, Can you please let me know by can I expect this patch to be applied since I have changed the log summary as you have mentioned in the last mail. Please do let me know if there anything else to be done for it to get accepted Thank you, Karan.