From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A9CAC369CB for ; Wed, 23 Apr 2025 23:14:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED3666B0005; Wed, 23 Apr 2025 19:14:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E83616B0007; Wed, 23 Apr 2025 19:14:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D701E6B0008; Wed, 23 Apr 2025 19:14:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B87166B0005 for ; Wed, 23 Apr 2025 19:14:44 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EBEFD801E7 for ; Wed, 23 Apr 2025 23:14:44 +0000 (UTC) X-FDA: 83366865288.30.236B31F Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) by imf22.hostedemail.com (Postfix) with ESMTP id 4040AC0002 for ; Wed, 23 Apr 2025 23:14:42 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=dC83HcUN; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf22.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.186 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745450083; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LDDbX7bPNdKQ1x+LjPkSgx3kPvorivXURC3759U0Hwc=; b=u7ZlA63Hp5iEjXccE391uXb9BH9nZKz2Hr2/+S0LBHJaEcjD9+XZN6WgzC5+3JwDi+wf9C HfLXsauFNVBvs3s4eXmjE5TZokQ8w2v8irjEoByPKAiqMj5zVbbA5ArTpXKaxqi1eyEyUB 8oW0uI4iooeaYDY3HcGvkV4LFCNvuJc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745450083; a=rsa-sha256; cv=none; b=TgXScboPUKkmPFi2xc98K960CyXHOGyJ+R83lASbJoTclz/lUuVYc5Ck6XJRbu03anupG6 BWuda2XIMThTfkWV+pJckShSM+vNtso/vLxKG6IHki0wpKwyEDOv2cpK+Rz2xKE+lG6Rch 6Yokuki6LbXAr/PgScuDbXsAoJ8nzgQ= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=dC83HcUN; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf22.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.186 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev Date: Wed, 23 Apr 2025 16:14:33 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1745450079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LDDbX7bPNdKQ1x+LjPkSgx3kPvorivXURC3759U0Hwc=; b=dC83HcUNXbOPHMnABNyrAUBKas+oUXCQMM8lCYq/T45+uP9FP7na4/9OFo799pMnTXs3bP WGFUHBWlVfLY2ARD0TTwqPgoL7P+W2vBGXFV4GJ+fKzmSyEYjYfsU9RvWv4OczuO824l3u vvavC7aHQOLC18z/S3YNlQAJGiIf8zo= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Andrew Morton Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Vlastimil Babka , Jakub Kicinski , Eric Dumazet , Soheil Hassas Yeganeh , linux-mm@kvack.org, cgroups@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: Re: [PATCH] memcg: multi-memcg percpu charge cache Message-ID: References: <20250416180229.2902751-1-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250416180229.2902751-1-shakeel.butt@linux.dev> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 4040AC0002 X-Rspam-User: X-Stat-Signature: agbpt3oofoap1uh9usxo58d8w3ny3myb X-HE-Tag: 1745450082-31423 X-HE-Meta: U2FsdGVkX1/oJ8oPM+4Bi4RWXCTJx79Byfgrb319KUctUnI/pSc7u914OHaTdeUi+BXhj4U3fV0lEyqK0CAxwFkHhBgGSgrxKZB+6ueWNMODZTrIJ4rzv7tEsYRWylPwTi/zPCENTT4GCxqXCnLaRK+1nY4Q4nQUFhv1/k7fH0oi+qkw0mhZGrDy7LxKpk/8xle470Uklp6VXCiJJqAB1L9uI4jp/GqFaFgofVvRhqKerCDhCjRUCzQDQENgsTYglXiCZRj615HjQKZrVUHwb6+En2v5f1YUG4m6GxImLXctUgWWgrlH7H2g0CzGTlxyuQ0xDZmy//DisKXhjHlk2AWcNZ6H9LSW0Rf1rcm0em+xSKgc366BlypBWEucR9kFKeVMVd1EtG4d/nejDLW1Yuj9JqRLq1qyaZUcxC4N4Nr51LkcvAvP5h4VzSlfhANVFLQgv/CLFcmd/VWky0JcIRShQEJ/LulYRVnne3w8Acf2y/HzmxOrO0b+naH5NtJifn1dGUrmzhhGXGlAX+DmqJRZOaGhFzlgfxUVigwYx8bsyFZwy/zvl2+24miv/fS7chSuZHoPWeItJ5q5R7Er320UndogNfzNRd84rUo/8A9z+MHfi5WzBIUcpdeuVM/RLrqaVSlAoLTf5mSUNr73QSFGVYOnGwdHfvUkjug3JnSdxgNcap1UAyCWFxqvf4ldktUuGv4cZvr/JiXw9eWN/RgccrbBf9PflKbz0p9rBTmUEzKnHqBB5cHetuWECIHKMQ6AVlXXav8CEuVkoQ6iTOYIiZ6+Wk9/FAlo0HcgOPM2PXFybCwSCVj6EnLTag37NsMB3aPQC8EJKOLuM6k6W/0U/JTxz84i3yfoyj6oLob29lU/VoEkCA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Andrew, Can you please squash the following patch in this one? From: Shakeel Butt Date: Wed, 23 Apr 2025 15:41:18 -0700 Subject: [PATCH] memcg: multi-memcg percpu charge cache - fix Add BUILD_BUG_ON() for MEMCG_CHARGE_BATCH Signed-off-by: Shakeel Butt --- mm/memcontrol.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 23894e60c3c0..80ff002b0259 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -1909,6 +1909,13 @@ static void refill_stock(struct mem_cgroup *memcg, unsigned int nr_pages) bool evict = true; int i; + /* + * For now limit MEMCG_CHARGE_BATCH to 127 and less. In future if we + * decide to increase it more than 127 then we will need more careful + * handling of nr_pages[] in struct memcg_stock_pcp. + */ + BUILD_BUG_ON(MEMCG_CHARGE_BATCH > S8_MAX); + VM_WARN_ON_ONCE(mem_cgroup_is_root(memcg)); if (nr_pages > MEMCG_CHARGE_BATCH || -- 2.47.1