From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D001C4828F for ; Fri, 2 Feb 2024 22:39:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F32D06B009F; Fri, 2 Feb 2024 17:39:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EE21D6B00B3; Fri, 2 Feb 2024 17:39:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA9E16B00BB; Fri, 2 Feb 2024 17:39:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CCB966B009F for ; Fri, 2 Feb 2024 17:39:36 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 92B7EA2790 for ; Fri, 2 Feb 2024 22:39:36 +0000 (UTC) X-FDA: 81748331952.12.3382672 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf07.hostedemail.com (Postfix) with ESMTP id 62A684000E for ; Fri, 2 Feb 2024 22:39:34 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=o00Pc3vh; dkim=pass header.d=suse.com header.s=susede1 header.b=LvzGCXdz; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf07.hostedemail.com: domain of mkoutny@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706913574; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bCfFQwrE4UL1PKl+LeclfJETuW45xBZgfwbXOew24q8=; b=77Xf6WBUxDRQZQE3hp9aV3UwQUfLjoKpcawQBCBEqeplOUDKpi8yuc3USa4ju0jAFL/v3S OSyi3+Kv4SMRfqOB+kCIeT2rXddSH0YvLllmLnQv7s0JvssBMDWTonEslBZoZWNYjmVsXP Sca2Ycqqm8fnc8BotvAxZ8TdtkIEFcU= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=o00Pc3vh; dkim=pass header.d=suse.com header.s=susede1 header.b=LvzGCXdz; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf07.hostedemail.com: domain of mkoutny@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706913574; a=rsa-sha256; cv=none; b=OakiSBggYWwgvWE7GF0UqRVVRdDAg02G/kdRk07ufi60MtV1w6ffKxbyHjCCEt7MkKaTo7 zrA8PhC+joq5vM8jYzCwpcCmpWMmDgt5clLzmaJdd5H6zB/nHdtVZt4U9JmeZPjvZdC+EY i29fL7Qtlrd3u5cxMonajamRCdfxkYk= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E9BE31F7A1; Fri, 2 Feb 2024 22:39:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1706913572; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bCfFQwrE4UL1PKl+LeclfJETuW45xBZgfwbXOew24q8=; b=o00Pc3vhT/8ojuKDWrSL4FR8mVTZgyFICtMOAhjKvC/laJcrnSTqF/WbWFfrUQdYM60ZA5 iCs0SjDYquSjs6tn55Gkrys8NF5yNZuxmq8wqLBuj/MI0VGGfBMIqEddWXffAV4Jg9QvRR CRAAEuDaj5XW016PgvnhSmuRcrIsfhk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1706913571; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bCfFQwrE4UL1PKl+LeclfJETuW45xBZgfwbXOew24q8=; b=LvzGCXdznaw+pWLdKAHRAavGrwObeHlndQqMfus2+pnPxZPoYNDhF3c87fCd/xoisedgfh wHfQRTzglfyboLQHsqkZSje4OuPVvAEuJKGyUQbV4pAqHJ7zAUvNdOHmd2MV0DbrMpk4Xj Q8bqes4dlFs3/XNWDYSSILAbLslIXu0= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id B62CA13A58; Fri, 2 Feb 2024 22:39:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id Wz88KyNvvWUsEwAAD6G6ig (envelope-from ); Fri, 02 Feb 2024 22:39:31 +0000 Date: Fri, 2 Feb 2024 23:39:30 +0100 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: "T.J. Mercier" Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , android-mm@google.com, Minchan Kim , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: Re: [PATCH v2] mm: memcg: Don't periodically flush stats when memcg is disabled Message-ID: References: <20240126211927.1171338-1-tjmercier@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 62A684000E X-Stat-Signature: 3ny38nc95wbaiyiu7849papqqhhuq9uq X-HE-Tag: 1706913574-317688 X-HE-Meta: U2FsdGVkX18OLPwckJ5d7aGTTCodWN/zTwGgYGSt0e321wTEKH2UDxRQ8WTmSfx812g1gA+1PW5yu2KhYdlwIhl1H2flQgNs9AjZZUgo3U5dNaFeadzB+Vui1hVg3YWbg+Q0bxj5YTL77yAb/fMZE8bL4VL2Dr6d83MvcgKqwkgznef0eBN29ec/Th7Lh/0GpnLdvGE73cCQBdmXkx0Fb701Cb/bA3WqZLWC53IQKNjjM2e2AaIQuFqz1tLdOjuhJ4yUmUomwjVT5huSVtMrbr0GNdSveETMHU8aom2KohDx2dm8ibWoBLjvK/92RuKfOxm6HHlQQlNPY9Zjf2Ijfg70XISH1RlPPRwLfcfuNWglA7AoADnErC+ZKE1xJ0KWfpIrKDqtQtKy2c5bpKKskx2zbvPRcXXB/v4as935d6I+ICvETSopyZMwqWOMwCUfwXVqhWevXam8GEWBpZ0UeC+doqT0zgP99fTFIyxqoNiC90TivdfdDJdwt2Lp8mjR8Xu3K7ojeNl2GBfk4hbD65f+dozLbUvXfon/NWtFQQum08OuZNhwiOmtwA2FhlVqvxzkYf4lucHAXM8l8Q71MvkvAF1kmwCsG4YeVWdKmtuTDzcFISgZDEZH/08w6h9/+1dSOgOSIl+fQPFlVYrrCo+lfNlMkeSKWUv7TJTtV+wI9xUxUNFM9+XshNV3xzVTwLDYhpH5liDkKCdzHo10C9LfLlXqAF0aLtPapGysfHydMczyJdWhMFeoygqN9ynm4UKtL012FlsWRZyzuLVIdw3f5nCkMwUkg8US+KHx6eKWFIN/5h+HihSwCwJBm7dXEQXHhOX/8W08Jkmf+MIrpI/9tEjh6mQCnOfrk7h/u6R/SkJL7eh1Al6X57RtynRMKOhV/a+TknE08W0bibkYm6N89/AAVO5KI8b12L9N46b5vGK6pIXideg5FCX/pxgWaAGqg72Rl/RGdhxcREG tIyshB4a 1ltybNnneBLt7s1SefOx8Znms+1n9jq3A+zpQfLe88Mjk0FjZ8MuQLg55xXtfNiuSYEsfmt6AoQO3G4O3MMjgqEMuSYQmA5NcD6Ss/ihQ1PcU4ZYAYRQC6+OlfiA5CtIc5HFXHonMBjuKypZXyxnIv1sAy1vXVsqNpX2dGxXDqxRm3Pcuv/2IstBmGvbJK36L1GTUzYLSvzxBN/j1wwY7sTy8GMOloBr1HhBkFVOB/txEDH6/1XUA6/6LND3JvSlNif3kn/ZUNKcW2RjeTSj537wayBv7IYIipPCv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 01, 2024 at 01:02:04PM -0800, "T.J. Mercier" wrote: > It does blow up, but not how I was expecting. There's a null pointer > dereference inside find_css_set when trying to get a css pointer for > the memory controller, I think because the allocation in > cgroup_init_subsys is skipped: Thanks for trying! I suspected it won't be easy. At the same time I suspected there must be a hook for your purpose -- after looking at cpuset, I was reminded of cgroup_subsys.bind callback. What about triggering periodic flush in that callback? (memcg doesn't implement it yet but cgroup_init() takes it into account.) It would take any dwork activation out of mem_cgroup_css_online() and it seems cleaner. (Ideally, the flush could be disabled again when memcg root is unmounted again. (That's impossible and practically unused but that's why consider callback approach cleaner. Of course, your original guard serves the purpose too.)) Regards, Michal