From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B2F2C2BBCA for ; Tue, 25 Jun 2024 17:04:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC1BB6B0089; Tue, 25 Jun 2024 13:04:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A732B6B008A; Tue, 25 Jun 2024 13:04:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 939DA6B0093; Tue, 25 Jun 2024 13:04:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 749CE6B0089 for ; Tue, 25 Jun 2024 13:04:03 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1A45C80383 for ; Tue, 25 Jun 2024 17:04:03 +0000 (UTC) X-FDA: 82270033566.26.38AEB0A Received: from out-179.mta0.migadu.com (out-179.mta0.migadu.com [91.218.175.179]) by imf17.hostedemail.com (Postfix) with ESMTP id 2107E40053 for ; Tue, 25 Jun 2024 17:03:58 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=pfvEsxds; spf=pass (imf17.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.179 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719335024; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5eS9TJekxDVy7pj/kCvzbG6fFW3jQY5tj8X/hscqVo8=; b=r2LUCXpDZfIiCQtay76eEwkIuk6njr/iRGHoYbLFnJAg0MTzJe9w1j44itLiGe9/8li8Bm Pp1BD7WCF78AMrom4aj9vGY29wkkAeoFbZ1HeRw9WXLuq870qWFSx0YgNJvzF1nQ8YommE g4L1RCBhSBjKWJIJerdq6sjopULRj7M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719335024; a=rsa-sha256; cv=none; b=TF3fBTQT3oL4M2FUwQYjmUycymUajZqsbRkvm9g4Taz2An7z+hjETJ0Av/xdxO9cJXY09q LjkLKk6SfkfPYhSPZuWh8TGwuYZerWK4MgAecvBnD4Lv0mvcA+mS23ik73/sQIR2eb/g5F Rae/oh1aMq9ATRqAqTQVpIZObztmUlA= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=pfvEsxds; spf=pass (imf17.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.179 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Envelope-To: roman.gushchin@linux.dev DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1719335037; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5eS9TJekxDVy7pj/kCvzbG6fFW3jQY5tj8X/hscqVo8=; b=pfvEsxdsh8mMt4C8BLMqOK1WIsW18E6YqnZhXzVyrSmObWAdWXIylqcLvJLCb9xdT/SmhK BilkhaV82DWU/EBGHy+sNNEErSuq2yjtGrzKpAwhLP+N9qcffWumDF983SmLQdSh9lLq5K nvtsGBaiT0mhzbysvT62aD8LXZgL03E= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: mhocko@kernel.org X-Envelope-To: muchun.song@linux.dev X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: cgroups@vger.kernel.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: willy@infradead.org Date: Tue, 25 Jun 2024 10:03:53 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Roman Gushchin Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Muchun Song , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Matthew Wilcox Subject: Re: [PATCH v2 00/14] mm: memcg: separate legacy cgroup v1 code and put under config option Message-ID: References: <20240625005906.106920-1-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240625005906.106920-1-roman.gushchin@linux.dev> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 2107E40053 X-Stat-Signature: tagk47788p7j1kc87nxdhokmxpmpzzna X-HE-Tag: 1719335038-559288 X-HE-Meta: U2FsdGVkX1+WPe7uk0MKLTF46whu7g8bpeZOJHLJo5HFXIXIIJD/L9Ltqe55cRyAj/8Vy7OeZc5zUg3eEGKJQq7VVRucsSvbjo3DENvxiAyRUoGITfd1A8b20si9yKw+579QvJyV369T1mzkwcg5aIs44fupuSkmw8UacLpRQQXnshEdkU9AZKbOyrhuPCaj2QZ6qqGyol5HUeMOWFCr8Q6m9dgUMV2sCAEAzjC/UF2x6EqoesbVu+Kw0sWnZr00QOaG8/sQPF3lk2svpwQtXyLyEBK9G+THAbCsfYjWnkKm0gi5Zt4/HIDmPfqk525u21dtPyIiZUUuLasqOm6VfZiZ8MQGagWlPigWbFhZbVfzbvQ245rsxGgzdRpKVNCdjJia+eWF9V/aergX0OiHFLcMd7m/e/iuZbPFJ2C9ja1Yquvz+e6aVdL+yhF9s2os/EMHsV3nTcqdUrU8ETesQXVxID0dB3oVjuz50Spg10PI3Zi4QB3HMRs4Vpk+TYUrnmJMJsqWXC+HWCmjd6jyk8OAqttOv0XVn/+TazcNB2QCbfZ/EcVlBrklPE6WXtjAuZQ9H2RiXL6HybmXsqNX1dx2jOr8IP/BVBtzwkTAcvf8o1mgRPGzjQX2Dd4RlcjdKqP2dfBOWUojKl2L7tnVzM90mcwKRem+e/pyTnSq+kg07nOcYKw6ZJMHSduTHne1VkhOtUt4bwU4LEYz6VwJpivhIvgnJ3i76M2g1uUY5lACq0Nz8G6D4nJ1PXr5B9b1qLmb+QbqB9YcmPrpT0v9MZSQMw5mwPTRWPVhnrvigmc/ZnAeD+i00sRUYit21IxGki+qjV4Gz2e53wMYoFqzF4y5dZGiNKkCPq+mAYHR1KcVmFRgxiE4XhTIddgz/ovfnA3O0+rB1pLkReFMzTJxJVnaHlezfZFohTRWjBgIedYX2VL7Q8cgcA/o1LKlEDH8Uuf3EFvpAJemAu3x8EE QExrBKTI xy6zDHSyRtlP/ZqGD8hgbH/O5ptay4BspfCNYxQcrI/62V4FAFFZQK3neg6PdkZdWPZ3VOcHQwtExNXyBDAxYmQ1YiaxuKzbZThMO8wJumDwPXGSgE9tedsw9KMYHfhLLz56l/9MCGGiMsTu8QVkNQtFiizcAk3tjwQCfmQhhazYbIgzQAkSnJh/ELJ15AF206BKRwAVY34tXIvLt15I/ovTs57UUhMutotu7AfSyJqI9vT9EmulmqDTBLRRi1H9ch90AJJ8f1WyDX30= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 24, 2024 at 05:58:52PM GMT, Roman Gushchin wrote: > Cgroups v2 have been around for a while and many users have fully adopted them, > so they never use cgroups v1 features and functionality. Yet they have to "pay" > for the cgroup v1 support anyway: > 1) the kernel binary contains an unused cgroup v1 code, > 2) some code paths have additional checks which are not needed, > 3) some common structures like task_struct and mem_cgroup contain unused > cgroup v1-specific members. > > Cgroup v1's memory controller has a number of features that are not supported > by cgroup v2 and their implementation is pretty much self contained. > Most notably, these features are: soft limit reclaim, oom handling in userspace, > complicated event notification system, charge migration. Cgroup v1-specific code > in memcontrol.c is close to 4k lines in size and it's intervened with generic > and cgroup v2-specific code. It's a burden on developers and maintainers. > > This patchset aims to solve these problems by: > 1) moving cgroup v1-specific memcg code to the new mm/memcontrol-v1.c file, > 2) putting definitions shared by memcontrol.c and memcontrol-v1.c into the > mm/memcontrol-v1.h header, > 3) introducing the CONFIG_MEMCG_V1 config option, turned off by default, > 4) making memcontrol-v1.c to compile only if CONFIG_MEMCG_V1 is set. > > If CONFIG_MEMCG_V1 is not set, cgroup v1 memory controller is still available > for mounting, however no memory-specific control knobs are present. > > This patchset is based against mm-unstable tree (b610f75d19a34), > however a version based on mm-stable can be found here: > https://github.com/rgushchin/linux/tree/memcontrol_v1.1-stable . > > v2: > - minor compilation fix > - #else/#endif comments fix (Lance Yang) > > v1: > - switched to CONFIG_MEMCG_V1 being off by default based on LSFMMBPF > discussion [1] > - switched to memcg1_ prefix (Johannes) > - many minor fixes > - dropped patches which put struct memcg members under CONFIG_MEMCG_V1 > (will post as a separate patchset) > > rfc: > https://lwn.net/Articles/973082/ > > [1]: https://lwn.net/Articles/974575/ > > MAINTAINERS | 2 + > include/linux/memcontrol.h | 156 ++++--- > init/Kconfig | 9 + > mm/Makefile | 2 + > mm/memcontrol-v1.c | 2933 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > mm/memcontrol-v1.h | 132 ++++++ > mm/memcontrol.c | 4169 +++++++++++++++++++++++++++--------------------------------------------------------------------------------------------------------------------------------------------------- > mm/vmscan.c | 10 +- > 8 files changed, 3794 insertions(+), 3619 deletions(-) > > Suggested-by: Matthew Wilcox (Oracle) > Signed-off-by: Roman Gushchin For the series: Acked-by: Shakeel Butt