From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55391C02198 for ; Wed, 12 Feb 2025 22:26:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E5B6B6B0093; Wed, 12 Feb 2025 17:26:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E0B566B0095; Wed, 12 Feb 2025 17:26:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CFA006B0096; Wed, 12 Feb 2025 17:26:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AFA476B0093 for ; Wed, 12 Feb 2025 17:26:02 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 62F2480FEA for ; Wed, 12 Feb 2025 22:26:02 +0000 (UTC) X-FDA: 83112726564.21.5F04D7F Received: from out-185.mta0.migadu.com (out-185.mta0.migadu.com [91.218.175.185]) by imf18.hostedemail.com (Postfix) with ESMTP id 0F51E1C0004 for ; Wed, 12 Feb 2025 22:25:59 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=SrLRpXJ5; spf=pass (imf18.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.185 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739399160; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m9HBBII1nXU+thEECyzJU0uguy9bFF7mdhp10qRQOVI=; b=OICG4bi80ONP4DTddjZ350KBv5CdCwQ4+BpMBZS/BWUnUBz8FMNcQISn7/uLpuRR+Bkiea hX4/0QEi/5sUdpa04HPuq2fg4wEKdm+FFsOW9/6uhmssok0WT8dJC7+uUkQF3HAVTW6DX2 r1gqIPodcUeEf0a8a9WvVfWtv4xK9CU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739399160; a=rsa-sha256; cv=none; b=Vvdfh26x0adVbUa3vdNBaguTOdxu6TCDFIkFmf79/2MI6tCC6sgi/XPy2IPvi6UKsprz2V dHo84XcWF1nbZkOcY72kleq5ZEFJzOCSLDymKpvH3W1MsLK+S+NaIH80Vu/9BVoTLfzr97 BMYEuBg2oKIRx6rU3DrBRwT0p17MGwI= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=SrLRpXJ5; spf=pass (imf18.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.185 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Wed, 12 Feb 2025 14:25:53 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1739399157; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m9HBBII1nXU+thEECyzJU0uguy9bFF7mdhp10qRQOVI=; b=SrLRpXJ5qzKU1iqI2AZ8397DntehUUTtddlftErTwaaLdtlyqgP3yJ8Ykuen0u/8MqpGG3 wYtYQhblm+6QR9WCspKZg36XGWtVAbXid4H7tW21PyaMQsQlBpvhdEWdyeufy6FKDXCBtm feXOnRziB+3+heC0wg0EWC9OQ4x7YfA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Jordan Rome Cc: bpf@vger.kernel.org, linux-mm@kvack.org, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Kernel Team , Andrew Morton , Alexander Potapenko Subject: Re: [bpf-next v7 1/3] mm: add copy_remote_vm_str Message-ID: References: <20250210221626.2098522-1-linux@jordanrome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250210221626.2098522-1-linux@jordanrome.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Queue-Id: 0F51E1C0004 X-Rspamd-Server: rspam07 X-Stat-Signature: gydk4orffsydzxee1iz6ofn59rz4pin7 X-HE-Tag: 1739399159-403165 X-HE-Meta: U2FsdGVkX18OsZyfgqELfVlYb7TnWpXKuL2R3S7dUWmYBxm7LW8iiIqtQLkoexdKYRAgNbweQavDeoxS8llSILnKA8wC63l9VKWCVkowqcC08jUSJa9Oi7sMG1Z09Tkn2kvBYA9v+SBMLrwL/kFJNr1gTzZoyddH4LhtMZh+E1t3HcZGcJ2eGQeAn3MkEco7HXPkAS5z9xg70xq6lm2i6aaq9zGR7H9sJKzhoNZRdP5xOWaAWGMEB+s/lS7RtLf8H8qUQED9J9y3o80n4VWIsPu5tYZ0ydb76oXcka/Eqw8lHHL+SjepriSYeUb5eRXY8sJg7sDrDmebyVxu98BpcwGzIEIX1NMmks8grImQwpbSFd7c2Fx1Uiux5BbVud9maZaMY8oCzYVypPYlIZwySyxNV+J0h8qtQAPChYkAzJ0O2PY/zrWXC5nnADh1iEU3s6OWKK1dV+haE7gg5QAbnxrl9YJnfMUn/JTsvWmTLh9kPGp8NvQlNkNJM7kvZb+HvZWnQ4sY1L/ARn7X+ANa95cGmcJAVYTnrH3wCDRiThhn3UiaAnHxb62905evuHja/r/3IzPADzz3vpmHTIKYZY3rgBqmKJXWKozIEGnc4rQikjndgHA/nA/6NM9fQ8H6vhtySDD+iQjCn07cMolwRvMbuR35VBUhmLF1U+TvRa8N+TKxBytn3IcZGFph2pkFyuUCVCwn2jjBv/67an241H1pg2RyBUZq0SC7vxpOjXJXT/y0xs6uOFiXJa2qP6KarP+IBPAixVho3C5P0Q9KNMfeMDAhk3ENEOAjqTbB5HXgERodCv6iQBI5/Hgv7q7lS0sKNPeebgyzJ03u/j4B8svsxmOm6U9uOguseMDNI+3JlAXSnH0ivhH27aDvbejOHP4oAoRF2mIMNoefxMxB5Z72amPgfJvMJ8lYIBmK3ZMf2yhWz4TqHnpAoMUCF/JWh7KzGbO81lKT6mRyyLp efpq06Uj oulNOjjo+VZpzRdqiIEWOmlfrq+Sis0RPMNbYFxHk585Xra4/p9T5O7ATfWqzDDNJBOqGXOOF+R/rDyjD+IrKHPPSthbtsTYAWSpyptl7j3JVmvh6najaeM2XlNPGA3VTsDK/5+2OV1mWtWcCS432Hhm1+HXS2HDxvKHGdgVKQ3cxefF1nNeNcqFLtvyFTGKcHRUJOrZZSaTyHvtrHzc5KA4RqsZ/mA559NwyJfeze/HE/k4l8ElsQbO2OdK1iKjOiKWkcICLYuO6MeZ33cSnRclLdbetYm9zjwCG X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 10, 2025 at 02:16:24PM -0800, Jordan Rome wrote: > Similar to `access_process_vm` but specific to strings. > Also chunks reads by page and utilizes `strscpy` > for handling null termination. > > Signed-off-by: Jordan Rome If you decide to send a newer version, my request would be to add some more text in the commit message particularly on the motivation. Otherwise this looks good to me. Reviewed-by: Shakeel Butt