From: Shakeel Butt <shakeel.butt@linux.dev>
To: Jordan Rome <linux@jordanrome.com>
Cc: bpf@vger.kernel.org, linux-mm@kvack.org,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Kernel Team <kernel-team@fb.com>,
Andrew Morton <akpm@linux-foundation.org>,
Alexander Potapenko <glider@google.com>
Subject: Re: [bpf-next v7 1/3] mm: add copy_remote_vm_str
Date: Wed, 12 Feb 2025 14:25:53 -0800 [thread overview]
Message-ID: <rkor47tohikmgixexi46mpalttxud7k2n5gidqbxoqzhwkjkas@rdl4dzndjz47> (raw)
In-Reply-To: <20250210221626.2098522-1-linux@jordanrome.com>
On Mon, Feb 10, 2025 at 02:16:24PM -0800, Jordan Rome wrote:
> Similar to `access_process_vm` but specific to strings.
> Also chunks reads by page and utilizes `strscpy`
> for handling null termination.
>
> Signed-off-by: Jordan Rome <linux@jordanrome.com>
If you decide to send a newer version, my request would be to add some
more text in the commit message particularly on the motivation.
Otherwise this looks good to me.
Reviewed-by: Shakeel Butt <shakeel.butt@linux.dev>
prev parent reply other threads:[~2025-02-12 22:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 22:16 Jordan Rome
2025-02-10 22:16 ` [bpf-next v7 2/3] bpf: Add bpf_copy_from_user_task_str kfunc Jordan Rome
2025-02-10 22:16 ` [bpf-next v7 3/3] selftests/bpf: Add tests for bpf_copy_from_user_task_str Jordan Rome
2025-02-11 22:07 ` [bpf-next v7 1/3] mm: add copy_remote_vm_str Andrii Nakryiko
2025-02-12 2:19 ` Shakeel Butt
2025-02-12 17:33 ` Jordan Rome
2025-02-12 22:25 ` Shakeel Butt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=rkor47tohikmgixexi46mpalttxud7k2n5gidqbxoqzhwkjkas@rdl4dzndjz47 \
--to=shakeel.butt@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=glider@google.com \
--cc=kernel-team@fb.com \
--cc=linux-mm@kvack.org \
--cc=linux@jordanrome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox