From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C96A3C369CA for ; Sat, 19 Apr 2025 16:37:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 27B646B0089; Sat, 19 Apr 2025 12:37:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2024B6B008A; Sat, 19 Apr 2025 12:37:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CB786B008C; Sat, 19 Apr 2025 12:37:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E63DF6B0089 for ; Sat, 19 Apr 2025 12:37:06 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A8540142991 for ; Sat, 19 Apr 2025 16:37:07 +0000 (UTC) X-FDA: 83351348094.16.7E63E93 Received: from out-183.mta1.migadu.com (out-183.mta1.migadu.com [95.215.58.183]) by imf04.hostedemail.com (Postfix) with ESMTP id 2E9B040003 for ; Sat, 19 Apr 2025 16:37:03 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=JpKvX9rV; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf04.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.183 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745080626; a=rsa-sha256; cv=none; b=tOchuWvDC7s+gC/GWZfL+edramazjPzLJBtsdwDDv/Rh6Cb3s/PSEApbgwcOcDLM9nR3h8 UL/go++aNOmuaIx7EQtbooLuqZ1ojluwAZB0MJIVp/RbWp6FGgWQa+o+79WsorM5w8y5ID sSe1dfCCq1GEbvVeWdsHWTi04yyKXy4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=JpKvX9rV; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf04.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.183 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745080626; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3gAqc7ZMsVtcf6IciKTKwKTL0on26u+L0x1CBV9xTls=; b=l2FOC1kumkSoss4rTM7/HHJte0faLLdJyfsiwfmUMBtWgd9jbtAYL6gb96kP48zPrwjWdP gDomj/bBNW4zMqMfJyfsw8/ntFif1RILCL4X55XC6y0DW0c9XAdODsEuuImp5jWCnh4FNo mvdWEcUApbPHnl5stdK3C3sPE67VI7g= Date: Sat, 19 Apr 2025 09:36:46 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1745080621; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3gAqc7ZMsVtcf6IciKTKwKTL0on26u+L0x1CBV9xTls=; b=JpKvX9rVoPn321DOwtQil6lH+d2atYqiTTUjWcI+jNgRMLMNOmWuVi1nYJ83M3syXsYt3l i/kS7Mi095iKRFj0AqYdtVPzHO7KH7DVrOuyyVoRSGJIvyvCnopOnxc7QJdMARZtXV6fOn DbpM4l652S0lNHal3Uvcq2QIK6S6738= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Tejun Heo Cc: Roman Gushchin , Greg Thelen , Andrew Morton , Johannes Weiner , Michal Hocko , Muchun Song , Yosry Ahmed , Michal =?utf-8?Q?Koutn=C3=BD?= , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: Re: [PATCH] memcg: introduce non-blocking limit setting interfaces Message-ID: References: <20250418195956.64824-1-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 2E9B040003 X-Stat-Signature: xe6ryun66367o5nxxxytjtcjhe3ux8fm X-Rspam-User: X-HE-Tag: 1745080623-463664 X-HE-Meta: U2FsdGVkX1/KEZC4vekc/0ffwwMZrwdktE7eczjewFmEJYcuPaJxzWVh8mV1+1WLXD/buelY0WHCiHvCdM8sNdsziFFAx6eGos05LeQGRQjrXtcqbZFoOQzEAOaSWsOh4wJ/xxFYiWs1rGlgHYWadknduu1s9gtszbYqbvJ0z0MNAC099rV6UCBfU1tRAY7RRRVW2tqVKzfdKujaQtPwRDo6n1anNA2E7OejdZq6F/D1vYgFyYFYaHuBoMGp7kWxkaCK/bym9QRFfc6gL34/fwUKlE7itzQSrqvhpfp99VrOB30w6uhgbx/qlfsXhAvd6woUuJkih+2HDk5l0eDxs4zF06/Hk4/OGntU4SYO80Ld2FdC3G1HdIylkwLYOnagvEn5YzZ5sy3S4UBh0UOybism3IEyZnHVNos0/B2j1UgjNcq49eyNGS7JL0+87ZEiHGpFHHNRKL8n5IU/28mUJOk67xP7Zuihg9+NI1sWnkE7J1CRzpH9w4YIrQ7xSV+q20FTqNMB5L4ilAst4qk4azi+jERphZxJWfqW4k+bn520CmiJ2avGtIaRYpdK3x0CshB1iizD5nPp3jAgTCtwrJewsqYV37L1Hpce5iOCJLaFryqvCO9h9SoNtQQXVJyFvhhgDE05AWZnNpAtUi9X6RhRBjkxYk/pV8qEycfOl/ZmY+9sDDQTFiYR+xZtVMHIW4rehO5yx1Sz3fzGjC7MB857MEzhKpvnNWnJeccHmfut+0gqfAqw/YGkNxa/t1aUJr2Ni8LQxCPL1pwRcZlzcesi1686nt8oqLVdM8p2Nn1LTwhPsXouCLyOFC+Autmb0yY6Nbe/wTgxHpYfK2yn7YCt5AHLHld1myf4wSMQxr95dBIZqG9kf/SpjtybhoDaOQmIrfHg+EXahGQjqak334S26b2rVNQ4m5/9PC0ek6kHUlolsT2TsF5I14Yf9ubOBE7980h5RgdbZ3E+aFR UkYGdhCF fPT2UCjFq+B/roXGZmVKybrXuDqdMVGHO6ooa8gdDWpjVCkHJYgoBAQyhEDgzV3v0JZFzGFRfm+a/0nkaHZNSbbsvgCtOEwpmgxV+PP0+GhTqLB++ZdwjtPA7NjpKiwl/FqdJ8qUu1w4kbzYJj7xiKil+xEcRQ4SSNEeZcOjkNBFyPC+P1UJJjHc9Ig== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 18, 2025 at 05:15:38PM -1000, Tejun Heo wrote: > On Fri, Apr 18, 2025 at 04:08:42PM -0700, Shakeel Butt wrote: > > Any reasons to prefer one over the other? To me having separate > > files/interfaces seem more clean and are more script friendly. Also > > let's see what others have to say or prefer. > > I kinda like O_NONBLOCK. The subtlety level of the interface seems to match > that of the implemented behavior. > Ok, it seems like more people prefer O_NONBLOCK, so be it. I will send v2 soon. Also I would request to backport to stable kernels. Let me know if anyone have concerns. I asked AI how to do the nonblock write in a script and got following: $ echo 10G | dd of=memory.max oflag=nonblock Shakeel