From: Shakeel Butt <shakeel.butt@linux.dev>
To: Tejun Heo <tj@kernel.org>
Cc: "Roman Gushchin" <roman.gushchin@linux.dev>,
"Greg Thelen" <gthelen@google.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Hocko" <mhocko@kernel.org>,
"Muchun Song" <muchun.song@linux.dev>,
"Yosry Ahmed" <yosry.ahmed@linux.dev>,
"Michal Koutný" <mkoutny@suse.com>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Meta kernel team" <kernel-team@meta.com>
Subject: Re: [PATCH] memcg: introduce non-blocking limit setting interfaces
Date: Sat, 19 Apr 2025 09:36:46 -0700 [thread overview]
Message-ID: <rgze2xgrslssxoe7k3vcfg6fy2ywe4jowvwlbdsxrcrvhmklzv@jhyomycycs4n> (raw)
In-Reply-To: <aAMVWsFbht3MdMEk@slm.duckdns.org>
On Fri, Apr 18, 2025 at 05:15:38PM -1000, Tejun Heo wrote:
> On Fri, Apr 18, 2025 at 04:08:42PM -0700, Shakeel Butt wrote:
> > Any reasons to prefer one over the other? To me having separate
> > files/interfaces seem more clean and are more script friendly. Also
> > let's see what others have to say or prefer.
>
> I kinda like O_NONBLOCK. The subtlety level of the interface seems to match
> that of the implemented behavior.
>
Ok, it seems like more people prefer O_NONBLOCK, so be it. I will send
v2 soon.
Also I would request to backport to stable kernels. Let me know if
anyone have concerns.
I asked AI how to do the nonblock write in a script and got following:
$ echo 10G | dd of=memory.max oflag=nonblock
Shakeel
next prev parent reply other threads:[~2025-04-19 16:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-18 19:59 Shakeel Butt
2025-04-18 20:18 ` Greg Thelen
2025-04-18 20:30 ` Shakeel Butt
2025-04-18 22:07 ` Roman Gushchin
2025-04-18 23:08 ` Shakeel Butt
2025-04-19 3:15 ` Tejun Heo
2025-04-19 16:36 ` Shakeel Butt [this message]
2025-04-21 17:06 ` Greg Thelen
2025-04-21 17:28 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=rgze2xgrslssxoe7k3vcfg6fy2ywe4jowvwlbdsxrcrvhmklzv@jhyomycycs4n \
--to=shakeel.butt@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=gthelen@google.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mkoutny@suse.com \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=tj@kernel.org \
--cc=yosry.ahmed@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox