From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19D23C4167B for ; Tue, 12 Dec 2023 09:19:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4CB856B02A2; Tue, 12 Dec 2023 04:19:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 47B8B6B02A3; Tue, 12 Dec 2023 04:19:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F5AB6B02A4; Tue, 12 Dec 2023 04:19:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1BA356B02A2 for ; Tue, 12 Dec 2023 04:19:52 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id CEB86408C1 for ; Tue, 12 Dec 2023 09:19:51 +0000 (UTC) X-FDA: 81557618982.06.82C83BC Received: from postout2.mail.lrz.de (postout2.mail.lrz.de [129.187.255.138]) by imf28.hostedemail.com (Postfix) with ESMTP id 469B5C0005 for ; Tue, 12 Dec 2023 09:19:49 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=tum.de header.s=tu-postout21 header.b=icWpRiDQ; dmarc=pass (policy=none) header.from=tum.de; spf=pass (imf28.hostedemail.com: domain of paul.heidekrueger@tum.de designates 129.187.255.138 as permitted sender) smtp.mailfrom=paul.heidekrueger@tum.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702372789; a=rsa-sha256; cv=none; b=Lut95Y44UTGxAgd3FtAsYSZb572Pio56SHtVXcTE2/fvVY7EiWyGa+C6ELFK2JAYwD6lmW gKdUDZESjzzN2+FmAuQZ3x0njkgGs3nUd2e+unN+UayI+0RswOATPVhGsvxzPm8hsWUZun CK1T6vDu93wNuP8A6Mu1V2+EsIKSYf8= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=tum.de header.s=tu-postout21 header.b=icWpRiDQ; dmarc=pass (policy=none) header.from=tum.de; spf=pass (imf28.hostedemail.com: domain of paul.heidekrueger@tum.de designates 129.187.255.138 as permitted sender) smtp.mailfrom=paul.heidekrueger@tum.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702372789; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n3iXsZTA7DDZEZZBAbZi7ahs/svo8ZJWI4qmMuM5zT4=; b=WtDGv5m7WOIyfZJNpto2kt+NSvk/KRzQrUI0dwO0wepffzFT6j3xEiLzqHeSwQeBs3eThT CbcC4G9AnhrIpKgumt17eNdhT0l5Ollx3Jnj3LCdJh/rUdQHbLk2/NbAG3Z8is/X11xVxt 4sfRHgph752CO4OqnpYN8SGlwPGUnoQ= Received: from lxmhs52.srv.lrz.de (localhost [127.0.0.1]) by postout2.mail.lrz.de (Postfix) with ESMTP id 4SqCkB4ZNdzyTl; Tue, 12 Dec 2023 10:19:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tum.de; h= in-reply-to:content-transfer-encoding:content-disposition :content-type:content-type:mime-version:references:message-id :subject:subject:from:from:date:date:received:received; s= tu-postout21; t=1702372786; bh=WVqZLzbRiMUVOMOUzl6GSebSesNYA4TdD tY3d47tqa4=; b=icWpRiDQ+Dkbt+mbfo6bx1CaHVlYa5iIVdt+nEteVMvyk5htn ORZz4sgz+cJyVTstEOFDiKVgqoXEOZYjVsGNY1btar+2KLWGtlmxULK/NPPYZ8cf 6NeuW01lhF9UQ7/Zusoo+1ahqV6ePZjLUNWb5kyJbZXAwkPvOmu+AjXUAZn+N99O eDlzA2ZQzcRM5NgucQA1PGPUXlL7OfbfWQ71C7vKH7w0pNuNilSOmGh8IPtS+Ne4 SxSeNqMQA8EPgqiMUX+NvuVH6zZkjheMDThKsRCh15KZUGgOWGsUdpfPzWIUu+rk csqLkCQQb8xXf0kc3YCiAzWN7zLjAZF/sT/Hg== X-Virus-Scanned: by amavisd-new at lrz.de in lxmhs52.srv.lrz.de Received: from postout2.mail.lrz.de ([127.0.0.1]) by lxmhs52.srv.lrz.de (lxmhs52.srv.lrz.de [127.0.0.1]) (amavisd-new, port 20024) with LMTP id U88J6q2Jd8Lb; Tue, 12 Dec 2023 10:19:46 +0100 (CET) Received: from cerulean.fritz.box (unknown [IPv6:2001:a61:245c:a01:443b:cc34:8ae7:6ede]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by postout2.mail.lrz.de (Postfix) with ESMTPSA id 4SqCk90XN5zyTm; Tue, 12 Dec 2023 10:19:45 +0100 (CET) Date: Tue, 12 Dec 2023 10:19:41 +0100 From: Paul =?utf-8?Q?Heidekr=C3=BCger?= To: Andrey Konovalov Cc: Marco Elver , Steven Rostedt , Peter Collingbourne , andrey.konovalov@linux.dev, Andrew Morton , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov , Masami Hiramatsu , linux-trace-kernel@vger.kernel.org, Nick Desaulniers Subject: Re: [PATCH v3 1/3] kasan: switch kunit tests to console tracepoints Message-ID: References: <20230505095805.759153de@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 469B5C0005 X-Stat-Signature: fkjeyysz4tq11xb8ceiff6h7syn1ncbo X-HE-Tag: 1702372789-263295 X-HE-Meta: U2FsdGVkX19dGrLwAtRpJOjiychk9Ca0L5BqWTEQyk1JkW5KZhisfYKUeu6pB1HDdjTQ2zxJWkZBi1nHN1xX0FuvsXDiBoaoFqRwATbDf2o7XyQF+0rm6nWPlRDRP3zm5WdvC7UoRO5r/8YtaSzAvrOlTcSNZB8W7k4V2LYrPJUaTL0sktjBs5jYEmAtvG6c7jCfA6mqCESvmI8AbThL/59npw4UkjdqLliZU6N2045woFtlStBcz1jG6mkS/amReq9VCIZDSyn1z+ChOn8uIYcDm1Oy61WrogUo4sUynCxRbOl/5gs30+FILs0QM8nMsfXtjkQgnR+9ynEpmcIXCYEF5vYgD7ad4P43uM/2rRvFD9lslunM1jBoQSdbcX9ANWsz4ImlvYTQ8iTUJQmUCwJb9KoiDpN64Gp4/L3Q5suIithmJd+lH2XnUyYTmj51ChuVJgwh1QCcBilQVLyIHFf32DlCF9+vUyaCnU+JGTAmy5B9qsIHudasyhsntR6HcppDchLq+U7yQd7bYK80wlt63Lx9D8M20tVByvmjycLl7DdiN/j2xNz0Pu6tUzYF0q+Fx4MToMGmNYk6S7S9mCOUivl0SjUmb+GACD5KOMgEMHA5Rc/J4pTF89HPFGGyyXbCr2GtqIu9wOis89yL3auGOga5ByTv6TdXQ298rm0XZudQlHSpKS2TLxi40n+GDDPSQaPT66v+9LQpE45KhgMO6FI9KnvpSgVfhAjq1Zul0QI3gxXfhlDFfdF4xba+jcUO/7FWvZh8cMZqFewzdZwPx+jF1nRIoxHUOL8Al/ur+L8tvj/OsXqKmKYIXuTLm+WjIF9auAdaYDaLF5G6jtVUMzynO/4sjtdr2ja9cJYa5j2EKr+cBdDVLiyL10Oo6PjNNP8t08CEgNZ1Fhupe2gqa+S8dfQwEtrUATrrg4BPubQh3l6739Pj90uA9dEJU5R++n0lWd4yTp6J9WP X6knmnoP hl4JIpDKn24ot7+yn4UDJ8Q7Y7tDKrV3K9ZiLwMLr7e2/RfTR59rJc4OUPVREkQwksmE9iyUh4p5heIw9Hnw1NhO/oNPeIAR2aKt0p806CuhxixCOBWD6JCw0xqBNotmuNg2meArfLMB+/pnlY9MWk53ShlnzIxoYB5xLV5CYrT8PhwsOYr1RiOjN3h1fHcuH7z0429DZNPECz4QjM4Q97tOF1WINHGI8zrVmQneQvH8DAR6/NIUwcdTXiL2ZNY21XWoEKa3aNAtiMrLHbELmu/kHcii68c29kPhIDaJjNN4cTXY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12.12.2023 00:37, Andrey Konovalov wrote: > On Tue, Dec 12, 2023 at 12:35 AM Paul Heidekrüger > wrote: > > > > Using CONFIG_FTRACE=y instead of CONFIG_TRACEPOINTS=y produces the same error > > for me. > > > > So > > > > CONFIG_KUNIT=y > > CONFIG_KUNIT_ALL_TESTS=n > > CONFIG_FTRACE=y > > CONFIG_KASAN=y > > CONFIG_KASAN_GENERIC=y > > CONFIG_KASAN_KUNIT_TEST=y > > > > produces > > > > ➜ ./tools/testing/kunit/kunit.py run --kunitconfig=mm/kasan/.kunitconfig --arch=arm64 > > Configuring KUnit Kernel ... > > Regenerating .config ... > > Populating config with: > > $ make ARCH=arm64 O=.kunit olddefconfig CC=clang > > ERROR:root:Not all Kconfig options selected in kunitconfig were in the generated .config. > > This is probably due to unsatisfied dependencies. > > Missing: CONFIG_KASAN_KUNIT_TEST=y > > > > By that error message, CONFIG_FTRACE appears to be present in the generated > > config, but CONFIG_KASAN_KUNIT_TEST still isn't. Presumably, > > CONFIG_KASAN_KUNIT_TEST is missing because of an unsatisfied dependency, which > > must be CONFIG_TRACEPOINTS, unless I'm missing something ... > > > > If I just generate an arm64 defconfig and select CONFIG_FTRACE=y, > > CONFIG_TRACEPOINTS=y shows up in my .config. So, maybe this is kunit.py-related > > then? > > > > Andrey, you said that the tests have been working for you; are you running them > > with kunit.py? > > No, I just run the kernel built with a config file that I put together > based on defconfig. Ah. I believe I've figured it out. When I add CONFIG_STACK_TRACER=y in addition to CONFIG_FTRACE=y, it works. CONFIG_STACK_TRACER selects CONFIG_FUNCTION_TRACER, CONFIG_FUNCTION_TRACER selects CONFIG_GENERIC_TRACER, CONFIG_GENERIC_TRACER selects CONFIG_TRACING, and CONFIG_TRACING selects CONFIG_TRACEPOINTS. CONFIG_BLK_DEV_IO_TRACE=y also works instead of CONFIG_STACK_TRACER=y, as it directly selects CONFIG_TRACEPOINTS. CONFIG_FTRACE=y on its own does not appear suffice for kunit.py on arm64. I believe the reason my .kunitconfig as well as the existing mm/kfence/.kunitconfig work on X86 is because CONFIG_TRACEPOINTS=y is present in an X86 defconfig. Does this make sense? Would you welcome a patch addressing this for the existing mm/kfence/.kunitconfig? I would also like to submit a patch for an mm/kasan/.kunitconfig. Do you think that would be helpful too? FWICT, kernel/kcsan/.kunitconfig might also be affected since CONFIG_KCSAN_KUNIT_TEST also depends on CONFIG_TRACEPOITNS, but I would have to test that. That could be a third patch. What do you think? Many thanks, Paul