From: "Paul Heidekrüger" <paul.heidekrueger@tum.de>
To: Andrey Konovalov <andreyknvl@gmail.com>
Cc: Marco Elver <elver@google.com>,
Steven Rostedt <rostedt@goodmis.org>,
Peter Collingbourne <pcc@google.com>,
andrey.konovalov@linux.dev,
Andrew Morton <akpm@linux-foundation.org>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
kasan-dev@googlegroups.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Andrey Konovalov <andreyknvl@google.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
linux-trace-kernel@vger.kernel.org,
Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH v3 1/3] kasan: switch kunit tests to console tracepoints
Date: Tue, 12 Dec 2023 10:19:41 +0100 [thread overview]
Message-ID: <rgndtm3sawyzdh76oofoqp22jyqdb25sd4326k2heevjmxum7f@wfgwvdf4iuyi> (raw)
In-Reply-To: <CA+fCnZf5kxWUWCzK8EKgUuq_E2rYv5aw=SqZMDb93+=7vSUp+w@mail.gmail.com>
On 12.12.2023 00:37, Andrey Konovalov wrote:
> On Tue, Dec 12, 2023 at 12:35 AM Paul Heidekrüger
> <paul.heidekrueger@tum.de> wrote:
> >
> > Using CONFIG_FTRACE=y instead of CONFIG_TRACEPOINTS=y produces the same error
> > for me.
> >
> > So
> >
> > CONFIG_KUNIT=y
> > CONFIG_KUNIT_ALL_TESTS=n
> > CONFIG_FTRACE=y
> > CONFIG_KASAN=y
> > CONFIG_KASAN_GENERIC=y
> > CONFIG_KASAN_KUNIT_TEST=y
> >
> > produces
> >
> > ➜ ./tools/testing/kunit/kunit.py run --kunitconfig=mm/kasan/.kunitconfig --arch=arm64
> > Configuring KUnit Kernel ...
> > Regenerating .config ...
> > Populating config with:
> > $ make ARCH=arm64 O=.kunit olddefconfig CC=clang
> > ERROR:root:Not all Kconfig options selected in kunitconfig were in the generated .config.
> > This is probably due to unsatisfied dependencies.
> > Missing: CONFIG_KASAN_KUNIT_TEST=y
> >
> > By that error message, CONFIG_FTRACE appears to be present in the generated
> > config, but CONFIG_KASAN_KUNIT_TEST still isn't. Presumably,
> > CONFIG_KASAN_KUNIT_TEST is missing because of an unsatisfied dependency, which
> > must be CONFIG_TRACEPOINTS, unless I'm missing something ...
> >
> > If I just generate an arm64 defconfig and select CONFIG_FTRACE=y,
> > CONFIG_TRACEPOINTS=y shows up in my .config. So, maybe this is kunit.py-related
> > then?
> >
> > Andrey, you said that the tests have been working for you; are you running them
> > with kunit.py?
>
> No, I just run the kernel built with a config file that I put together
> based on defconfig.
Ah. I believe I've figured it out.
When I add CONFIG_STACK_TRACER=y in addition to CONFIG_FTRACE=y, it works.
CONFIG_STACK_TRACER selects CONFIG_FUNCTION_TRACER, CONFIG_FUNCTION_TRACER
selects CONFIG_GENERIC_TRACER, CONFIG_GENERIC_TRACER selects CONFIG_TRACING, and
CONFIG_TRACING selects CONFIG_TRACEPOINTS.
CONFIG_BLK_DEV_IO_TRACE=y also works instead of CONFIG_STACK_TRACER=y, as it
directly selects CONFIG_TRACEPOINTS.
CONFIG_FTRACE=y on its own does not appear suffice for kunit.py on arm64.
I believe the reason my .kunitconfig as well as the existing
mm/kfence/.kunitconfig work on X86 is because CONFIG_TRACEPOINTS=y is present in
an X86 defconfig.
Does this make sense?
Would you welcome a patch addressing this for the existing
mm/kfence/.kunitconfig?
I would also like to submit a patch for an mm/kasan/.kunitconfig. Do you think
that would be helpful too?
FWICT, kernel/kcsan/.kunitconfig might also be affected since
CONFIG_KCSAN_KUNIT_TEST also depends on CONFIG_TRACEPOITNS, but I would have to
test that. That could be a third patch.
What do you think?
Many thanks,
Paul
next prev parent reply other threads:[~2023-12-12 9:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 17:17 andrey.konovalov
2022-10-18 17:17 ` [PATCH v3 2/3] kasan: migrate kasan_rcu_uaf test to kunit andrey.konovalov
2022-10-18 17:17 ` [PATCH v3 3/3] kasan: migrate workqueue_uaf " andrey.konovalov
2023-02-14 1:21 ` [PATCH v3 1/3] kasan: switch kunit tests to console tracepoints Peter Collingbourne
2023-02-14 6:07 ` Marco Elver
2023-02-15 2:55 ` Peter Collingbourne
2023-02-15 8:57 ` Marco Elver
2023-02-15 19:33 ` Steven Rostedt
2023-02-24 6:45 ` Peter Collingbourne
2023-05-01 22:02 ` Peter Collingbourne
2023-05-01 22:30 ` Nick Desaulniers
2023-05-05 13:58 ` Steven Rostedt
2023-12-11 16:37 ` Paul Heidekrüger
2023-12-11 17:50 ` Andrey Konovalov
2023-12-11 18:59 ` Paul Heidekrüger
2023-12-11 20:51 ` Andrey Konovalov
2023-12-11 22:47 ` Paul Heidekrüger
2023-12-11 22:56 ` Marco Elver
2023-12-11 23:35 ` Paul Heidekrüger
2023-12-11 23:37 ` Andrey Konovalov
2023-12-12 9:19 ` Paul Heidekrüger [this message]
2023-12-12 9:32 ` Marco Elver
2024-01-07 18:22 ` Paul Heidekrüger
2024-02-05 11:34 ` Paul Heidekrüger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=rgndtm3sawyzdh76oofoqp22jyqdb25sd4326k2heevjmxum7f@wfgwvdf4iuyi \
--to=paul.heidekrueger@tum.de \
--cc=akpm@linux-foundation.org \
--cc=andrey.konovalov@linux.dev \
--cc=andreyknvl@gmail.com \
--cc=andreyknvl@google.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=ndesaulniers@google.com \
--cc=pcc@google.com \
--cc=rostedt@goodmis.org \
--cc=ryabinin.a.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox