From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1288DC369BA for ; Tue, 15 Apr 2025 17:16:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B32E32800AF; Tue, 15 Apr 2025 13:16:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AE12C28008F; Tue, 15 Apr 2025 13:16:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 982A72800AF; Tue, 15 Apr 2025 13:16:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 778B828008F for ; Tue, 15 Apr 2025 13:16:14 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C5E55B2134 for ; Tue, 15 Apr 2025 17:16:14 +0000 (UTC) X-FDA: 83336931468.26.8DBB94F Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by imf29.hostedemail.com (Postfix) with ESMTP id CEF84120016 for ; Tue, 15 Apr 2025 17:16:12 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=GOsvEGUx; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf29.hostedemail.com: domain of mkoutny@suse.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744737373; a=rsa-sha256; cv=none; b=Ly9pSL1BPzgizGt9zVk1Y5CSRIs3bRgW2lm6wqWMWDxVRcA7tIGXLtSUdmsDIECHS+Ie4o Aty3n1BE84QL2/rTxtGqLPSXbCpHY46S8O7QoVwRbiYVKyei3rSWnWjWxXLVCfz6WbxURb 66rmVNep+34pPjXCtBzjgASB8PE1yyU= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=GOsvEGUx; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf29.hostedemail.com: domain of mkoutny@suse.com designates 209.85.221.48 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744737372; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ERO4Wi+Quy5FrqXdSDeWuZdTf9AiJ9u8j3TuvJNqgaA=; b=5uk6N7MV/hOiFUkbwLwYmVU6lFBx3samo/TWxLz2dRD/YM51ooH7LJwY70tnqsfuE3ClF+ 8NV5goapvFmGni3rWABxdSZ8WsXt6EGIdPsmUaStKwPCi1xx8yV8wbmJ+MYPMNvo19Ogsg x8opUor2P3ix6bBJ7mJRWRVaaq2KnKE= Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-39c1ee0fd43so5636426f8f.0 for ; Tue, 15 Apr 2025 10:16:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1744737371; x=1745342171; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ERO4Wi+Quy5FrqXdSDeWuZdTf9AiJ9u8j3TuvJNqgaA=; b=GOsvEGUxGrvZH/U3fX8xEjVTaClxO7tEAfMQ/CJ6uB4dibl0DwHhlsnefhmi5mdu6s B105+lT055Ez7HpjPile3CjZrvcf4gy0c/5oGnEz0rfp/pyMY7rTOOS0AcX3U/JFj/kq wJ4YtBiKMubHqSmm7k1VUhxKu5eTwW5asd0FCtPDsc5HIKhWneJjaVOCbSJiG2pmUcdx nTmJz2AhylWAlKctjZXb1y4QXhsPSouzJTLSzWA5DmrteX+bH8Zpsrzw31naIatKhsIn wSJ+//Ho8imR1VaiR+ZdmtwcaQjJ/Z64NCFev6Ndf65OxsHdMGxlPUZ9q3nubItyPfeg 1JSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744737371; x=1745342171; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ERO4Wi+Quy5FrqXdSDeWuZdTf9AiJ9u8j3TuvJNqgaA=; b=GrBxMfokamp4WJ7IqirLoY+X/AXnAseActR/t9cu8eb2LIeM+DbLJmGSMH8ZtQAYRM YmmYTmMXC2Htsl2Rd1iPoXy579l1IvoXvGqDmsWanrKZ5TUHEVEeMnZnZEh3OKZKe/bc E7hOJ3FtgzBDOaiY+CtqZcx/X6RrvucZJI3nQzqUZTEhOGKgjlHEi6uaIIATCveJThNh 6ED+7HopLqSaNmYgklWsC7eIH6q9LRpcArzAR/wPWPiMwKmVSkwMZWNueb/M8Ymfr5PU U/bh8DsJBs5pPX2I7bK/nWdl7GfxmRFtoYl65BWT1y2bNJ1hBooUxkPeK0mB80lkPK2A m6rg== X-Forwarded-Encrypted: i=1; AJvYcCVjqSXbOdkZ2Mv6HeCynH+Bpymx9Tmdvb/yV3QVT2oHrsN/Yz4EL+DbCHeWZ86i4OJ8Ud25TgTZHQ==@kvack.org X-Gm-Message-State: AOJu0Yw2obU9u4vsFY/uPPH1xAqug11l+LT+s+hzBGYZs1aV4rr1Kcof 85Ls4su9BuOnFoNISznfaRPB7XhqVyb/ArsIwCyiGK1spN6sTpfqa+5hvL7Czns= X-Gm-Gg: ASbGncuRD3CE9ypWXqxL/KRIp83G1zcS9yj2rUskZOiEBju0Wn0R27jCx+j3Jjp6fnL Po6t4PnMhyBqK87RkFZGZPaYy+a3DQid2d7stFDUAwdq7ODBvcONULq6uAu2IM565ivzvaE6in6 OmGBtymQTh6UuezATS/mymMPkkZ7Os++RG0uGVj9dEFM6GIAyqkCkO5BQh5D4BumXGtF08BM5pr gnw3SCWxfQMdjYpjyA7Ro2B8HiciOtFcKHggdvWKkuTR8OpW4wm1pSy7VEjv0yg0UOJW4ZzVFU3 Ywz17r9xZ0KWCDbNxZaLjE6HSkaD3ZBp0Bw7foe59/4= X-Google-Smtp-Source: AGHT+IHVmDcH4GAWyjy/nXxuBoumLFUjgJCymM2NC4I43zX1XBQ8xJQ7+cw4eHL0lwCyojn/qvT7IA== X-Received: by 2002:a05:6000:4205:b0:391:298c:d673 with SMTP id ffacd0b85a97d-39ee276006fmr224100f8f.40.1744737371401; Tue, 15 Apr 2025 10:16:11 -0700 (PDT) Received: from blackdock.suse.cz ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39eaf43d053sm15031214f8f.68.2025.04.15.10.16.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Apr 2025 10:16:11 -0700 (PDT) Date: Tue, 15 Apr 2025 19:16:09 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: JP Kobryn Cc: tj@kernel.org, shakeel.butt@linux.dev, yosryahmed@google.com, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH v4 1/5] cgroup: move rstat base stat objects into their own struct Message-ID: References: <20250404011050.121777-1-inwardvessel@gmail.com> <20250404011050.121777-2-inwardvessel@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="i5my2ttbkie4uhcf" Content-Disposition: inline In-Reply-To: <20250404011050.121777-2-inwardvessel@gmail.com> X-Rspam-User: X-Rspamd-Queue-Id: CEF84120016 X-Rspamd-Server: rspam04 X-Stat-Signature: 9qquqcdqhnyqrn9heu4z47oyz94u1okj X-HE-Tag: 1744737372-640467 X-HE-Meta: U2FsdGVkX187su/ayLfnOcWQw+ntB7ktgRI4fj/udP1E0BEX7wyP478f72Pfjm5w1mbcyL1Nbclhl7amwd8Sr6lHtvPzp9Xxe945GqlC9uT9AJPMsaZBUdghfwZKVU4H3RoltBvl5fgtN6yIMs7VyRwDJh/8CjY9etUQqCFkdUPlJE0zPtN+f8BwPC8jupPuC8TG9ZsW43PLapDcimkEGtYg+qUNBKPNZTRhq3riN3Z2WKAiAqeOeW7015cV6Yr28wxxB0+14I8TluKbMehrIViv7JyXbxLbzeplYpA5y6CAShK2ucoZYn+CI2aQeITOR3CcdHdsoAuEMRb02KJaTYDTSBG/CCaLmChCYwtt6WLybluk0DumGigQUI03LO5egfyTq+9wfn0nDsDZ42RuJ3MGnVmB72jbKTTUoSIWOt9z07055hHgDukKdBjA7pH+X/I1DMz6Op0HkBzNB7VEJEv/wlXVVtqxtS+N729MyIi+HMob3e6fNnwDa/TBYpCO011rCcVE5J1ajZezeY7g7XOY2ZVFxl8FdAYpvwOddQcmZcop4HKvPuN6dO4sjKypHbjDoFzKg8XPssQ6MX9E6deExeUqWCqiHiU4FTw5u1D15K9hkW8zv19R/qA3AmhauZ3M6/rJjkLiLgTFlqmB4LrLUvHWOEvygyoq7JoKjjZ4bGY36R20vlaU1yA02wk2mW4gcjBDo7by38tN9PdKPgodFySeUkm2VWQ7Jk1sU7/CgnHZOzYe9G2TmHeXLMGUKsoB1/UrVxLlxKwRvdrx1Fa8aBe/+301NiM3XVOiHanietXa+s37VstkXJd9HMs/osAfNOnP/MniGJYnpgjvr8f00QkwWFlqd5RMmvucwj/Hvqs/x8OiMtEcuVcJt0TmxfrMdSTeALxjyiOWDHNk58GDM7DrFECz1SRGJ9yuupLt+vrxjyjRNI/H2kWJkaq7IjMsV2Sany5z7YSAook ZB5q5dII SePRFmIuAn1RUBrP8wByKxH2jqKFzAWDVrTZMufc2HrziGpgkolM3YVmOuUPPeZJu8JdCS2b10CxXMgv7kUxnV3EkZNYHq69uNLQYeC86KzPbGjkZKG5O9Eqx63tSoo4e8f95nUyTNZrSub09iTIircdEIXG+2O6JCmYm+MgYbFj+BV/e3D/2ThbMV/b+VokGLcI2q2S66H9+7SswXR6hhzGKuBO3nKLeK1091wTwITywLWSCfntegHiBW4KgGZzLZUTxx86dnOxTEj/yTsmXjAyX/KpioaFDiXodK2VM3lu4VL698iiLAKKtK+Prptsd+HIo+EvIIwFnnfZDdzf9lY1eSWBtrgUEYBkomnPPu1ghtiEENhUgklkr8Fr3BjuBjKew0or0IDDF8P2OQLMNoP7IpLgHn6Bqh4o4fBOeUTT7PqgmQU+s8OdOgrVeQdG/YtJ7L/rOYl0YA1o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --i5my2ttbkie4uhcf Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v4 1/5] cgroup: move rstat base stat objects into their own struct MIME-Version: 1.0 On Thu, Apr 03, 2025 at 06:10:46PM -0700, JP Kobryn wrote: > --- a/kernel/cgroup/rstat.c > +++ b/kernel/cgroup/rstat.c =2E.. > @@ -351,12 +357,22 @@ int cgroup_rstat_init(struct cgroup *cgrp) > return -ENOMEM; > } > =20 > + if (!cgrp->rstat_base_cpu) { > + cgrp->rstat_base_cpu =3D alloc_percpu(struct cgroup_rstat_base_cpu); > + if (!cgrp->rstat_cpu) { > + free_percpu(cgrp->rstat_cpu); > + return -ENOMEM; > + } > + } This looks like it should check if (!cgrp->rstat_base_cpu) { But nvm, it's replaced/fixed in patch 4/5. Michal --i5my2ttbkie4uhcf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTd6mfF2PbEZnpdoAkt3Wney77BSQUCZ/6UVwAKCRAt3Wney77B SYlGAQDN59bNOgh3eUYfSAZkYjq9pZ6kNuNOcEZ96/iQtFJg/wD7BhiEuWiiIc+l DgGbik0SSOQr1w67+SLei+kAJNFSqAs= =xv68 -----END PGP SIGNATURE----- --i5my2ttbkie4uhcf--