From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BA4CD6B6DA for ; Wed, 30 Oct 2024 21:56:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0FCFD6B0099; Wed, 30 Oct 2024 17:56:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0AC2A6B009A; Wed, 30 Oct 2024 17:56:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB5BF6B009B; Wed, 30 Oct 2024 17:56:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CA8AD6B0099 for ; Wed, 30 Oct 2024 17:56:34 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7B2E41C6F5A for ; Wed, 30 Oct 2024 21:56:34 +0000 (UTC) X-FDA: 82731627006.03.28CE087 Received: from out-177.mta1.migadu.com (out-177.mta1.migadu.com [95.215.58.177]) by imf03.hostedemail.com (Postfix) with ESMTP id 566082000C for ; Wed, 30 Oct 2024 21:56:20 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=k5YZxKoV; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf03.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.177 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730325348; a=rsa-sha256; cv=none; b=B4z2y9UFyrup137jgKwGRIjRsrkGZ2LXROMi8mk1ptCdOd3GB2r6xZIlQT92wJ5pOXI2cX Np2gBZsbCUfXy6UMb2+XcxomraeKtWFoZni2onOplK+jzevFwDVkqGdGL5kusI9FkjNdFk TwmZNymx8nKRU7XTHfu/s31qJt6s5OU= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=k5YZxKoV; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf03.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.177 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730325348; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8VUlfA7tM1TVV6uo3if3+lGHhFVUrXdrLThYsxW6fYg=; b=deYuLtxjwH8fqXRb7Lbd+6uQOfXC3u1EejeSmSdaeA3gg9xTb7ppWxVakTi/VjZwpI/iVZ xxaEABSanP5HqdC/FhowutfH8rQoz69BF6Tc2JS3lzXnY7xgQgPyZPbW+eAhV6lvWM4LA3 YBo0WhfQ/INdV9pq0eyF5VlrqGZySlM= Date: Wed, 30 Oct 2024 14:56:24 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1730325390; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8VUlfA7tM1TVV6uo3if3+lGHhFVUrXdrLThYsxW6fYg=; b=k5YZxKoVHwq3/JXsudymmK6M5Z46e94WXOQ+cqfAhNFbUl7vl97TSqgjoHzApfq29wHm5c yT3kz4bNAaL2Z9OO/Ea2AjLw0ZtQD9OoKefL2vZApowcK/nvwUKs4IKnI8rVvytIYnUAAR D2k9MIOpAsExKAvG8mKGj2v2+XUkjgQ= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Joanne Koong Cc: Bernd Schubert , Jingbo Xu , Miklos Szeredi , linux-fsdevel@vger.kernel.org, josef@toxicpanda.com, hannes@cmpxchg.org, linux-mm@kvack.org, kernel-team@meta.com Subject: Re: [PATCH v2 2/2] fuse: remove tmp folio for writebacks and internal rb tree Message-ID: References: <3e4ff496-f2ed-42ef-9f1a-405f32aa1c8c@linux.alibaba.com> <0c3e6a4c-b04e-4af7-ae85-a69180d25744@fastmail.fm> <023c4bab-0eb6-45c5-9a42-d8fda0abec02@fastmail.fm> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: gmd13s9fdzyxt941yp9t6qzmk5udp75z X-Rspamd-Queue-Id: 566082000C X-Rspamd-Server: rspam02 X-HE-Tag: 1730325380-210579 X-HE-Meta: U2FsdGVkX19U7DBTa9a5vg6iSg6HtlAsdWXRFOzze+o/36fbCnGO0WIvq9fVlLFDJDKhQ/P091r/jTNxA/AFRU0P1dWtq4wQc5xXOjGTVifySs1pypWm6/u5LRNHPSk5Wz7VCFuLJ9XMdJ+XZZOKIzzlTUBcC3pweLUafn1wggQAJhoV5UTjhPP2VucQ1jM53cuGizxMOm9vOnnnLhAggomP6rG/gN4AlZ1YScCB75k42Cy+CIoiQJN9MwvONPfrHalD6E1TVrCIhRXZEMadnRNpynnnzsrpNMKdUabQUVVeB+UJSqEVbiMY9RHXMSoTnlNRDe+BciRN22rv8G0J+rH6VhaC5FnyWevsfE16NiFSNZ1uIc/rcl736by7crQ/zX7SfQQKFq+AG11SrMw1f4J33OJ/ThWRjTct6k+n5i8WxZ68Oa2b/co086Mt1ugT1VNIlUo7H/4+4UqFu8M5pgByyLJDLFPNGLwZKWpD7wFnTJJjojMMvxyaJldJApagnIRmsd1rHtMBS8MBjMfnbTsV3bGChIbgIbzD6V6nZQPrJ+oVAW6xQl1c/14yzGJuAMheKxYGGlkPA5rjrC9o3zhVyi1pQdlqgHJ/M+/8xyXd43wEaGPc8DrMKwjqIC2HySG5TRlIIGCeFzGJ1D/ki4YbVmbxkNgFRcpFgQBV1sNpYLVwn+l0kWjGOqPPE+vsd0eyQgaxAvU0LnLS3CaC1yJodZBy4cAURrPu0nPOKc0Hv88P7DERHJitSrCATCbY60slls+aAbm9/xqDtQhS6UCqEfRhLDRjbiT6F8kfSVCmJtlQXWq3ZhdaC0oMskPK8nxIfDQkGb5P7kSzeTK7N5GSINqzpbTljP8RvNEdEcLNeVHwFGEtiUaDf6SHWWEyNz4VL3BJCXi/tEmS+8YEYNxeAH8IJoXnltDFHndjuDweb4DptxYc+LuCNuyiD6RpNAesuupLKu3KkkZyMzY VQYIvDPB ey0SgM67SQaSQHjCkO7UZjEr2Pc3umpmJHnPP6ulo8mhffL7h6serUQ0PtY4ecYVSeBFfWB3qnH5SWcSSwxeJfFZUuaOLR4F5wq73358jP2XzjJAeJNSDitpQJQkiTfbfCWvUYBs8L+vlfdE9cDu4+ZWniqkWKhSVSpDcBKrGJnS9dIk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000010, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 30, 2024 at 10:35:47AM GMT, Joanne Koong wrote: > On Wed, Oct 30, 2024 at 10:27 AM Bernd Schubert > wrote: > > > > > > Hmm, if tmp pages can be compacted, isn't that a problem for splice? > > I.e. I don't understand what the difference between tmp page and > > write-back page for migration. > > > > That's a great question! I have no idea how compaction works for pages > being used in splice. Shakeel, do you know the answer to this? > Sorry for the late response. I still have to go through other unanswered questions but let me answer this one quickly. From the way the tmp pages are allocated, it does not seem like they are movable and thus are not target for migration/compaction. The page with the writeback bit set is actually just a user memory page cache which is moveable but due to, at the moment, under writeback it temporarily becomes unmovable to not cause corruption. Shakeel