From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C098C76196 for ; Tue, 11 Apr 2023 12:53:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 883406B0074; Tue, 11 Apr 2023 08:53:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 831E26B0075; Tue, 11 Apr 2023 08:53:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F9696B0078; Tue, 11 Apr 2023 08:53:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5D6656B0074 for ; Tue, 11 Apr 2023 08:53:25 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 32C62160641 for ; Tue, 11 Apr 2023 12:53:25 +0000 (UTC) X-FDA: 80669101170.07.4E2E132 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf26.hostedemail.com (Postfix) with ESMTP id 4C5D014001B for ; Tue, 11 Apr 2023 12:53:23 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=ajgGNA5W; spf=pass (imf26.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681217603; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EkSlnfLVrBuvRIjHTj4YkNGB03MrlcmP9bduCieRg3g=; b=hckh8aEZo69K2AJaYSbo4QsGHBhnVsU8o+l4V+tXr30v80SNLPwqsuEP3UjcOzpZ0ynIwz l3xXgoI/jQrq064qHjYOxl0o5hcQKIaTw1W68CIx8xGP3Rw/sY2dZr3iVpM+VNpGWsU3TA 4V2z1R3f/IWtD/NcBVuQnYMU2z09+ec= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=ajgGNA5W; spf=pass (imf26.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681217603; a=rsa-sha256; cv=none; b=GfsLlUiAfH5NLVoX4CHL86yLAUkjs35n1BLzZdwgSItYc9FrCpvgLGRIOzrs2cCkoy5ySj QEQdZy2uh8ugIdg9Pch8LFpgswNbdlXTot20CC8g5g7Y6I3h4Vu2pTXA4BF+p8U/bvAfkz GRCRPbjka0/LrULJtLmHmu4WolbT+Ks= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DF48E1FD6A; Tue, 11 Apr 2023 12:53:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1681217601; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EkSlnfLVrBuvRIjHTj4YkNGB03MrlcmP9bduCieRg3g=; b=ajgGNA5WZlfmxWLIlPe/Fpt1PDYRI4impchyX4YLBiQwzNnLCAlHV9BMmxRWvfKCM5FFn3 /u7FPMnBH9I30kLtg7c7jl5pJXsA9xlGV25vO6RWpBXBbAJdu/lpXaOrPHxT+3GRwna4T4 F81VTw+DSswzCM0ouu3Dmz/5JqJuNLI= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A7BB713638; Tue, 11 Apr 2023 12:53:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id QXQoKEFYNWR0IQAAMHmgww (envelope-from ); Tue, 11 Apr 2023 12:53:21 +0000 Date: Tue, 11 Apr 2023 14:53:20 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Yosry Ahmed Cc: Alexander Viro , Christian Brauner , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH mm-unstable RFC 3/5] memcg: calculate root usage from global state Message-ID: References: <20230403220337.443510-1-yosryahmed@google.com> <20230403220337.443510-4-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="eqj63t727ravqnne" Content-Disposition: inline In-Reply-To: <20230403220337.443510-4-yosryahmed@google.com> X-Rspamd-Queue-Id: 4C5D014001B X-Stat-Signature: k8cw48u9wymjgodqabigyym78aoossr1 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1681217603-982743 X-HE-Meta: U2FsdGVkX18YUTWMW/IWk9C9NBfWZnUg+jLpGb/8KYTwFphl7OwbvuUG3+hhKLDMT9umyzFSc3e0HizeEVdtVhI9c7uHsNJjzC2ksRYCi5s8bCoG2Br0lxN6+3CNjY7b+FDZSbbAgahcVuLErvIcSSov+K/wbnnQDWvbfsQguBuNFOAs+eFAwbiAi17R40m0LMeqHUaD+DxbbO39v8G6bqPrVV9RmpTlCMtlsDbhkUz73WW9mQVlx3ZF59Da0MOvC715OeiViTKtipMKCGJIsXc8n63nf6e1v5i+CMRpBANFV/rn/BxNs06F6NxmCeD9OAzQ83/MNoeIsPzTSUOlsvwWxnNn8Dn+fgq57KDWSlPyoKsBVE3aLhdBkcHDvH2ZJ46D+0IJ+SkOtz1oQo6PJgRd6TD+9LPxVUlNDv1L2HH5+QZ+8vZ4WFjzt+OBGdawFLMG3N7PNhZ8S4wBZhIkD3LgQtvtGHf+6dN3sHoDnMgoxS9APePEGIdkibGoVp2DSIEHlDV5zbOZzqwiwV9nf8LnqvhaOC+n3zQZDwmwVFBtFyv8o+v4SM+M0fgAor7hQOi4vu1oh/8iiIjZ5wGjP4/rOI5LDojOw95v1WgY1+LS6zhLCqymmE+BdDFSw0HODWAgl0cvoTHRFOxG9pU0ldRmBuzXYhlvbtVO34fsbEJae5+hpBN9BQ49jR0TFfV/Risy5FZq9DNtL6/u5G00hJUTvcwSmKsRQwFti7+aXQ7GTl+IPKG0odzun2GP15o5Ypkbi+eFbDCX9JCUFkfpxYMnxeSGCpqVcnKYwvUpmpU27JENYOUK9XnGJFVlMCp9dfmRNe7d76ewp1XYu0HmC5GRrV5cWlxtUNdIcZjEuyTkgQ7JGhJaCox6VtE/hKsnWwxsroPW7Afv5WhDI9PbjPM1L04zwCOtHY0Tf+/yyKJf5EWrZCP9jHnGAWQnqaZqwr1hVxsOQztIEQzz2Bg 5E7sebXI XEUFoKpbRJbqqkcwcqwim53jvGS8I0ujCblyI5SXI763jiRgkqP59+P5RV9jcpTD5vRqc6ffWM9NdgVzBLgULPBJJ20Zras5K8ASjITLzFnys083pCCWhfp71ZqJuG8L2kB56hP7rAQteEOsrHBmDVu5cuXlBS3sQ/yQniT7uOblTT9sbnO/Ws6lqDH9cqEhrQ2Byfg839Vh06W9ZV3/4RTgGSsRSG4QFy4CNdTyj4aBJRnVirxXW2Uy1uC88myRMEG68688s+cIacqFPtf8qB8P7wTYzllA7A5fphYYXeUMm+LQyAWKLGlMeSH8FTNteSnwTIz3Fp1LbuYVdzvZnnOm+csiIgl8q7cNDwDU3/YzoJk81y10Kp+7bEWY5cKeHJ8m1+zPgXwPfzApweYlF9WBJsVBePzd9zDOd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --eqj63t727ravqnne Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 03, 2023 at 10:03:35PM +0000, Yosry Ahmed wrote: > Instead, approximate the root usage from global state. This is not 100% > accurate, but the root usage has always been ill-defined anyway. Technically, this approximation should be closer to truth because global counters aren't subject to flushing "delay". >=20 > Signed-off-by: Yosry Ahmed > --- > mm/memcontrol.c | 24 +++++------------------- > 1 file changed, 5 insertions(+), 19 deletions(-) But feel free to add Reviewed-by: Michal Koutn=FD --eqj63t727ravqnne Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTrXXag4J0QvXXBmkMkDQmsBEOquQUCZDVYOgAKCRAkDQmsBEOq ua0bAP9/m5FltliE3jipY2X5GBKY+6HwLMPDQ7kZw0YMt1coPwEAhI5ND5ReXLBV +llW9zWanuFkJ28pU6DrJah5+c1hBQ8= =0lKn -----END PGP SIGNATURE----- --eqj63t727ravqnne--