From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FEF8C4332F for ; Mon, 11 Dec 2023 23:35:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A918E6B0253; Mon, 11 Dec 2023 18:35:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A416B6B0254; Mon, 11 Dec 2023 18:35:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E1F46B0255; Mon, 11 Dec 2023 18:35:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7F5896B0253 for ; Mon, 11 Dec 2023 18:35:24 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 521FA120578 for ; Mon, 11 Dec 2023 23:35:24 +0000 (UTC) X-FDA: 81556146168.16.AFB5ABA Received: from postout1.mail.lrz.de (postout1.mail.lrz.de [129.187.255.137]) by imf10.hostedemail.com (Postfix) with ESMTP id CC055C0025 for ; Mon, 11 Dec 2023 23:35:21 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=tum.de header.s=tu-postout21 header.b=XT23O3A2; spf=pass (imf10.hostedemail.com: domain of paul.heidekrueger@tum.de designates 129.187.255.137 as permitted sender) smtp.mailfrom=paul.heidekrueger@tum.de; dmarc=pass (policy=none) header.from=tum.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702337722; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8idFFu0L0dXkH2zjSo0W/AcVqktD9byVatdWxcpkJGc=; b=yeiqgAwKaNAi5aOAUrE7CoYiZo6F1Ah3mQ8uO5gQkLe1iI5/tcCY6Ww6jUZ1ahduCJ5XOO L7rkWjzT2aTVo7+JQdi5ZlavYLBvi1B7GBDhAShmdXtVFp4hnVsXRz6pSp4PWGwPWJPuD8 Q3zWPUb4StkGc+563TXuYec/FA2tdTc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702337722; a=rsa-sha256; cv=none; b=lnlEirVuo9jMUD6AwJSCUzZ0eiPjY22BMaHJDHeJOwZ2O3Thil51KVtfB4C76MBw0Lr3mp NXzyzn3HzwhwL8FUkHaZ+eKdDelOtm8u9thssr8s0kgg5NedTz4OZuO0U+ZAJTabXqyDeP 8Qk3g9DJZyBq7GrVEY5vZRnXm8ofp5w= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=tum.de header.s=tu-postout21 header.b=XT23O3A2; spf=pass (imf10.hostedemail.com: domain of paul.heidekrueger@tum.de designates 129.187.255.137 as permitted sender) smtp.mailfrom=paul.heidekrueger@tum.de; dmarc=pass (policy=none) header.from=tum.de Received: from lxmhs51.srv.lrz.de (localhost [127.0.0.1]) by postout1.mail.lrz.de (Postfix) with ESMTP id 4Spylm6qCGzyTp; Tue, 12 Dec 2023 00:35:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tum.de; h= in-reply-to:content-transfer-encoding:content-disposition :content-type:content-type:mime-version:references:message-id :subject:subject:from:from:date:date:received:received; s= tu-postout21; t=1702337716; bh=hk0tuevZEoLDrYcG31rsdQ9GPMxog11sQ YsjOeuOlI8=; b=XT23O3A2DE9rX1e2iLgAYb42zO3ksg2FiIQsZRad0HZCTwWC0 usp9rXYFgx2LzBIj0FHbpEZ9tghtY8gsUOpRJXyg1XOGEj1ewsA5/mZbhr9UICbS R1hRot9yXH014E2HSJ+E8Z54MctMgv1DYfZpwtPRlOe3md016seOEzGBCbJb5+/+ rPFDJr1IOXVYuhEtoDNjesPywHOtmrZ2GToQB/GCMz1uQxjnHAokeR8NZyun1KMr mmESRYe9oUus1hWPZEKgtkB7/dIlfLdw85Jr8oUBAPjV7CQ5KbYlq+je/IaESULf 01l+cY2MBiFO/w/aY2fHLeakCbonAP+KWLtqw== X-Virus-Scanned: by amavisd-new at lrz.de in lxmhs51.srv.lrz.de Received: from postout1.mail.lrz.de ([127.0.0.1]) by lxmhs51.srv.lrz.de (lxmhs51.srv.lrz.de [127.0.0.1]) (amavisd-new, port 20024) with LMTP id Cuu56KEaV5jm; Tue, 12 Dec 2023 00:35:16 +0100 (CET) Received: from cerulean.fritz.box (unknown [IPv6:2001:a61:245c:a01:443b:cc34:8ae7:6ede]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by postout1.mail.lrz.de (Postfix) with ESMTPSA id 4Spyll4BFKzyTb; Tue, 12 Dec 2023 00:35:15 +0100 (CET) Date: Tue, 12 Dec 2023 00:35:12 +0100 From: Paul =?utf-8?Q?Heidekr=C3=BCger?= To: Marco Elver Cc: Andrey Konovalov , Steven Rostedt , Peter Collingbourne , andrey.konovalov@linux.dev, Andrew Morton , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov , Masami Hiramatsu , linux-trace-kernel@vger.kernel.org, Nick Desaulniers Subject: Re: [PATCH v3 1/3] kasan: switch kunit tests to console tracepoints Message-ID: References: <20230215143306.2d563215@rorschach.local.home> <20230505095805.759153de@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: CC055C0025 X-Rspam-User: X-Stat-Signature: d1kzrdrsqc34w6iqag99ysdajkgz9ura X-Rspamd-Server: rspam03 X-HE-Tag: 1702337721-268831 X-HE-Meta: U2FsdGVkX1+amjZavxYTDJ5ekrpD9+Z6pExOUOf9kuu3AWBRFrLICXBa8mV2SgkXsQoSPuhV55nlC0GoJ0u7F5IYz4j6fB4k6N6GNCCcResdFMp9rQlAz8PWqqWEliAJ3Dge6vx7l1c6ZsSmR/u5gkttKRbKsvTgG9w/bM8OzwAuUv66JHVHUY2uxLMdo0NGS24Pd6YNX5oRh/aNbts+VZy+lKLy2L1DlCXCwQq0U+Rt16UXnVManhBeWS5k/vd09WU1gdikS1yVoiADbNlx2b/XeiFTtFxdoXJ3N/XedhKExecmkq6tUSZY/6xKy15PkhrcTypTjxBknTpxVMwyGwhAsZ7UzuTxueGPSqlbY8zbwS+woiPNMX4vl7jt8m9yyLdJ9b7rpFfG/tpNeakTgBl7rGFZ6R0ITasdcKB1tCMZSnOQwgxwKlA2VgZwYlMnfzaVyo8poPyCbz5uxvCCSvFnUdCxeoz+VR1xzhu59KZ9v3zIvAP5fsiETukG7plEXv/NB42CoYfAKYaCqZEEod1ndDbKQm7GKMZ5gcBvVJ+xmKn6qsYoCK9mwfa4j3+3ss5YbEuio7zWa8kq/t2OBMbmbqavF8NIMwkhKphhDXT+blSXiehEVHdNpVZ2ivg1nZLFm5cmAVL7ZOTCT0w72F31Ax2voyJOGddauKqPWS0zN9pmPa+KqCkxFGuVjCUIu+TKvejZ4SQ/aKrG7WuNeQuM4JVJMFdDJZK1yVHjBSZEH+sE/Qfuzihr+jKIfmr1eAJ+hPncEmQ5LlOZgrQfNqGwB+zSt6NyyJYjCZCgvqVNa0cwuRk0hIvoPJuZykzvYt5juARvuh7Iam0rH4ynDx3lBmECH3d48yghsf8ozTqek8yY3bvEgZ1jp2SZ6YcCOcp1AdZAuiCOFVaX8YVivHpocCabYAc1w9pv7aU+s5yeYKU6N8UptLxnwU6pTk1778NaR8dSoxNk5VPGas3 /e8W9LyJ Tq38h380aMbjURjbU+Ys1nL4R6DSiq0B4vityw9jDlyFkOx5hpfhs+TIch5gsFRx/BUOBOFjHEZXo/2xeBZWdwnr4/o2NVI44Y5l0k+e2vR+Y/e6uahVezlnsS3Qk1qCRxpPDQwBoiSHLwwARrMSiKmVpKCAIuNSwqDrDvKuUHVtQGuVpXKMErA22HC64kDEPThmio3FpD3xcVzYcZl1X+5AESzGYviqg9QNOun/iVd6pH99DNH7GZ8iZTKEbpywaXPxv8cNGZSr5/AjQEItDrUMOVyEtIKd2XgE2ohvSYk7p4Rc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000016, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.12.2023 23:56, Marco Elver wrote: > On Mon, 11 Dec 2023 at 23:48, Paul Heidekrüger wrote: > > > > On 11.12.2023 21:51, Andrey Konovalov wrote: > > > On Mon, Dec 11, 2023 at 7:59 PM Paul Heidekrüger > > > wrote: > > > > > > > > > Hi Paul, > > > > > > > > > > I've been successfully running KASAN tests with CONFIG_TRACEPOINTS > > > > > enabled on arm64 since this patch landed. > > > > > > > > Interesting ... > > > > > > > > > What happens when you try running the tests with .kunitconfig? Does > > > > > CONFIG_TRACEPOINTS or CONFIG_KASAN_KUNIT_TEST get disabled during > > > > > kernel building? > > > > > > > > Yes, exactly, that's what's happening. > > > > > > > > Here's the output kunit.py is giving me. I replaced CONFIG_DEBUG_KERNEL with > > > > CONFIG_TRACEPOINTS in my .kunitconfig. Otherwise, it's identical with the one I > > > > posted above. > > > > > > > > ➜ ./tools/testing/kunit/kunit.py run --kunitconfig=mm/kasan/.kunitconfig --arch=arm64 > > > > Configuring KUnit Kernel ... > > > > Regenerating .config ... > > > > Populating config with: > > > > $ make ARCH=arm64 O=.kunit olddefconfig > > > > ERROR:root:Not all Kconfig options selected in kunitconfig were in the generated .config. > > > > This is probably due to unsatisfied dependencies. > > > > Missing: CONFIG_KASAN_KUNIT_TEST=y, CONFIG_TRACEPOINTS=y > > > > > > > > Does CONFIG_TRACEPOINTS have some dependency I'm not seeing? I couldn't find a > > > > reason why it would get disabled, but I could definitely be wrong. > > > > > > Does your .kunitconfig include CONFIG_TRACEPOINTS=y? I don't see it in > > > the listing that you sent earlier. > > > > Yes. For the kunit.py output from my previous email, I replaced > > CONFIG_DEBUG_KERNEL=y with CONFIG_TRACEPOINTS=y. So, the .kunitconfig I used to > > produce the output above was: > > > > CONFIG_KUNIT=y > > CONFIG_KUNIT_ALL_TESTS=n > > CONFIG_TRACEPOINTS=y > > CONFIG_KASAN=y > > CONFIG_KASAN_GENERIC=y > > CONFIG_KASAN_KUNIT_TEST=y > > > > This more or less mirrors what mm/kfence/.kunitconfig is doing, which also isn't > > working on my side; kunit.py reports the same error. > > mm/kfence/.kunitconfig does CONFIG_FTRACE=y. TRACEPOINTS is not user > selectable. I don't think any of this has changed since the initial > discussion above, so CONFIG_FTRACE=y is still needed. Using CONFIG_FTRACE=y instead of CONFIG_TRACEPOINTS=y produces the same error for me. So CONFIG_KUNIT=y CONFIG_KUNIT_ALL_TESTS=n CONFIG_FTRACE=y CONFIG_KASAN=y CONFIG_KASAN_GENERIC=y CONFIG_KASAN_KUNIT_TEST=y produces ➜ ./tools/testing/kunit/kunit.py run --kunitconfig=mm/kasan/.kunitconfig --arch=arm64 Configuring KUnit Kernel ... Regenerating .config ... Populating config with: $ make ARCH=arm64 O=.kunit olddefconfig CC=clang ERROR:root:Not all Kconfig options selected in kunitconfig were in the generated .config. This is probably due to unsatisfied dependencies. Missing: CONFIG_KASAN_KUNIT_TEST=y By that error message, CONFIG_FTRACE appears to be present in the generated config, but CONFIG_KASAN_KUNIT_TEST still isn't. Presumably, CONFIG_KASAN_KUNIT_TEST is missing because of an unsatisfied dependency, which must be CONFIG_TRACEPOINTS, unless I'm missing something ... If I just generate an arm64 defconfig and select CONFIG_FTRACE=y, CONFIG_TRACEPOINTS=y shows up in my .config. So, maybe this is kunit.py-related then? Andrey, you said that the tests have been working for you; are you running them with kunit.py? Many thanks, Paul