From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD10ED0C60D for ; Fri, 25 Oct 2024 13:38:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2AE5D6B0095; Fri, 25 Oct 2024 09:38:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 25EE76B0096; Fri, 25 Oct 2024 09:38:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D7B86B0098; Fri, 25 Oct 2024 09:38:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DEB606B0095 for ; Fri, 25 Oct 2024 09:38:49 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7539C1A0B7F for ; Fri, 25 Oct 2024 13:38:14 +0000 (UTC) X-FDA: 82712229096.19.4B367BD Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf10.hostedemail.com (Postfix) with ESMTP id 7B465C001B for ; Fri, 25 Oct 2024 13:38:37 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=YYm4FpPJ; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=H3v2NXw2; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf10.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1729863400; a=rsa-sha256; cv=pass; b=RR6fk2yajQ2yWQV+LntmAiolxoctOhcoSd5kKGXYxIdB8OW/UTzsqdcYE7TXfu+cPCPF3G lbwcQ14y9cHjlVcQQP3pSvQ9p17AUhQEDZdgfUP8JeFZf5VqXQC6pFov/P0lqhwMwkYt4d m3sp9o1j261gLzVaRxlFCTDeoVkNXXU= ARC-Authentication-Results: i=2; imf10.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-11-20 header.b=YYm4FpPJ; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=H3v2NXw2; arc=pass ("microsoft.com:s=arcselector10001:i=1"); dmarc=pass (policy=reject) header.from=oracle.com; spf=pass (imf10.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729863400; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HZUPGouiHVw+o3OUu3U9lzbZ25BsUIV4aZ1kDzMqzK4=; b=QsXOhkEDSpR33ML0KI49u2PckzzAxPV6zHkGWeNVvsWRcURfFsnMTnM7oe5iSSFeb6JGyl hxmshFDxworoHhi0gshIqFk4Fnq/XMfpy0zGaBmw3vbo3V24vat15YsK2wjt2YVgXkwjWY Lv45pa2RD5rkTAKNr12cuISaklVUohE= Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49PCU2KH030374; Fri, 25 Oct 2024 13:38:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=corp-2023-11-20; bh=HZUPGouiHVw+o3OUu3 U9lzbZ25BsUIV4aZ1kDzMqzK4=; b=YYm4FpPJLQ/MbjqHtG5flbh8JFH1U3tAjz VSVwuXsmXlAPwOp+uDIcLADn9hM/wMgptTxUQUfT2pS0+3lp2If+3157kEVJq/S1 CUjXnFhgC+5wdbjQZmY8EThFp/If76LEq9juTRgFHpg7TzZUX2mEhCj5uFVLzKm5 UGgNMS7UR+CJfjhQERxyzOLIiVsHy+MQsYfinQBSBynUG/dS1ydkYQW7pczVqTEm C2YhOEu4Q1cKY3hZTG5uK7bv/Fwo8IYjAVLTGADRmq13wu/afU0AP9YfTqiLYJIb 7nYEerlSn4Ow+lHgJdCUK+sZXlkkDrhbNtqWwLCtBgVxk5Ta42FQ== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 42c55emuph-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 25 Oct 2024 13:38:33 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 49PC2CJW008699; Fri, 25 Oct 2024 13:38:33 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2042.outbound.protection.outlook.com [104.47.70.42]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 42g36aguq0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 25 Oct 2024 13:38:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HmN30vMNjngR+wtHn+jkU5K4hBJbPoNzv6P7RoevtTzwJZHea+jgDlMEOrFxvpbWTNHRV2Lz8axNSXF5h6dywn6LtKXU5e+FLRr1LO/55zkSUGujTIfEOoeMXu2Kf4E70YIUhleHl24iYB9k/+t9/7W8TjRV93TMSjfVUWSjuYVyVATDVNC2dw7mJZ1Q3J5RgdzyLw2XOXeb7FZ9LPokMobvw9MY/BDbt+/csmwqtO0yt3CTBt9Bt/HicpTmnPLbozeKtitbzQrM2BjKVWlI8qAOgEKPnvfinTxwG/rRIRT0xWockUscUJTVFIdHt4e2neRM8klCRFtqVmNtCSpD9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HZUPGouiHVw+o3OUu3U9lzbZ25BsUIV4aZ1kDzMqzK4=; b=W7O9clVqfL8hZdZ2SLmzU9PAFgaOw87gBG3JNdQAtcffyS5fJ/2LD19rmeTtjUy0So4zOWUOORxQRLj2DTFtDXSlFa6kdxOxrmI4fcC9WM9C42nQm08bToo4nVS4CV7Bmyn1qb4ts3zZJLtgQ3UjFQfoBc410hf4fRIfiyzMMEwQ7tNGV7r6pDgy7tNJnnHbsEMJdegaPt87qInaPiu3vt50hhLEgb0oOLMf9gxuCUHYYH+cPfNSGMAHIFRBxolRQ9mu/qLjdqwEl6HTOhKa7RR3jCbPs+8rtOvc5Bf8LHu9OPa+veF0N40gLvz6UBlIeVU5iv+65h+y/O1BrQxcPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HZUPGouiHVw+o3OUu3U9lzbZ25BsUIV4aZ1kDzMqzK4=; b=H3v2NXw2NINZykjLDppUTXs+lGVWfr4pBt3LerD3Bs58drRJtWMcBjbb0l4VNLXyd+VnBGNxxz3rAB2fS3i4FKuuxv3zrDTHjQZ+kxJw9g4DVX/C9lQHpo2RaUxktLlpCRZprbFjgCaz4Nt1kFW3p/1Ia4vASfGTe2NtlvnsY5Y= Received: from DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) by CY5PR10MB5962.namprd10.prod.outlook.com (2603:10b6:930:2d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.20; Fri, 25 Oct 2024 13:38:30 +0000 Received: from DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490]) by DS0PR10MB7933.namprd10.prod.outlook.com ([fe80::2561:85b0:ae8f:9490%7]) with mapi id 15.20.8093.014; Fri, 25 Oct 2024 13:38:30 +0000 Date: Fri, 25 Oct 2024 09:38:28 -0400 From: "Liam R. Howlett" To: Shawn Wang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com Subject: Re: [PATCH] sched/numa: Fix the potential null pointer dereference in task_numa_work() Message-ID: Mail-Followup-To: "Liam R. Howlett" , Shawn Wang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com References: <20241025022208.125527-1-shawnwang@linux.alibaba.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241025022208.125527-1-shawnwang@linux.alibaba.com> User-Agent: NeoMutt/20240425 X-ClientProxiedBy: YT1P288CA0026.CANP288.PROD.OUTLOOK.COM (2603:10b6:b01::39) To DS0PR10MB7933.namprd10.prod.outlook.com (2603:10b6:8:1b8::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR10MB7933:EE_|CY5PR10MB5962:EE_ X-MS-Office365-Filtering-Correlation-Id: f1dcdcc3-3789-4fe1-bb90-08dcf4fa5001 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?bEV7oARJERgxELbk5+XqN0e21ydOA9wAbN1STwo3b2w0WRXVWKniU6UkNTuw?= =?us-ascii?Q?Vs/z+yn6pUWnsn7ivxf/h3iNsLSKVFnLC2eJ8yvbrTbF5VDVWEhFfCpqz4n+?= =?us-ascii?Q?K94wDmp57Kvr7oRd0YgRYPFAzq09KHZh4lrSiOrYDCRmuDSOhnWnI2U0/VEz?= =?us-ascii?Q?AT3yMZW59os9ZCk5eF8qxb9ZoFT3bCUmfJMswCWow5XiojHtq7/8zt5iYf0p?= =?us-ascii?Q?HHxIrs/pij4xBXbAte5bIuTgGQSepPV+pdAgXxwR1gF4e37JA168+sHNnTBP?= =?us-ascii?Q?w5oEckl7U+l/xslr2yfxkjqRa4OQYWdq7XTvJW0VdTqRL6JH/GvPCOz/yB2j?= =?us-ascii?Q?woI6deO9RJemmjy30lMQEP7D8kJRgmmqibPgMGwQ1dgl53NK/SLdB/nUr4Bi?= =?us-ascii?Q?ghmJCK8ByCrS1rh82ZH36eQuuwlB6T8Qf5dtgFzIMuFON4udwUDv9qhf9x7G?= =?us-ascii?Q?yzs+f3MFXw+2fOO/1OUnjPUMm2l/o3nemJSap4AIt3a6dsITywDjtkdrEqKW?= =?us-ascii?Q?fEG9cNlLDUelDrkTtMwOnALM6IfnzWFgBMDewtE8zLXKG5LP1TqPcGgCVrn9?= =?us-ascii?Q?J8XID8u3ck4ARo6/j1B+6cBU6VGMFubBIzPeIyyG8ATW3nzJ6uc6aU1ix+up?= =?us-ascii?Q?DFVoQty2eEnpjPcGjQxaxJDAD9yxZH198j+jOFc4/Z+ozBoVofdMIzC5gv+X?= =?us-ascii?Q?zBj3HmPmW8i2Tqk0MdagHVB/ZbRsGnHgy11cgAUCUI52eD8u0m+4PUwVoCWO?= =?us-ascii?Q?gz2aYZUJk/75M4EJShzDt2AruzmfFa3CUwKfw3Lk+HSb86YTJcLIXu24EITk?= =?us-ascii?Q?maqKHmtShxfGSdkJISOacbggp62o1yT4QIfwQNDflqqjp7SiCZl5S2356NAu?= =?us-ascii?Q?t2MHq2VvUxlXlSJhdDFgvq1oC2fc7UFwXNs/v2wMpl88B2v9ay0Wn24fNdyO?= =?us-ascii?Q?lJ8EXR8VrlrdhtdX11skBcafNkcOPKNyrwGpFVYiiuKesviy6zvJQukHRhL2?= =?us-ascii?Q?3T3GFiMuQfLeRnFZma2B2NKpCuUwwd7JFBSR+aqlI9t8KLlYub2soVT9OZ9R?= =?us-ascii?Q?Y38Qp2dWfBNVVgoOuUUeIQcbtYFya1XDBqlLa7TqV+AzffmQc5PR5B8Xkzw2?= =?us-ascii?Q?IF1cTKEir9CnX6stn3MpESrbBdMxtqX82qVyhMfyMLhPCciUNS1SObDGIL60?= =?us-ascii?Q?bvIYE9MLmRdTMTS2ezpGTDfj5Pmu5N4ba6GhhhQkI7RV8JkWK6btDZ6lnrEk?= =?us-ascii?Q?L8nyQkbefyNisKldyF5pWkBumIsHC1bb03cvPCqk7A2IoVvNFvNV2jgV3GR2?= =?us-ascii?Q?qNZjqlXtUBzgP6tlQd7bWiFC?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR10MB7933.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?v6AdWk7+WxEl46ONhuunDyzQeSVZzNB+bjlXRQL8ZX05H+POym3ygeR5ouA/?= =?us-ascii?Q?/mssDdLxda0W4fm14ZXz8pLFSoLAEiIL4DiWIt+xzbAQvsvgQLoFbsYKB1PN?= =?us-ascii?Q?crIMHn0E3bxmihcrZ+jx/on3aUSU9zkBI7MyiNMFSHLjIayUVY/qLwXEfJbB?= =?us-ascii?Q?NGNf8tQVjlwn0UnjCbF0Uy72xkrOYRJ55rmn8GYUUxulNc8ZpU696LPzif1F?= =?us-ascii?Q?Lt+PRk5oNI0bkugV0Lw6IQOeZTSaXYP6d357bed3rpRdsKkc99drDYqucU1M?= =?us-ascii?Q?ck/nab0Ov2QJZiiGukqQb57tjmYzJK6lwAJkXaegFUovMw/q/Z1HCL9xj98o?= =?us-ascii?Q?ozUzaa/snMv4zDNcHQpYKtx+hhi5vCQcolyYN4jjMKleCk7BS/aJXOOr6+QA?= =?us-ascii?Q?lp2t/V4l/Sa9E058yZhwT4JW0vr0qbkqELi0SpM7jGqzUN4odRcNmGUgl+/W?= =?us-ascii?Q?pFVHfIBSDxr+FvQ/YAazv5B2rBIAHr+C5EOjPEk0CeyWLJwuGg3d7DgybR5w?= =?us-ascii?Q?2qL/f1IwGMY8vO/usjyoe17YvwtX1lpj8JqFDumyw7tj3Ago8egXU5Lm/xfC?= =?us-ascii?Q?DGO3Z4Wz+OTY0alnOADuyod/+acneID7fSQ/f6xmq92bVFPqFIJbAVi4H3A4?= =?us-ascii?Q?IdUxwyjs3S9c3eKy6Y1n6NgPlhFey1fjA2VtvyIPYN+gO/2n6j0SvNcYLOQL?= =?us-ascii?Q?HiH+MXz/0eucVOc0vb1LiZFb5Q6+LtcF+MpuJjNRCXy8rA58snweeAFloHXR?= =?us-ascii?Q?R1Eb6KVsnKLp4OycPfRPM1RB58SKccRsQUrxaNgTqL+TNCpdhAfQ+f1V/YIX?= =?us-ascii?Q?3FaMJTsMScd3GprdzWbVBygouYUhGvxwjPGSjoPOmODMPVY7732rwatWOsH/?= =?us-ascii?Q?NfW/Lp11RwCV1qxwvtrUEDHqJ5VcaLsewO9/dJfSwEsLhyGG9wFM5+F6QGw8?= =?us-ascii?Q?6cQmg5zM6hbfCW7cEZJfx2EhXaA3OKHaoeh5OWyGSo6GMGMkk36pITg7Dz29?= =?us-ascii?Q?dOw+UFikLEdAfXceEOTA28TJskEP7W+8v7LBM/8kxQtlH9IlKB+6sJzvDfvd?= =?us-ascii?Q?P5c1+mEdvAyR8unTiNUu8pUwIJaPXMPpXpWd3c/nO1sDHQwbDU4yiVBulAf2?= =?us-ascii?Q?hEpE3t/fxFIk/OXxaWiD++ny2WA+KhvfJhvMoRA9IHxVUjIkIth3xkNZGwGF?= =?us-ascii?Q?tZL9ZZ2XxSDChADAu2EVef7KwkqVf6r/t3HTsLIakiy3XiiGd0aJ4hFWAjXl?= =?us-ascii?Q?A7u+oiHx9d0T8BE0T4HhqKkJDY7RQU/P3ftKHa1l3LtbJgvhgaXrilqFOU0v?= =?us-ascii?Q?tjm2luFLvgUcaWclPLEDqPxgtP8v2f6M4UrY+5pfZGSNgqmNtctkD6Dx1NdG?= =?us-ascii?Q?0BW/aaGTEbbC/QufyPUj5sz8Ohqrw1RmzkZXtnPnj1tbyGOLInGSdpRhcCzy?= =?us-ascii?Q?b+V6G0qGn98hqHWxDnLIVSTEAUpz4KsVjIibbmq7ktBXh3p/scoyl/oDQW9l?= =?us-ascii?Q?yn+YjfTN4XMtJ9V53t6vBSTI18BbDO4HLbKlcE2PM9ORjkA1dUA9Z98p1f+l?= =?us-ascii?Q?/eZdZtOQaqUoWdJUu/4vjcWmqeAC3/zGL4h15dEy?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: MCzBzDc0koVAG+YOWT3MXN69FB2GWyZbtYenoiUR+8Lec/79yVMTjm8cJHB7AHn70bkYgfyvwsQfHvj5sUHeOYVUrDuVKr/GYDQpPECWHl64I89alZWSLIyCumprRSMp8GPIsnB9DDmysMTEtKP9JpI693K62eVEgjD4/zPuXA8AsL/vfsMSE7ARPF4StG/lS1MzMfmRIuXDbHODUbWDwguEz9E2pAVkOXCfCCiCurgyUHo8ePNXAlFblk9zxCsPHT1r8nQvNvtK2kCW3n6eISTy0lTuyCGizesF0xACeiAZna30md7GtVGg1r9/ygu7FEiX3/K9eyotK9zKZzYO2I6EP/mQ4jQILNCCjutioxnSD5WHFBcTylaUgHvC9/rtMAkU7oPUjlIcMT193QH1KJr9kZy7clmmESYmJQcA92qj7UYSMPdvM8VXiIaoNDdzeVeEgSq1GLcF9w880nbBKamfk0s6v5RP0qd+F8HVM7caAvx3eW/8eSxiUIRV20hzj+uNfjZGsFdat5WgpYLgbEGPP6B44ghelggmWZUssy2ilkGWU/iz0sJRs40+i5qjw7+w0zc0VXoS0xmz7uXaOd2t/psiz2Ch4qV8LwAafuI= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: f1dcdcc3-3789-4fe1-bb90-08dcf4fa5001 X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2024 13:38:30.2415 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8WGIhjoEIa581oOhqygJ9U6Rq9xfJeDqToe1kF/Urej5DWuf+L6Q3nn/z4sYnWvrDbsIX/BlIQdyRKTslJtPKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB5962 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-25_12,2024-10-25_02,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0 malwarescore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2410250105 X-Proofpoint-ORIG-GUID: i62T-9mx3_3oN2N7R3fKFj3bIMUS2tfE X-Proofpoint-GUID: i62T-9mx3_3oN2N7R3fKFj3bIMUS2tfE X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 7B465C001B X-Stat-Signature: e7xpbje4efeqy5d8nsufcrnojtghpdft X-Rspam-User: X-HE-Tag: 1729863517-119673 X-HE-Meta: U2FsdGVkX19UD8x6iSws2zhBqJvhUI41WvHoR3VxygdBKFUhuyFFx9Sgy/aFoTF/xGDn49oxO6E/9T3ASmdBY7OJCmtx0ZHRmL3k3WMXMiO5Ah+BOc3jarJx+VjkwlF9zCX/x8n2SHpkucpk9GvCqfRRJplCugkSXPCYKL+EwSAyUbUpIK/pk+zWMDPG8sXY3w95EYguYTtTPHeUNiBVUj2eJ5669hWeIMaB2TiVo0qxJRDR9aILWEZnojWka4NdA6B2RwU0aFdIylOhDuXPiuMz9Cgy3C7Ffitu4R1sR6gpWHkkOgyOTq3/XYe7ch9BXduawFqOtHS3kjsCUKHijFX/V7ez+sQ+31jGmpq/DHra521P9ndZs+h2IWXlbZHxuuwYPGVhBmM/r1A6b2iNtA63p/a30DMdRgpgFVYfeQWs8ZIkgFuQ+aEvyl3nF6j8YLosgh3exi0x4XhUyUfkm5aHfmOCq8kaO1qBCDvC5RykxIAGsNKcmSoEwfq9stt2hgAoCCSjYi2DkBhKWhlLRYmz/Xf7fBXw5B3uDDHqXI9Yn5XQl/3nsVtNf3DOIfHIzQjidlDohIfPBA5FC+9H+jJmfhymfbUgW3CsV76Cy1QOJTyTqF4Do/4ZwfeR2nwvTbSFuNfAttbL6+ABC/lCDeseUFC2sopj243ov7k/tWXa5GBjlB8noNMcMi8SBYMrOLi4M9sstDeK4jIPKVn/uepMIAwK/PNvKZQo6BWO8m+u7f/TCDOoJvnxvIpul6ytcRxyx6se6/Wqv/NI4kKkkcH4rYcPdD30wG+snfBp1++XQy/8kl0zsGFKlEaUkz4Lqe3XCSJemQ+xNWOLeCsunlL8H+GSzB2NpAzaWiphw4CEtt1B2eL3kkh9rhHfwNUFpg5EYdMjmwAquGGbYUJ9LwmzR6wcB3vA6pLI4xYLKYNj9DQB4YlE2+EwIlvuUF8QlRk9ykMBfGWLWGRGdnD cm7dGKI6 dvgUgYbXfyjtygc3PMHd2TRxHBqIGgfpJR/xpvmjqzjNS7YnrpESC4qmddgyOjqbwiT4lI0dO4AHVdFylfxefEAgcN4B10fSUJINXpGCHI7d6WG0gLkzCXSGfiM4MifPRoRl9iS5m8w39G9h+J7iy+3eLZNxH6+ktZimUTjX9aDFK+qgkzCVCdR9XRrY4R8fAYjR7o4mNIpHgC33PXirlGUCKunCEDKIAC5FRVSSeeogFjJwiBq1Y2s6rPKqUZ3RVSJFFP/H4X9GJ3apZHxgMbBXJK/DrC2+Z0xEMk+1OZ4pNUHQlvnra7e7tS2SRH6RYSP53kVLRJ8D598P+kbzE8X4KtgOB1fO3SV+uMpi5b7Q0hdxVj9/OHIYlmvclctmXOLfULWRiuLDVGbgdE2RShTFkNMzx48AasVX6l/FPGcaSqtX0ZM3gR5q+a50alpGjFTaKMLhhr/pJ8Q3WlSLHJVq5ozlkw9EzXn/AwLI3pjoa3T6DPdNDnNFRLifOSh9cvhuYPnz00X4thnujRxGQtZaoPz3qdNnVg1zWYLbHbWTBtt/5obiQvifLWpxMwEym4d1Az4NfFNRaOG7161FOUSIgMu+57hLTAZqFf5z6HWUMhe4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Shawn Wang [241024 22:22]: > When running stress-ng-vm-segv test, we found a null pointer dereference > error in task_numa_work(). Here is the backtrace: > > [323676.066985] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000020 > ...... > [323676.067108] CPU: 35 PID: 2694524 Comm: stress-ng-vm-se > ...... > [323676.067113] pstate: 23401009 (nzCv daif +PAN -UAO +TCO +DIT +SSBS BTYPE=--) > [323676.067115] pc : vma_migratable+0x1c/0xd0 > [323676.067122] lr : task_numa_work+0x1ec/0x4e0 > [323676.067127] sp : ffff8000ada73d20 > [323676.067128] x29: ffff8000ada73d20 x28: 0000000000000000 x27: 000000003e89f010 > [323676.067130] x26: 0000000000080000 x25: ffff800081b5c0d8 x24: ffff800081b27000 > [323676.067133] x23: 0000000000010000 x22: 0000000104d18cc0 x21: ffff0009f7158000 > [323676.067135] x20: 0000000000000000 x19: 0000000000000000 x18: ffff8000ada73db8 > [323676.067138] x17: 0001400000000000 x16: ffff800080df40b0 x15: 0000000000000035 > [323676.067140] x14: ffff8000ada73cc8 x13: 1fffe0017cc72001 x12: ffff8000ada73cc8 > [323676.067142] x11: ffff80008001160c x10: ffff000be639000c x9 : ffff8000800f4ba4 > [323676.067145] x8 : ffff000810375000 x7 : ffff8000ada73974 x6 : 0000000000000001 > [323676.067147] x5 : 0068000b33e26707 x4 : 0000000000000001 x3 : ffff0009f7158000 > [323676.067149] x2 : 0000000000000041 x1 : 0000000000004400 x0 : 0000000000000000 > [323676.067152] Call trace: > [323676.067153] vma_migratable+0x1c/0xd0 > [323676.067155] task_numa_work+0x1ec/0x4e0 > [323676.067157] task_work_run+0x78/0xd8 > [323676.067161] do_notify_resume+0x1ec/0x290 > [323676.067163] el0_svc+0x150/0x160 > [323676.067167] el0t_64_sync_handler+0xf8/0x128 > [323676.067170] el0t_64_sync+0x17c/0x180 > [323676.067173] Code: d2888001 910003fd f9000bf3 aa0003f3 (f9401000) > [323676.067177] SMP: stopping secondary CPUs > [323676.070184] Starting crashdump kernel... > > stress-ng-vm-segv in stress-ng is used to stress test the SIGSEGV error > handling function of the system, which tries to cause a SIGSEGV error on > return from unmapping the whole address space of the child process. > > Normally this program will not cause kernel crashes. But before the > munmap system call returns to user mode, a potential task_numa_work() > for numa balancing could be added and executed. In this scenario, since the > child process has no vma after munmap, the vma_next() in task_numa_work() > will return a null pointer even if the vma iterator restarts from 0. > > Recheck the vma pointer before dereferencing it in task_numa_work(). > > Fixes: 214dbc428137 ("sched: convert to vma iterator") > Cc: stable@vger.kernel.org # v6.2+ > Signed-off-by: Shawn Wang Reviewed-by: Liam R. Howlett > --- > kernel/sched/fair.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index c157d4860a3b..b4c3277cd563 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -3369,7 +3369,7 @@ static void task_numa_work(struct callback_head *work) > vma = vma_next(&vmi); > } > > - do { > + for (; vma; vma = vma_next(&vmi)) { > if (!vma_migratable(vma) || !vma_policy_mof(vma) || > is_vm_hugetlb_page(vma) || (vma->vm_flags & VM_MIXEDMAP)) { > trace_sched_skip_vma_numa(mm, vma, NUMAB_SKIP_UNSUITABLE); > @@ -3491,7 +3491,7 @@ static void task_numa_work(struct callback_head *work) > */ > if (vma_pids_forced) > break; > - } for_each_vma(vmi, vma); > + } > > /* > * If no VMAs are remaining and VMAs were skipped due to the PID > -- > 2.43.5 > >