From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6282C3ABB0 for ; Mon, 5 May 2025 08:49:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 481206B008A; Mon, 5 May 2025 04:49:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4304F6B008C; Mon, 5 May 2025 04:49:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F83B6B0092; Mon, 5 May 2025 04:49:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 114796B008A for ; Mon, 5 May 2025 04:49:28 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7A8491C8FFB for ; Mon, 5 May 2025 08:49:27 +0000 (UTC) X-FDA: 83408230374.05.47CA0B4 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf10.hostedemail.com (Postfix) with ESMTP id DC84BC0006 for ; Mon, 5 May 2025 08:49:24 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=AM8EToKs; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=LRT7Pp8w; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=STeDkduy; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=k+AQHZoO; dmarc=none; spf=pass (imf10.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746434965; a=rsa-sha256; cv=none; b=2jQaZSB6NBqAWiKJ+++J6ovFIf3045xX/PnvLtRI46FNcXA7Nj4Gfm9WYyRtMAdiBss++X MHQPJP8bykVUyx+tw1f6Cxxt2IN0m30SWkTupqTiHOw3wFN29AxrStc4o4wZwBHvI2ruND JZRbSdoNUEySw72b8lJUh6BabgCHukE= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=AM8EToKs; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=LRT7Pp8w; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=STeDkduy; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=k+AQHZoO; dmarc=none; spf=pass (imf10.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746434965; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FY/d0FTareElI5ojAGucw4B8fFGBumNl/AF4B3106Qc=; b=HZ+az+A2gSDBZ0NBYSCRTQ8HwJQ16bvG4yWsBmJe242lFzUJiTnwMellpQAuW1SKzdl9Vc ZY/oA2/yVHgx2Na1hUSLJ1XpcX6BENUnEPlPSU90jjMTCYGPMdC8i6y9bBKpDoHJy3vV07 XbxUw/Rf+kkoFLbo0HPGBEDgG/C4CS4= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EC12221291; Mon, 5 May 2025 08:49:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1746434963; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FY/d0FTareElI5ojAGucw4B8fFGBumNl/AF4B3106Qc=; b=AM8EToKsH0MwK9Vt1LrWdXyWBDZS8IqBXLg/EwWaARxncsS0xGLhXAZQflp+mmkxT1z9Zr Iv82u4zgSvJ59Ynay4f2IU6FxexEY3pVfB8POcJcNS6aFqUw4OsgYBqQbXBN9xAMLsTeoL 7p6Lmb75pMH2kt5t8bvJIRrgSO5E/Ts= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1746434963; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FY/d0FTareElI5ojAGucw4B8fFGBumNl/AF4B3106Qc=; b=LRT7Pp8wsk3ajIbZ9ALH3p2tfITHVg8Ta2uPe+jSR3SNyGGjPXwXAIlWfDySSaiqFC9qmQ WvuIJNKZ5Nqiy9Bg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1746434962; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FY/d0FTareElI5ojAGucw4B8fFGBumNl/AF4B3106Qc=; b=STeDkduyhkyQ263oplCmstFe759d0Q+npT/2tCbyNWrkEij9rYKPCHoN25HljYaqFHFeNE InIKCGU37rB05gbQvX4YvvrYJMybkJnA70qzLI5eb77Caae4PtfWYO8GB5i/5TYpFpels5 ojZUrmUyXkS/O0I2np597bfFvGqAwMo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1746434962; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FY/d0FTareElI5ojAGucw4B8fFGBumNl/AF4B3106Qc=; b=k+AQHZoONj1yHOhQ0/GlEmqBxEPoihlaQucbermViajGEmDN7PKyEt2+xclYaT45C6X+so blbaqKuTs5QsxWCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id DAFE21372E; Mon, 5 May 2025 08:49:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id V2BxNZJ7GGjYYAAAD6G6ig (envelope-from ); Mon, 05 May 2025 08:49:22 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 3A0C0A082A; Mon, 5 May 2025 10:49:22 +0200 (CEST) Date: Mon, 5 May 2025 10:49:22 +0200 From: Jan Kara To: Ryan Roberts Cc: Andrew Morton , "Matthew Wilcox (Oracle)" , Alexander Viro , Christian Brauner , Jan Kara , David Hildenbrand , Dave Chinner , Catalin Marinas , Will Deacon , Kalesh Singh , Zi Yan , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH v4 1/5] mm/readahead: Honour new_order in page_cache_ra_order() Message-ID: References: <20250430145920.3748738-1-ryan.roberts@arm.com> <20250430145920.3748738-2-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250430145920.3748738-2-ryan.roberts@arm.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: DC84BC0006 X-Stat-Signature: xjzmakb1rseri5ut8jtej6ce6ejz7hg6 X-HE-Tag: 1746434964-585425 X-HE-Meta: U2FsdGVkX1/U49FrjzUze+eM8cJ1phYNlJOu+6bfFTnfzYKkK69gDRAO0kPBPgda8EoLztLWf+zV6mg6om7lx1jkXlUGzLq6ySz3NQ42wLqi6iuGW65Wf4RyM2kXy8aHNK1M4LdcyHeiHhDEFoqov6B2ivPvTqheSkkefNUzLo2t947/yYZZRu0Zf3tOhc9L5zs3s2OoF2WEhGhN/eDxScS9VOKL09pN9lpN3dT5B1iqRk+CnF42IlVtWIE00QertHWMUg1og5ZB3QmqtmIBJXHhf74b+KZxHM6kjh+KHJHAAsO9pZakZtND1TGveFGtSJlhB4WElao0jGMxowIwepUkABQ2xuBSv9zUPknBWTHey11A3Q9rFpQTdwD8/OhzUcMtQ+QacEue23wfw/WgVJ2yRUvip5GicWc4b4yahbYlwNshpp1u7WOIm2myLBDfEnBEESjChkaZomVTBSflkRiy+c2nkYnHl7BGkpqHb7UznGFCh8SuEGDbjsRR8DGTivp7t88+j05dumLaUM2JP06C7UjmAiRx2rk4ehgN77fS+bS6087lFzImf62yNpPxLfKPLsm3SPM1S45Pc75WE96D48djihhaj4NXQOyqik60M/3Z8HrSka/p7DiQaXzOVb1R671cJ+3gNwR7BGTVaQdlDvRZhCDFNPwJiIuf2gMX3obRaS/jIlm0o58VGg1Jzwxw2XYKbFCLlzxDo2hAdeYJyijqva3j9kb9gbH98cV38Gv/hqfZkB4NRUCElFGADER+OIgQKU/QsjIT8A8gJOM+iUFIf4dHz6gSpLzpY3095R5PsFOHrWCSNzJWCF6FWBp63a70VLhjISCn+g+ZxkrrDGri8qavsffk4Qkmu6/WIlQcDCDr9RgL3TZkwGXJn2boMlO9HS/iYDIFGhCtXfa2T/eyH1+rKGEs6hhK/1doCOAbLpDrv2G6rK0ctnPfBKs8uJFX5qfVQdaUa11 vbvuKZRz VP1r6wf4O3kJo9pdGaPMoId57fEa5I6jH3FCyXD8MAiF5YX+6xuTCLTTGQ9iKAnLydbg+EwZipRrq05UjYs8mXbJUh80GKDRaD6hTXDua3NmUu9DAgzTjQ3/pSkrwTz2JDwxq3Rxr2VtALAL/yJdsBleJJ5EBJ6pKMna71PNAZgBybVWEqcplgO+blnxQ1wMSYuUAUn1RDlYi/dPc99p2O1Je+Pk0fZHXeObDYnHP3oXZILZZT1qT0+UW9vpCIIwBS9erZ6VO6rrwPjqEjIwrF4T6Mk5ffEIc3eyhrrHH6YS2sfIpmAKfnMXYfm2PhE8cnfgUwtN2lU22spFXURGT/vOde91eCe/okSKCBSRzyskhyXpJSaxnfTMQsFGE7jCdmwScE6hWkcwmDiC1VhtfUvrZ36d5JDcV5djPeG5avaMtzLcAEDDgFs7/jWx5mBpUEeZo X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 30-04-25 15:59:14, Ryan Roberts wrote: > page_cache_ra_order() takes a parameter called new_order, which is > intended to express the preferred order of the folios that will be > allocated for the readahead operation. Most callers indeed call this > with their preferred new order. But page_cache_async_ra() calls it with > the preferred order of the previous readahead request (actually the > order of the folio that had the readahead marker, which may be smaller > when alignment comes into play). > > And despite the parameter name, page_cache_ra_order() always treats it > at the old order, adding 2 to it on entry. As a result, a cold readahead > always starts with order-2 folios. > > Let's fix this behaviour by always passing in the *new* order. > > Worked example: > > Prior to the change, mmaping an 8MB file and touching each page > sequentially, resulted in the following, where we start with order-2 > folios for the first 128K then ramp up to order-4 for the next 128K, > then get clamped to order-5 for the rest of the file because pa_pages is > limited to 128K: > > TYPE STARTOFFS ENDOFFS SIZE STARTPG ENDPG NRPG ORDER > ----- ---------- ---------- --------- ------- ------- ----- ----- > FOLIO 0x00000000 0x00004000 16384 0 4 4 2 > FOLIO 0x00004000 0x00008000 16384 4 8 4 2 > FOLIO 0x00008000 0x0000c000 16384 8 12 4 2 > FOLIO 0x0000c000 0x00010000 16384 12 16 4 2 > FOLIO 0x00010000 0x00014000 16384 16 20 4 2 > FOLIO 0x00014000 0x00018000 16384 20 24 4 2 > FOLIO 0x00018000 0x0001c000 16384 24 28 4 2 > FOLIO 0x0001c000 0x00020000 16384 28 32 4 2 > FOLIO 0x00020000 0x00030000 65536 32 48 16 4 > FOLIO 0x00030000 0x00040000 65536 48 64 16 4 > FOLIO 0x00040000 0x00060000 131072 64 96 32 5 > FOLIO 0x00060000 0x00080000 131072 96 128 32 5 > FOLIO 0x00080000 0x000a0000 131072 128 160 32 5 > FOLIO 0x000a0000 0x000c0000 131072 160 192 32 5 > ... > > After the change, the same operation results in the first 128K being > order-0, then we start ramping up to order-2, -4, and finally get > clamped at order-5: > > TYPE STARTOFFS ENDOFFS SIZE STARTPG ENDPG NRPG ORDER > ----- ---------- ---------- --------- ------- ------- ----- ----- > FOLIO 0x00000000 0x00001000 4096 0 1 1 0 > FOLIO 0x00001000 0x00002000 4096 1 2 1 0 > FOLIO 0x00002000 0x00003000 4096 2 3 1 0 > FOLIO 0x00003000 0x00004000 4096 3 4 1 0 > FOLIO 0x00004000 0x00005000 4096 4 5 1 0 > FOLIO 0x00005000 0x00006000 4096 5 6 1 0 > FOLIO 0x00006000 0x00007000 4096 6 7 1 0 > FOLIO 0x00007000 0x00008000 4096 7 8 1 0 > FOLIO 0x00008000 0x00009000 4096 8 9 1 0 > FOLIO 0x00009000 0x0000a000 4096 9 10 1 0 > FOLIO 0x0000a000 0x0000b000 4096 10 11 1 0 > FOLIO 0x0000b000 0x0000c000 4096 11 12 1 0 > FOLIO 0x0000c000 0x0000d000 4096 12 13 1 0 > FOLIO 0x0000d000 0x0000e000 4096 13 14 1 0 > FOLIO 0x0000e000 0x0000f000 4096 14 15 1 0 > FOLIO 0x0000f000 0x00010000 4096 15 16 1 0 > FOLIO 0x00010000 0x00011000 4096 16 17 1 0 > FOLIO 0x00011000 0x00012000 4096 17 18 1 0 > FOLIO 0x00012000 0x00013000 4096 18 19 1 0 > FOLIO 0x00013000 0x00014000 4096 19 20 1 0 > FOLIO 0x00014000 0x00015000 4096 20 21 1 0 > FOLIO 0x00015000 0x00016000 4096 21 22 1 0 > FOLIO 0x00016000 0x00017000 4096 22 23 1 0 > FOLIO 0x00017000 0x00018000 4096 23 24 1 0 > FOLIO 0x00018000 0x00019000 4096 24 25 1 0 > FOLIO 0x00019000 0x0001a000 4096 25 26 1 0 > FOLIO 0x0001a000 0x0001b000 4096 26 27 1 0 > FOLIO 0x0001b000 0x0001c000 4096 27 28 1 0 > FOLIO 0x0001c000 0x0001d000 4096 28 29 1 0 > FOLIO 0x0001d000 0x0001e000 4096 29 30 1 0 > FOLIO 0x0001e000 0x0001f000 4096 30 31 1 0 > FOLIO 0x0001f000 0x00020000 4096 31 32 1 0 > FOLIO 0x00020000 0x00024000 16384 32 36 4 2 > FOLIO 0x00024000 0x00028000 16384 36 40 4 2 > FOLIO 0x00028000 0x0002c000 16384 40 44 4 2 > FOLIO 0x0002c000 0x00030000 16384 44 48 4 2 > FOLIO 0x00030000 0x00034000 16384 48 52 4 2 > FOLIO 0x00034000 0x00038000 16384 52 56 4 2 > FOLIO 0x00038000 0x0003c000 16384 56 60 4 2 > FOLIO 0x0003c000 0x00040000 16384 60 64 4 2 > FOLIO 0x00040000 0x00050000 65536 64 80 16 4 > FOLIO 0x00050000 0x00060000 65536 80 96 16 4 > FOLIO 0x00060000 0x00080000 131072 96 128 32 5 > FOLIO 0x00080000 0x000a0000 131072 128 160 32 5 > FOLIO 0x000a0000 0x000c0000 131072 160 192 32 5 > FOLIO 0x000c0000 0x000e0000 131072 192 224 32 5 > ... > > Signed-off-by: Ryan Roberts Makes sense and looks good to me. Feel free to add: Reviewed-by: Jan Kara Honza > --- > mm/readahead.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/readahead.c b/mm/readahead.c > index 6a4e96b69702..8bb316f5a842 100644 > --- a/mm/readahead.c > +++ b/mm/readahead.c > @@ -479,9 +479,6 @@ void page_cache_ra_order(struct readahead_control *ractl, > > limit = min(limit, index + ra->size - 1); > > - if (new_order < mapping_max_folio_order(mapping)) > - new_order += 2; > - > new_order = min(mapping_max_folio_order(mapping), new_order); > new_order = min_t(unsigned int, new_order, ilog2(ra->size)); > new_order = max(new_order, min_order); > @@ -683,6 +680,7 @@ void page_cache_async_ra(struct readahead_control *ractl, > ra->size = get_next_ra_size(ra, max_pages); > ra->async_size = ra->size; > readit: > + order += 2; > ractl->_index = ra->start; > page_cache_ra_order(ractl, ra, order); > } > -- > 2.43.0 > -- Jan Kara SUSE Labs, CR