From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22FB4C54FC6 for ; Sun, 1 Sep 2024 20:42:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 56DFA8D0056; Sun, 1 Sep 2024 16:42:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 51D5C8D002D; Sun, 1 Sep 2024 16:42:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 40C048D0056; Sun, 1 Sep 2024 16:42:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 278C28D002D for ; Sun, 1 Sep 2024 16:42:18 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 973E441793 for ; Sun, 1 Sep 2024 20:42:17 +0000 (UTC) X-FDA: 82517341914.24.0261AC4 Received: from out-172.mta1.migadu.com (out-172.mta1.migadu.com [95.215.58.172]) by imf14.hostedemail.com (Postfix) with ESMTP id B61F8100002 for ; Sun, 1 Sep 2024 20:42:14 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=k1nSyWgA; spf=pass (imf14.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.172 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725223288; a=rsa-sha256; cv=none; b=lLD6QMXamQB+BYTiDuxgSmdaRtKOC3hPGHTqYZWY7pLbAdRyGusspRQ8SM6wVp+CQpRKrH GKmUoogMXhF/qDm1E1f2X7FwvF9yZ6M2vWZCsxHgeuHWa+DAlT+CC3BcBasFOH9HeY2bRl rcDRig8k0XIiUB659RsEPY87uiOpmCM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=k1nSyWgA; spf=pass (imf14.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.172 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725223288; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ju2Vw4zS6l91fQdiljroWqhw5t4I6GfCQlefI9QxVRw=; b=0zyr4Axf7ksXHajnZZi3L4BoPCugfVCbiPC/VRnZ06KSpS9W12dG96Jeph5DqJQu8BOYXG 7+gzFu/uc6wNAv7WkHwTbjiD4NsRo/LaZ6Bs9po68TiFIVxN6AMGptHhInJGITSB0+h663 T7OVGAdXFALy+T9qJWrKlSX68yHv4fo= Date: Sun, 1 Sep 2024 16:42:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1725223331; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ju2Vw4zS6l91fQdiljroWqhw5t4I6GfCQlefI9QxVRw=; b=k1nSyWgACCW+lGtSB9wQKyoALfT4ihGKN0YMI59UjmpGEWdLtERmab0izk9fmYoi7ZOXl6 s/1a0Fk2SXzTsiOhpgxVZL5+egB+NDUw+V9qkBiiBaWv1JOmThqq5gSSa4TUgslIqddSfi tVFlutyDy+wFjhm4sZhj6V5fQMHL04c= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Vlastimil Babka Cc: Yafang Shao , Christoph Hellwig , akpm@linux-foundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, david@fromorbit.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko Subject: Re: [PATCH 1/2] mm: Add memalloc_nowait_{save,restore} Message-ID: References: <20240812090525.80299-1-laoar.shao@gmail.com> <20240812090525.80299-2-laoar.shao@gmail.com> <9390b0ab-fd2c-45e3-b48f-94796ecbbbda@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9390b0ab-fd2c-45e3-b48f-94796ecbbbda@suse.cz> X-Migadu-Flow: FLOW_OUT X-Stat-Signature: 5jdm5x41qdoo1hrdm3jpe7y3pfybu15f X-Rspamd-Queue-Id: B61F8100002 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1725223334-487562 X-HE-Meta: U2FsdGVkX1/lTZSNS4Fm0EMCweexTyk46xAv9RuXnXSP4F25zGoNJeMi2SQGBg/ScIcUDxBC1+BLTMkbMFHnJLq0iCyIvXs00SZw+eTksNzBAEpA4dMBpjRdN1WnMi68/TRZUix0VFBVlBXRhH0gLtAxvJ5rZfhJn6s3DdpNVjfPJWkkRQBTPhCsMV8p7ba0JYn8+WxVvCq4pLhWDzboNpIkkbEk3r/G6CH7W7h0et9snl5lRGoiLTlcs8ZvwgsJDZC6N0PIw/Ee+kybeu/cTvucbT6r5F83KyHyrRX5kJ96ErEtBExc5w0PBDXdYTavfnV1gnZcjLaWM5JsPB7niFh8dk3ImFr4Ipcg51dlTGEfhHYpm3y+QWI17JEf4U4XZglDnnH9kTwg46mTJebExDKtC+R7pzhByJIeVe9m98CgyNyJiJKq5jYZtsNgyXcKFSguSYSb3wF8ZRMGqck4pr4yQOltpIGZ0/yhDCVywURf+tING558BgFgg4JbrgdrkYu2rrKLfzLuxNSp7gWkfIiz1HOyHF4SgxAlnQh/ETyPoa/bWz4zbN8nVaA0SlFImKsb9LBbhc4sPeXBy8owmmJUVzBqy5i5fAty7avgmu78OmvUSlXs1hhU5U2cwKcYSHuzn1xQG4HH9aOF0ZgLr1dy8jPkQBjkJbWJoCfBduJiGy3zkuLiR/ov8mELMa1uEWLKyEfovG+uMqiKQsNS/Zg5C5fh36MleozeIVS+UELVHoNRH2pEQxesa1qeY06bUhbRTX4UDvmGET9vzCTqKc1x2StLnYhdcyo/Sw2Fu3LTpvYNjKJjak70aHVGJ3RsShMz6u18NKQ9PzPRRxslyzWz/j7dRFoRUdlu++3SphzYr7SrVdsJV80teyUixZpdBpMiFH08uHmLwDkqTOnLzRnraJIcYqYONNJc73lOTiC0RRnlg7XLJuSi22ktdZOJsSlr7BUqg1vBogCqTrO cSfjgPa5 dYl4EBQybj/DlprDrhcgPLg0Pavz8PQZX8jHnRh/mIj7meFtDauo/zIFoa2KdOAJJZdIvyfM65SUB+4BoDDjGzyCvUvpq24Sjn88BOg+GRm9EEX8vuadqFLIoCGnVItAPhwWbGQrW+jro4BbrIzgmyLpGsph3Qj3uVGoXC5P3Hb66gAkWAFcSKDc4xb6JRE77H0qTFCUl23eY9rc29MxjaoFX2nhYFoTEgwVD9qavmZfVfcB6Zr6I7qeqnLMmnHreAVrnUmXxSFtbpyIEaoxGE8Uo1+vRAcKpxb7aSEMXSX7OQB0lxjLwaJnsJw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Sep 01, 2024 at 10:24:10PM GMT, Vlastimil Babka wrote: > On 8/14/24 09:33, Yafang Shao wrote: > > On Wed, Aug 14, 2024 at 1:27 PM Christoph Hellwig wrote: > >> > >> > There are already memalloc_noreclaim_{save,restore} which imply __GFP_MEMALLOC: > >> > > >> > memalloc_noreclaim_save - Marks implicit __GFP_MEMALLOC scope. > >> > >> .. and those are horrible misnamed :( > > Yes I agree, sorry about that. > > > What about renaming it to memalloc_memalloc_save ? > > While it looks weird, it could be indeed better than the current name. It's > not obvious, so it should force the user to read the description. > memalloc_noreclaim_save() might look too obviously "this disables reclaim" > but it's misleading as that's not the full story of PF_MEMALLOC. I was actually thinking about killing the helpers in favor of just memalloc_flags_save() - I don't think the extra names get us anything