From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6F0FC7EE29 for ; Tue, 23 May 2023 14:40:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 47184900002; Tue, 23 May 2023 10:40:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FB5E6B0075; Tue, 23 May 2023 10:40:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29BD1900002; Tue, 23 May 2023 10:40:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 176036B0074 for ; Tue, 23 May 2023 10:40:52 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B51BAADFE2 for ; Tue, 23 May 2023 14:40:51 +0000 (UTC) X-FDA: 80821781502.22.B4870D9 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf13.hostedemail.com (Postfix) with ESMTP id BFFE920004 for ; Tue, 23 May 2023 14:40:49 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=Uxk2np0y; spf=pass (imf13.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684852850; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nGlr9RSvSIRIegvdJA3tDbcOz/gxFk1P8G5vHNFFvdw=; b=tjtru3UZVhi4z6g1fx//dupXipZNay+Fiy9T2JV4cBNnC/FL9VQt7EK75cmQ+gUhqjxAT9 ZerNyzgbFplZ01EA7GYOsmgoQANBqSxHXJvdhPI5K39lVfGgcJ49J0RS1uJKvT7OMy7fOr sH7TmWTDK7TFZIYLlxltOvSRvsvptCA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684852850; a=rsa-sha256; cv=none; b=dArV4Y6ng208aJXz3AHi7jtqCTrYca21WM+MKcaqS2xZ96sp6K80/cwytTIzbdPqwbI2WU trJ33MxdGpjCbo3HcZp8hRl3neUylB3XFM+HqCbC7lcdBFXMEXmj8M6mkBhCIYg/Ck8Zh6 8psnKGALW7eGqjIk39yfOMdF28e9RhY= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=Uxk2np0y; spf=pass (imf13.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.28 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 11270229F9; Tue, 23 May 2023 14:40:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1684852848; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nGlr9RSvSIRIegvdJA3tDbcOz/gxFk1P8G5vHNFFvdw=; b=Uxk2np0yuV6dsJAJsvbMA15zF96rjED8fP2akEhLxsmTpt+feyN2T/XT2pX2L8XeAZ4ZNd x/FzKx4vRGic0qaTq8sE2kEc12gKEby+NSQYZAjT9a/i9yg98rtiR1IHPVBAP/QqZKzzcp /LSS2uf6XfVEVLuRagQgPj5k0Vkwt7U= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DA1DA13588; Tue, 23 May 2023 14:40:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id tCdyNG/QbGRaawAAMHmgww (envelope-from ); Tue, 23 May 2023 14:40:47 +0000 Date: Tue, 23 May 2023 16:40:46 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Haifeng Xu Cc: mhocko@kernel.org, roman.gushchin@linux.dev, hannes@cmpxchg.org, shakeelb@google.com, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] selftests: cgroup: fix unexpected failure on test_memcg_low Message-ID: References: <20230522095233.4246-2-haifeng.xu@shopee.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qrfw5lltt6r2lzen" Content-Disposition: inline In-Reply-To: <20230522095233.4246-2-haifeng.xu@shopee.com> X-Rspamd-Queue-Id: BFFE920004 X-Rspam-User: X-Stat-Signature: ohhy7arrgmfa85fxktedrkdmsfdmdyf7 X-Rspamd-Server: rspam03 X-HE-Tag: 1684852849-347060 X-HE-Meta: U2FsdGVkX187UiR3zGz4h7oVa7vguL0EzKzPs2TSwN6s7yjKzFU6O5xgrE98x3EGSmSx0STh3rAnojMP8z5XcJ9Y9Y01l2/fV1BeN9qTaj2JYhcE/CDt6825yzZL3yeSSy64XD67c8fhpCSP5Uwv5MX43XxOi5A0IBZDSKlPt7Wx3ACcL+fDdL0T4l3XT/hmO4F3wHyAUu60HWMiEleItefh+lRlH9pUBSqfK+ff/cMaZXP+i8zV1qGggez+aYc6lwKOegPIDpOHULQyjriGEaZgQJDOBgaFGzXDMgxT5v0Ylb4a86xHV98U5jBxAsMxdi/YPbB6d8NL6F/1fxu9RMwUi90i0W4tkzGgQcDoypcSYHhJSpovQHiQadUGXwGHDZjOYPRU46zPieaeBX1+DoVnJnrRmzfNoFu4mHqfcmFdff8vCXmB/tbwMDhgTRo1z/4ODG34zXA7pPH6dwnGbmjXwKqQoKQR8TmbWW+Zsh5Ci1T2hlz5rrb37r2AlahY0LCqpVXkHdWSn8I4QPD3CoFmEq/f/O3G7DjW5Eop20HJzCg632stSBi6wxXxBYtyk9moluhodZy6yUVl6zk21uqh+o5s0Je+iSHCVZExtUX2mK4r0UCFnea0dnSBLDYX3ffVK8ngaUqbmUojs9inB2yhzptkkXJjGDHwKm6x6aYKuK83Yr3HY6NSUE6wlt/VrVFtD+IFru8CKPu2pWq1Kka0LgaHDn+FDeTYKiLiP3KOV415j30fix/HqYgjqfS5KcT5W34sO/YWtJJbePcu9orNMPqkV/xes/23mOV0VYnfh6zmRPxIVVhxXwBQlcN/2Em2BP8TmxbWra1nmKF+QEtxr8JcF/RuebO/28aKjZevz0rmq/6/MOQeUOQvuVt747uw1FZzWMS1VhjA4N9BPOLzeIplYcHsZOSOAfc+woe5MELjfN5jRzlG9fhVxbN18afDBFGzXgL3DLZT7He UQjfmuja mLOJa00kKKB89DZ/GE54cOZ2DPGm8PG3oT6GnP4xtveEKCuGdzzLAZUwzNwSbfbCOP1HsqpB11f7upECnovVFHCrhFY/wom7WKiB+9A2SeqHkd6vW67RphcVcJPjPffQaChrYuLL5PsnnGkTfG2xv78fzEXhh0dtd52BGj5v7slGsy+g9AHvyDGR9T9I5WfyVzC2VPTkMZlMH4QNCNQxU6HlQurjocv3yM0BlMLypq4tBePkE+1ijY92ZcgyAmyZZzMSDQo6IRbamodD1p66H2A8hpbDpBT16bPBeShDeMNDz5y7h3Z13LYYri043jMbEMBYxoUU52zTUoSnKIskSVJfUw3HP20Y1y5eO/VMk6x0t5RvOdScomgpuNhkFzI6hFq+D5QBySSNFyxXAM5JziqI0A/Oi/hM4oHLFD4oqrY3PqdbgV3GyVQziFxdekfVyXsEQJu9gmcbny6pNJhdUcFmq5jHVAuADldqZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --qrfw5lltt6r2lzen Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 22, 2023 at 09:52:33AM +0000, Haifeng Xu wrote: > Since commit f079a020ba95 ("selftests: memcg: factor out common parts > of memory.{low,min} tests"), the value used in second alloc_anon has > changed from 148M to 170M. Because memory.low allows reclaiming page > cache in child cgroups, so the memory.current is close to 30M instead > of 50M. Therefore, adjust the expected value of parent cgroup. >=20 > Fixes: f079a020ba95 ("selftests: memcg: factor out common parts of memory= =2E{low,min} tests") > Signed-off-by: Haifeng Xu > --- > tools/testing/selftests/cgroup/test_memcontrol.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Yes, the expected value should be complement of the allocation to the limit when reclaim is allowed. Reviewed-by: Michal Koutn=FD FTR, the test_memcg_low fails after the fix still (6.3.1-2-default) because of nonzero memory.events:low in the unprotected A/B/E group (with memory_recursiveprot). (That's another and long standing issues -- perhaps the reason why this issue was hidden.) Thanks, Michal --qrfw5lltt6r2lzen Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTrXXag4J0QvXXBmkMkDQmsBEOquQUCZGzQbAAKCRAkDQmsBEOq uZ7BAQCh/IzL0Y/nVUwN/zZJm3gzAUIYiiYkjKXr3IdIi/nEEAD8CrjZAUCERkWq My0modfCN7u48OMYoc2a0660bD9tYww= =er1S -----END PGP SIGNATURE----- --qrfw5lltt6r2lzen--