From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30DCBC27C4F for ; Tue, 18 Jun 2024 16:55:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8CEEB8D0032; Tue, 18 Jun 2024 12:55:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8577C8D0001; Tue, 18 Jun 2024 12:55:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6ABD68D0032; Tue, 18 Jun 2024 12:55:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 496C08D0001 for ; Tue, 18 Jun 2024 12:55:39 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D836BA09B9 for ; Tue, 18 Jun 2024 16:55:38 +0000 (UTC) X-FDA: 82244610756.23.A2F53B0 Received: from mx0a-00823401.pphosted.com (mx0a-00823401.pphosted.com [148.163.148.104]) by imf14.hostedemail.com (Postfix) with ESMTP id B79CB100008 for ; Tue, 18 Jun 2024 16:55:34 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=motorola.com header.s=DKIM202306 header.b=Y8lPA3U+; spf=pass (imf14.hostedemail.com: domain of mbland@motorola.com designates 148.163.148.104 as permitted sender) smtp.mailfrom=mbland@motorola.com; dmarc=pass (policy=none) header.from=motorola.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718729732; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wtvTXtdoSaVdCRUBoRvF2THgNkI2kjk/oPJPs15GGeA=; b=lHyAkjMJXJxqi4Ro1VJCZg0ItAQOZvZPK1gGU+Ywe0bTiV216ax2PgRLRdXdQZv2VIXvo0 Fu7jaicP2U1xRe5Yk3imVLCZp0O1tkWX4R5cgN7YQyepaTCVek0C0ck72pCRu6ns7lElfU LjNt3VLjtQNX+iEmvv7zKWxWp2fTkxE= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=motorola.com header.s=DKIM202306 header.b=Y8lPA3U+; spf=pass (imf14.hostedemail.com: domain of mbland@motorola.com designates 148.163.148.104 as permitted sender) smtp.mailfrom=mbland@motorola.com; dmarc=pass (policy=none) header.from=motorola.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718729732; a=rsa-sha256; cv=none; b=XwxARwSz/BhEJ86g22AqWKmHj3t1RR+ULs6t4iuG5sgALL8LXMNCOjXSjw0N6mHhBE8a3r WEo8Y/HaFPfJHNwgfEyE+oXAXIj5/MIeL/adCLBmzcwj0VcUn9YfpaXKlDkVTGG+GLaEOm kQKu1ECDckVFDZiF62yXOrI/u7DI5sY= Received: from pps.filterd (m0355086.ppops.net [127.0.0.1]) by mx0a-00823401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45IFwjKv024465; Tue, 18 Jun 2024 16:55:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=motorola.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=DKIM202306; bh=wtvTXtdoSaVdCRUBoRvF2TH gNkI2kjk/oPJPs15GGeA=; b=Y8lPA3U+V4MNR1ghU8v73W1zfP9ErFSZZSnQiWE PVxEGMY/ej29Aw/SqZESLUErMck+DXelMBLCLOgt3sedkr6lOc6hxSW920llWXFG p9kdZPN4fIrF2cSiwUvfsvHgmNuFI/kEUBmw2xqfqx0tV2vVMJmM1mBzh8ZvPsIs i7Jr43fN46oihxJwAdzdCJPrBki5wkVicyQeBwP5swpnMhc0y3TrlZvHswU4kNah ymTir0UVirFZ7unxUA64g9hyn6/0OPjllUp9V5qvn/CTqE+HGIStn6O37mSt3vAZ jSfQZzzW3AB0853tlLuXzVEWoakcYtEdV1JQln6FgDSsDHQ== Received: from va32lpfpp03.lenovo.com ([104.232.228.23]) by mx0a-00823401.pphosted.com (PPS) with ESMTPS id 3ysrqk71r7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 Jun 2024 16:55:18 +0000 (GMT) Received: from ilclmmrp02.lenovo.com (ilclmmrp02.mot.com [100.65.83.26]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by va32lpfpp03.lenovo.com (Postfix) with ESMTPS id 4W3XtY0Hcjz4yxL1; Tue, 18 Jun 2024 16:55:17 +0000 (UTC) Received: from ilclasset02 (ilclasset02.mot.com [100.64.49.13]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mbland) by ilclmmrp02.lenovo.com (Postfix) with ESMTPSA id 4W3XtX610Zz3p6jp; Tue, 18 Jun 2024 16:55:16 +0000 (UTC) Date: Tue, 18 Jun 2024 11:55:15 -0500 From: Maxwell Bland To: Ard Biesheuvel Cc: linux-mm@kvack.org, Catalin Marinas , Will Deacon , Jonathan Corbet , Andrew Morton , Mark Rutland , Christophe Leroy , Alexandre Ghiti , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/5] arm64: non leaf ptdump support Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-ORIG-GUID: HQJtwJLbNKvpvj8GmEcPPa98F4oAU1UX X-Proofpoint-GUID: HQJtwJLbNKvpvj8GmEcPPa98F4oAU1UX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-18_02,2024-06-17_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 mlxscore=0 malwarescore=0 spamscore=0 mlxlogscore=590 bulkscore=0 adultscore=0 phishscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2405170001 definitions=main-2406180127 X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: B79CB100008 X-Stat-Signature: rphfsqsmox64gcbmprrqq3779yyoffhr X-Rspam-User: X-HE-Tag: 1718729734-25026 X-HE-Meta: U2FsdGVkX1/jt8GDiGRN/R4rn6G99FW7KB1rk3pDN1uz9A9I2IuSWmGxIkKqrMx7nTC35PG90MrhYlbMbfTmzOJvMjyi55mLTTbF+VjfEciw4OC+izjHNQWuolSMMMJgzaK52J9/T0Nlu2jIQMGeC+Q8g+kdXnxwJbExzGGiuI6joLuaUxee1B1Dpbrk2dh92Q/eLGvRfhYw6hfKJKCxXeab5pbqqs24MZ3EvvONgB7pX4jQMBmkIcx9ZIGW9fcPXudawW2urSeR9bujSYfapuq0VVrA30avAlHav3kjOhD4UO07IYljpgkVrwKGeO+1hWjX/HH6iUjhOCydgcdBNLYASgJ/H/lPp1ZXh5qLmJY6xDD/Vk8s7zuNqVrTW8aDrMba1gUxctDuD1rt9Yy6MIlHIB0wiIcpN9MryM7ly5q0fjW9x+36OU3U3ZuMz8WagJ9iG9u5nb9d/t4F8hXwPyBUz+H6NvgpumTwfJ/id1x1c5ZDjErOAXaRWRJcqX7wGUmppBIf3JKvmcWRtAsngpOROJRghqAnw9FJGANetQVPJ/0Fg0C0jXtrpfC84lWoVsRODouTUMZHfCqmdkgkW775DoCGz0Ygf8YLju4bti4o31g2kzucrssoicHmq3MHyL3UOPCqt323ctFlxnbAZ9ewhRWEuSNM1h+YMKJkUGfZgyveHxk1ou9igus6PQxjAJRBfcpSC/Xrf2ttL8iAIsn+CshTYbBKZUSQ8Z8JHMLcXSUG1thHy8LUK5FgaXVmSl9LYS0mC27NX/v/F0YexQcsEwoeKJYyJTabc1td+cbcPWwHOKx5P8FZ2lUGg5e8fkEPrD88/RbfjKdtOPl6cYvraerHPg/W6+rsi/fDG98bzfcinqj2CNZ+nREJg7YnPZMzJzq8BI2fRzQtUZC1b3kx82S3fCnaOKDa4gqLYIy25uImgWgOEQuHVr0MLMW6msAZfNPnwKOVkcSyxDc ZBIyfdka fffMfBMt/GAlwtCY8lKlspMYIMB0PCdaTxsvG7EzWqBkQMzNjiPRzxWbn2l79o4l1+HGyQbRJRRm5T0YgQJyf8trRDKJMrMhePXN4jsjWmczd5gsRoqvQCPV/+jF83dx/qlrEAMr+4RPvmHjfqVZKmwlWt+DZEJs5M2KcJ5bkbtcbtsFVJAMRcrhqhc4WGIBU/MnH1xty7Szy7QIkfhrGDS5Jn3gARuQDaiRX0b/fsB4+zirwINP7z1SoXks3BI4bm/29AmqLzposUEHwBNpBtJPFZwztSP/vdx1fxzC36dUJFXQnep7Wg8nBeh27sphIZ5qk4XFyrRmb/D4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 18, 2024 at 04:59:22PM GMT, Ard Biesheuvel wrote: > On Tue, 18 Jun 2024 at 16:40, Maxwell Bland wrote: > > @@ -105,11 +106,6 @@ static const struct prot_bits pte_bits[] = { > > .val = PTE_CONT, > > .set = "CON", > > .clear = " ", > > - }, { > > - .mask = PTE_TABLE_BIT, > > - .val = PTE_TABLE_BIT, > > - .set = " ", > > - .clear = "BLK", > > }, { > > .mask = PTE_UXN, > > .val = PTE_UXN, > This table will need to distinguish between table and block entries. > > I suspect that the distinction pte_bits <-> pxd_bits is not so useful > here. It would be better to have tbl_bits[], with pointers to it in > the pg_level array, where the PTE level one is set to NULL. Nice, thanks! Adding now. I'll slate a v5 release for next monday. Maxwell