From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FF49C4829A for ; Tue, 13 Feb 2024 12:31:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE3BA8D0010; Tue, 13 Feb 2024 07:31:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B94648D0001; Tue, 13 Feb 2024 07:31:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A5B798D0010; Tue, 13 Feb 2024 07:31:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8C7F38D0001 for ; Tue, 13 Feb 2024 07:31:05 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 50379A0B7C for ; Tue, 13 Feb 2024 12:31:05 +0000 (UTC) X-FDA: 81786715290.12.2764978 Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151]) by imf21.hostedemail.com (Postfix) with ESMTP id 535491C0025 for ; Tue, 13 Feb 2024 12:31:02 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=CSuaviJj; dmarc=none; spf=pass (imf21.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.151 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707827462; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DIg66RdJU9OwFIwtt981TU+bUHnJVsypvaGrWF5aizw=; b=MO/+yneum4psVQJ/JfQkmmv7X25UHEoFVt4XKNFEb5v+b1esWnUi9lc1zLgUNjAAMXNxWm NCD8jsdS2VJSjQ8Udl9wMNvL888N75wom9P+p/iMDY+qG5b3QHiWYOgmNjZa3y2v547Ad3 NhQldNzjW+kh+WWxdEM2RynMewbfQ/M= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=pankajraghav.com header.s=MBO0001 header.b=CSuaviJj; dmarc=none; spf=pass (imf21.hostedemail.com: domain of kernel@pankajraghav.com designates 80.241.56.151 as permitted sender) smtp.mailfrom=kernel@pankajraghav.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707827462; a=rsa-sha256; cv=none; b=qsCnYCQ30wBeVBVgxT6C5FDoM9jQ+zPQAHz5N975z6AWlivURfqY0qoXn7Yc7e76kmXZAK pzltee+kCNCMm27KrJs6rKYBWUJ2YE9QyW1TMqnresAhX/b+5clfMuRyEZ/K5p1pNR3OAG 9aqp+VNcna1qNkMbb6Fr2rbZqI6EZiM= Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4TZ0zh3xD5z9sn6; Tue, 13 Feb 2024 13:30:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pankajraghav.com; s=MBO0001; t=1707827456; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DIg66RdJU9OwFIwtt981TU+bUHnJVsypvaGrWF5aizw=; b=CSuaviJj+ifluOeWtUWWsQGTD3QjgppzGm9qLW8AykSBIRq6Dfao2ZGDO5Yl37FzE74c+v FDz19HU4mjMDeXcn7Musbnf7H/WZC7q3Zsf26mYStBJoz8Ae90lLr25c0SuMrQaxCgEe2r w3efZBlHdAUamsHtzqeCYkmg/Vf+QJdj1gSBuo4m5XN1XlPkb3nAhHpMCmWAOXKvi4+AgF jXJIO9pnnrA/VeIwuYGSOARj/YFsGs6ODUwqy1TseNW3BhAORIQWILJUfZ8CpcZCTm2tK6 2o4pCdpqfbdbWtE/aVDtWC97iPMIjXayFEyu5bq8aqQtX6jh50neal+phvb/fg== Date: Tue, 13 Feb 2024 13:30:51 +0100 From: "Pankaj Raghav (Samsung)" To: Zi Yan Cc: "Matthew Wilcox (Oracle)" , Yang Shi , Yu Zhao , linux-mm@kvack.org, "Kirill A . Shutemov" , Ryan Roberts , Michal =?utf-8?Q?Koutn=C3=BD?= , Roman Gushchin , Zach O'Keefe , Andrew Morton , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, mcgrof@kernel.org, gost.dev@samsung.com Subject: Re: [PATCH v3 0/7] Split a folio to any lower order folios Message-ID: References: <20230403201839.4097845-1-zi.yan@sent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230403201839.4097845-1-zi.yan@sent.com> X-Rspamd-Queue-Id: 535491C0025 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: p4ros1rdyg11hff74cpjsn8ztg5np7t5 X-HE-Tag: 1707827462-430323 X-HE-Meta: U2FsdGVkX18BFBdTEEZSbFzEWbMAEANWs/tFTXsCyGsqZAVjWAMKCVZEyLK8Lgifiovx8aLN1PivYy+yuXIg1tHM8UzaDNzlhzXLH1m9hTufpnvypKIRwFCHKYgsAavs3E3q9KGU+Ot6Igu6eqKXfrggoyJTTIcwt87fmfNz9qjTIqSgTW6I//IOOyb/6t5gjUGx6AhZ078h9nCIiqh4wUfVO1Zz4hyibfCt8QDTIp0v84WZ5gQ61AaAoLNDemLSe1v60wmCJJWucf80488iBrtiK+un9M8W9W9GkY0jx2soLj4uD40HUZP7S3xlzlMJE4FvuEsxfP8sR4ZJ7PYRAGTgVOaw8T1wBwP1cplyI+p/Z+M3HuYFo1z66LS6wTbfu31lz+JCBz7eEhaQ7tAoK5gr4xoZ2Lv1tGaHODsasE0Ssfsg6lprCJvB4YZ3PpHy+CmIzvhnZduOGpvlu39nRPFIoA5TJ+wYwqYZTCx1x9TiqnREWNJV8jZw4kwIl2PsnnqGZ/KQ7K8aQ5jy0HYDakyuUd+fp2ES4ptdYYBOKEbIWTpKaRwDgmdAR1dG6LM2BH1lsuqTJeGWXJKFUKKB4k9tblwNNqWFDbZS08ngDvfu2lTsOguvMgLAPeqr/lKnT7dT8ecG2PYAAfXonrUjZfj2KXDqVVylRz/eq8aPSXhrvGlZtkMBVxtr9FIsDKiLjm762rcqC0p4wPFXxaeM2bfN0xIzsrgvm9AZPqPqvMZu9L2y7qouq8kN2JVXfu/rJ/F/uCYGNVeD59Hm6lYSYA4l6T7sS71NE6fsJBasVp0YHITE2CHV6a1Udt7girg7AMgWRHxvEdYRi6VUpiUTF1s+N2/JCh5/kFEYjZD/kXH3mPD9CaD0EJ/el8SIQT2kUiF2K3riYVJDeDWMTnn5cOIwkvU0fIsehFZwNIG4OMtovS6hmhkpvZr5NmiVhrzW1Qpai9vYPJ1FcH6cpCe LTDeIbn6 REnXvSc671AIMTos4dy+RK7LjBiASCvFJAD1GP305yKA+Daj3gl5ewP4wSQogtGpo8ozFWejKLI2IvhyPoxrDCkx8G8L3B1G0OTzgAtkZG9qe/7VSUKcwg22JcdoA0rvNbMGGZBR58/3fw+qsj3yE9kORuuFQzcfK7QY5FuSlF1QArjFB0IsoJxmNDUdr+kBLCuJRIH6YdLL3oynmJlp4on5+wBl8h9YY1D0rQ4uqkgtxr7MRvx/dS4kx5fpGETPfzde9yu78na1QTLZy55J1uhN+lyxx7nyo0Qf1S3Ypd0fATdCzN+PpfZ5ami6fHMXgOtfNb++xj+AjMRpqHpAzi2T/Aw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Zi yan, > From: Zi Yan > > Hi all, > > File folio supports any order and people would like to support flexible orders > for anonymous folio[1] too. Currently, split_huge_page() only splits a huge > page to order-0 pages, but splitting to orders higher than 0 is also useful. > This patchset adds support for splitting a huge page to any lower order pages > and uses it during file folio truncate operations. > I recently posted patches to enable block size > page size(Large Block Sizes) in XFS[1]. The main idea of LBS is to have a notion of minimum order in the page cache that corresponds to the filesystem block size. Ability to split a folio based on a given order is something that would definitely optimize the LBS implementation. The current implementation refuses to split a large folio if it has a minimum order set in the page cache [2]. What we would like to have instead is to split it based on the minimum order. The main use is of course being able to free some folios during partial truncate operation. Your patch was also suggested by willy during our LPC talk[3]. I tried rebasing your patch and there were a lot of non-trivial conflicts. Is there any plans on sending a new version? [1] https://lore.kernel.org/linux-xfs/20240213093713.1753368-1-kernel@pankajraghav.com/ [2] https://lore.kernel.org/linux-xfs/20240213093713.1753368-9-kernel@pankajraghav.com/ [3] https://youtu.be/ar72r5Xf7x4?si=XDb-g7SSIgS-5TkP&t=1457 -- Pankaj