From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21569CD128A for ; Wed, 3 Apr 2024 22:57:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 230106B0082; Wed, 3 Apr 2024 18:57:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DFEA6B0083; Wed, 3 Apr 2024 18:57:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A7C46B0085; Wed, 3 Apr 2024 18:57:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E24F96B0082 for ; Wed, 3 Apr 2024 18:57:44 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9F49A40283 for ; Wed, 3 Apr 2024 22:57:44 +0000 (UTC) X-FDA: 81969734448.10.F60E475 Received: from out-178.mta1.migadu.com (out-178.mta1.migadu.com [95.215.58.178]) by imf09.hostedemail.com (Postfix) with ESMTP id 8CB0F140026 for ; Wed, 3 Apr 2024 22:57:42 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=altBgIa+; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf09.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.178 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712185063; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AWtiyFTqYKwdJDHyaCD82L5617uAdz2F4Sz0PAghbhE=; b=4olzD6YN8m7tKPr7Xp3/w6R419m9Le1J179fAkKIoDzDBBTQXsaz+6wdscO83mqIwKaUoT QL5CGXx6VtIoHRVIhFoXUrUroukT0XzanMAV0Hdh2Y+RogRTnyCUnYBh58KvBSUEDrm1Pg vqfmYQoACeGF5voYy3UhRtpcg2a1POA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=altBgIa+; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf09.hostedemail.com: domain of kent.overstreet@linux.dev designates 95.215.58.178 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712185063; a=rsa-sha256; cv=none; b=wD53IX77LBHvZNAp2KRITbxow/OMJaQcQGInEiMM8uSf/LOP07ug0aCMiBO4foqFgqhqU4 2/ldwbdSI3Q3Tp3FdqnjiK63ezUkUDFoB4aYoMSso4cj2sVLRj9TsE94ZlH2ICyAMIArNf c9UT8jDXJu+Ap6K8JuaDVwa5CImNL1c= Date: Wed, 3 Apr 2024 18:57:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1712185059; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AWtiyFTqYKwdJDHyaCD82L5617uAdz2F4Sz0PAghbhE=; b=altBgIa+MeRE72rlksdac4u+jogeiW19C04WbQpYqlQTv7yFrJi+DeOIswL1ev0MHQMoJz 3P/blHm1a9ObCUExPNH7tB1oeAvKxRHvqrARJ69T91VOSSObtkLUGmQ7Nd8eHpwXRM9vPE nRIje5E5zoSDcqJDGAKpSrukrB99Ej0= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: David Hildenbrand Cc: Nathan Chancellor , Suren Baghdasaryan , akpm@linux-foundation.org, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v6 01/37] fix missing vmalloc.h includes Message-ID: References: <20240321163705.3067592-1-surenb@google.com> <20240321163705.3067592-2-surenb@google.com> <20240403211240.GA307137@dev-arch.thelio-3990X> <4qk7f3ra5lrqhtvmipmacgzo5qwnugrfxn5dd3j4wubzwqvmv4@vzdhpalbmob3> <9e2d09f8-2234-42f3-8481-87bbd9ad4def@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9e2d09f8-2234-42f3-8481-87bbd9ad4def@redhat.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 8CB0F140026 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: sa3mnro4re3896gf78kgwtp9pqjo5951 X-HE-Tag: 1712185062-358706 X-HE-Meta: U2FsdGVkX1982hh/1eBH1+8vNtMI01YylC3w5j1vW6G4I8osZ8Y2GqVOaSxUSmEiuhNbiWmDZ+B98lZA+oiUMsGvYb/IfunQFZom80iwgTr9H2/k3M7B7R+HvEOcM77XkIARF/VAbe4vfLLsOtGB+2NV0PLFBza9J5ogCpzZQ4dH2ST9wa4Wtd+bh/AGo/P0S6IJ9Ga7tKxVTu+LZye71CgLnmoNJdrPoarDKHz/iUKubmXRYYs8M/WtXs2dFCLa2uuoSTVI0l9uwaj/O929Mn137ZukeeTBDHqIBFyGkjZ7SFPJAILNiLKxe03zjsN0cEPLJu2pXbTgzbrEcn514vcxdRDIohk0xtGgKtJGz+KWaLeV8anv9YASb73V2isg7+FmJ6+wJJhndFDnqtExhSdqZMEApG8Y63cLsxjPvoh01w+jXSnZM6Zj1oyFZVExyfsXsP6rDKQXADWiht21qipYRDrrP/7Xujx1LalqkikoVWeN9cvI8ZwUMNLUk580fjyvbM9Dop0NRh6VKsM7BY9vd7zJfwNKvqCkcpsVwA+oiz48BJ7sXQHbCOAyHB/ljDfMfYmz/3VuEThc4oJs6UcHlThdBW04Pw8l7ThGEDDiTQPS/jwhISm3/ORz1nghQ6nY6IfUWdq+1nqLya3PlbBV6f6Pp4Pg2Z4iSsXQ16NMKR9DbsigYOz9NcBSsIBSGyZq2QDQIxb1IY4+sHmGq0odGXxq/6JsM7YnXpYa447HDWOUUTWYMYy7PLPATcFyfyATozyAtMy9H4Vv3ry5COZTeb0/3F582Kev9Rc20LNZEb11889MDcA70Z/ahrdoYVbPKciPobmb4Y9YTib6dk7g6X9XbFea2AG1fL9JLJ3ljyKGTpH0RP4/bSBrT/PAqa5zFtfaXS8u5FkHCBlFohm4995FDhw28yiTiyG/As5A2bO9xPbVm5S//5EimSEwSIkodEHcK6/PvvnvX0W seDuk6OW +y0zfAun0kbwqdPGbugiZMmlta2QLRxqGBEx80pX1e3xPtMdjnn4jq/LQezUTTf/mHEsmgAkJVLny4uZx1lfve67LlpbXGKvvMNWCe2xdDZDbccJM/L+ZsJjc5gR5iGD19uXxrYA/1kpr7Of3K/Fw5/Dab1ExBRk+U6aBKoqVZTmiqAWqpEe67ge1GD2zJmFz+I0iZbgkPUBXoKt669AnyEgRT6+zHjvLeiZxeOAdRIzYOxrXPMQH5FnC7htOsnJ6xMyRbHH/koxA+NXJqtJXbfVcJAomdDGo/lsaEvSZH7SNb5U= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 03, 2024 at 11:48:12PM +0200, David Hildenbrand wrote: > On 03.04.24 23:41, Kent Overstreet wrote: > > On Wed, Apr 03, 2024 at 02:12:40PM -0700, Nathan Chancellor wrote: > > > On Thu, Mar 21, 2024 at 09:36:23AM -0700, Suren Baghdasaryan wrote: > > > > From: Kent Overstreet > > > > > > > > The next patch drops vmalloc.h from a system header in order to fix > > > > a circular dependency; this adds it to all the files that were pulling > > > > it in implicitly. > > > > > > > > Signed-off-by: Kent Overstreet > > > > Signed-off-by: Suren Baghdasaryan > > > > Reviewed-by: Pasha Tatashin > > > > > > I bisected an error that I see when building ARCH=loongarch allmodconfig > > > to commit 302519d9e80a ("asm-generic/io.h: kill vmalloc.h dependency") > > > in -next, which tells me that this patch likely needs to contain > > > something along the following lines, as LoongArch was getting > > > include/linux/sizes.h transitively through the vmalloc.h include in > > > include/asm-generic/io.h. > > > > gcc doesn't appear to be packaged for loongarch for debian (most other > > cross compilers are), so that's going to make it hard for me to test > > anything... > > The latest cross-compilers from Arnd [1] include a 13.2.0 one for > loongarch64 that works for me. Just in case you haven't heard of Arnds work > before and want to give it a shot. > > [1] https://mirrors.edge.kernel.org/pub/tools/crosstool/ Thanks for the pointer - but something seems to be busted with the loongarch build, if I'm not mistaken; one of the included headers references loongarch-def.h, but that's not included.