From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C81D9C433FE for ; Sat, 19 Nov 2022 00:03:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 334376B0073; Fri, 18 Nov 2022 19:03:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E4F56B0074; Fri, 18 Nov 2022 19:03:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1AC578E0001; Fri, 18 Nov 2022 19:03:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0BFF56B0073 for ; Fri, 18 Nov 2022 19:03:02 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D5510AAE8E for ; Sat, 19 Nov 2022 00:03:01 +0000 (UTC) X-FDA: 80148241362.16.6E8D8F7 Received: from wnew2-smtp.messagingengine.com (wnew2-smtp.messagingengine.com [64.147.123.27]) by imf03.hostedemail.com (Postfix) with ESMTP id 125CB2000E for ; Sat, 19 Nov 2022 00:03:00 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.west.internal (Postfix) with ESMTP id F2AB02B067B7; Fri, 18 Nov 2022 19:02:58 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 18 Nov 2022 19:02:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=devkernel.io; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1668816178; x=1668819778; bh=DVeAdFlp2K jM5VWV1HK0EMvnRWbCTd0/KQhr3OsmXj0=; b=blv21r3SKywYvqaw90mI5T7Y8F vtBp4togFVHTtbyVYPspywYMfys7EN8iUECiSGD5RUqDwy2m5YXVxCrSZQN3J+Bt MlmEMeewpiLo1hANuhWn/8vBJOP5iglIub/51937dRJbU2QWsZcfkQ1bPzqt4GVT EOcr5j0NI71cRKY+JFf+ALmo1o5/wcin+RL6SWGCbFVz97RXdsJajdVc61AavVwc 4DAI9ibOCd2EtIeo9d98TOPPdzERPWtu7iyHt9YxMey+0bv7BUnXcScbzz0d1BtS IC+rLxdLYdeUB9lltebV0c+xXydOsMclnHtSHC7fAh07NGWnzMJDFGBUERsg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1668816178; x=1668819778; bh=DVeAdFlp2KjM5VWV1HK0EMvnRWbC Td0/KQhr3OsmXj0=; b=O86O6Ga/SFRS4JE2QbSNu3BqvrpN2p/JU0XYYnBt6XAw 4jx8Gltws+gPT8ZvbKLabQe7tbvr38itxLJdmpQTYleW2U87m1wRtj4njTFPR3T6 CPDkQzEX5Ze1G0VXMe7+cCz1jEuSpmxOeAPIsCq2X9XLdab3SEwax9Pqp3X4qGGW vZieGzEY5ki3D71YOSDLZCyMWUOLlmLsds1UJdn0AxgllpsZpczORs8I7YXUY7pP OoyvTK7R+3LZrSdJOjN23QoyqKVRUa9nwg2QLlCKtLZYO2ChGsxaT30KQYOBLPK3 tAyzvYINgV3JWp8y0tntPRJlfo/yqokw30S+ltHcNg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrhedugddukecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfhgfhffvvefuffgjkfggtgesthdtre dttdertdenucfhrhhomhepufhtvghfrghnucftohgvshgthhcuoehshhhrseguvghvkhgv rhhnvghlrdhioheqnecuggftrfgrthhtvghrnhepveelgffghfehudeitdehjeevhedthf etvdfhledutedvgeeikeeggefgudeguedtnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomhepshhhrhesuggvvhhkvghrnhgvlhdrihho X-ME-Proxy: Feedback-ID: i84614614:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 18 Nov 2022 19:02:57 -0500 (EST) References: <20221024190603.3987969-1-shr@devkernel.io> <20221024190603.3987969-2-shr@devkernel.io> <20221116132856.b3403e3ae1e39cc3a7a4f865@linux-foundation.org> User-agent: mu4e 1.6.11; emacs 28.2.50 From: Stefan Roesch To: Andrew Morton Cc: kernel-team@fb.com, linux-block@vger.kernel.org, linux-mm@kvack.org, axboe@kernel.dk, clm@meta.com, willy@infradead.org, hch@infradead.org Subject: Re: [RFC PATCH v3 01/14] mm: add bdi_set_strict_limit() function Date: Fri, 18 Nov 2022 16:01:48 -0800 In-reply-to: <20221116132856.b3403e3ae1e39cc3a7a4f865@linux-foundation.org> Message-ID: MIME-Version: 1.0 Content-Type: text/plain ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668816181; a=rsa-sha256; cv=none; b=Vvem5pBXWolH3JLBGUHGuyeRpXL8P0AqEATwMJav/AbuaocNVfONJlOVOsxwL1u1qERnYM bslKizITxsM9ouZcSe6yZVQ+8//R/+7dBKeMOhHrVo6e7ieVME8hwY9SqptA0wqefcLeKA pPHCH3oUekkiukzGx111vCghyx5vXXg= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm2 header.b=blv21r3S; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="O86O6Ga/"; spf=pass (imf03.hostedemail.com: domain of shr@devkernel.io designates 64.147.123.27 as permitted sender) smtp.mailfrom=shr@devkernel.io; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668816181; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DVeAdFlp2KjM5VWV1HK0EMvnRWbCTd0/KQhr3OsmXj0=; b=aaJhhL47VsUQ85WLiq4Uag+FcznS07eJI/pHqETxzh87hoEwTrQxBYSNcW/iSR8MZ8OE4F yq/+di/auDcH3CnMeKXRuEYiinx4EVXg/i7PBbgW7VaHpe8ubypupC3fIbRyqLwsehBLy4 Dm1tT/uG8ct0QbQCGoNkwfwCoGSH0Hg= X-Stat-Signature: gdsa97fzyc7yoet5d15a989szdfzy8p9 X-Rspamd-Queue-Id: 125CB2000E Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm2 header.b=blv21r3S; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="O86O6Ga/"; spf=pass (imf03.hostedemail.com: domain of shr@devkernel.io designates 64.147.123.27 as permitted sender) smtp.mailfrom=shr@devkernel.io; dmarc=none X-Rspamd-Server: rspam04 X-Rspam-User: X-HE-Tag: 1668816180-977352 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Andrew Morton writes: > On Mon, 24 Oct 2022 12:05:50 -0700 Stefan Roesch wrote: > >> This adds the bdi_set_strict_limit function to be able to set/unset the >> BDI_CAP_STRICTLIMIT flag. >> >> ... >> >> --- a/mm/page-writeback.c >> +++ b/mm/page-writeback.c >> @@ -698,6 +698,22 @@ int bdi_set_max_ratio(struct backing_dev_info *bdi, unsigned max_ratio) >> } >> EXPORT_SYMBOL(bdi_set_max_ratio); >> >> +int bdi_set_strict_limit(struct backing_dev_info *bdi, unsigned int strict_limit) >> +{ >> + if (strict_limit > 1) >> + return -EINVAL; >> + >> + spin_lock_bh(&bdi_lock); >> + if (strict_limit) >> + bdi->capabilities |= BDI_CAP_STRICTLIMIT; >> + else >> + bdi->capabilities &= ~BDI_CAP_STRICTLIMIT; >> + spin_unlock_bh(&bdi_lock); >> + >> + return 0; >> +} >> +EXPORT_SYMBOL_GPL(bdi_set_strict_limit); > > I don't believe the export is needed? No, the export is not needed, the next version will remove the export.