From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6411C77B78 for ; Fri, 21 Apr 2023 18:29:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38C876B0071; Fri, 21 Apr 2023 14:29:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 33C216B0072; Fri, 21 Apr 2023 14:29:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 205DA6B0074; Fri, 21 Apr 2023 14:29:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 123836B0071 for ; Fri, 21 Apr 2023 14:29:17 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CC52A1605DD for ; Fri, 21 Apr 2023 18:29:16 +0000 (UTC) X-FDA: 80706235512.03.729E7CE Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by imf18.hostedemail.com (Postfix) with ESMTP id D46E71C0015 for ; Fri, 21 Apr 2023 18:29:14 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm1 header.b=cLCvpeRM; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=XIrOUyfO; spf=pass (imf18.hostedemail.com: domain of shr@devkernel.io designates 66.111.4.26 as permitted sender) smtp.mailfrom=shr@devkernel.io; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682101754; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E1giA72jTN/HCoY+ZkODXi5a5cgWitw0+lONQS3/t7A=; b=lpKg7sfU88exuWE9mCAZoQcIw5JWrkc/BprDQQ8aefaIN0Cp2smBicoKXD6nf1RvxFDRBf e1hu1vIAtqRsR1e2JDECPSmyKesoCYWkgOf+/562lgHx06SJO/UoGfB7yXtFON8KpOrx4S xMyzSsSdO+KVFzCgJJppdlgXMBCKIG4= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm1 header.b=cLCvpeRM; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=XIrOUyfO; spf=pass (imf18.hostedemail.com: domain of shr@devkernel.io designates 66.111.4.26 as permitted sender) smtp.mailfrom=shr@devkernel.io; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682101754; a=rsa-sha256; cv=none; b=XvZi/Qs+LlqZ40NdqaE7qxpUKXA9FYbpgcA6qdtzdgBGqMrxiDmjQij3jZEgFYLn4gc4gX yIApD1DH64omqfT4oJ7d1K1yYgOtWiY7L/J0dR70d1LEFBNUFV7Vj1eYKq9GKl0aY0Olww YrW7N6nRHEtKx+IgKJe9E9fp9ONxZJg= Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 8C7B35C00C9; Fri, 21 Apr 2023 14:29:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 21 Apr 2023 14:29:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=devkernel.io; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1682101752; x=1682188152; bh=E1 giA72jTN/HCoY+ZkODXi5a5cgWitw0+lONQS3/t7A=; b=cLCvpeRM5lx2n8YJEv ctpJlrZd/cvTHHyzMCqw1BVqTcXVgeLCqb6QV1QZ0tmVSCw9Hokf234+XqSzm4wE 8ZE2nK2wllZNzlTioQ86W4TDsy24scnOtD3hOgN0i3sihzKtD/okV26x7RMy9Bd0 2LXLm7wPcpVpII3aB9gwV7jKqUblefDZ83PxTFnb1EHAHQggvFodY38vkpyMRptU hl0PYvUz/2O8jpnRSYxgPwgQGxXBJv2NDPISJg1Bh/F/2iUTViHO30IulUGDPCCy Z8n7wWABxBx8tPwzyZv+kYdZ3sRfOpFf9kCDyQmAVjQhC3u9TmI3DbQvqjNzdC0x g0OQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1682101752; x=1682188152; bh=E1giA72jTN/HC oY+ZkODXi5a5cgWitw0+lONQS3/t7A=; b=XIrOUyfO9vgiYaLiAwjPy6D6dkCoa 284FdZQk/VS33jzayeoEjODvPto3BtKkfK70YwVOCM2JSOMn75m1dCaqYnLonpC3 9l5MIAw/lEGNYqSmWOPgvPg7EwkCcuIXJmxOeQUxnkwBVJcgugyAAd1ThFSemUbR 6Hqy95yY9FGhXXuago4M6ZZKvk2fpnGwEi/ttra1jyu+Z7uefg/A0ULK7lcOcilI Kjrwf6Zb16O5X4zZv2iaYMNJbRIC8Oq+agK1Ke/2HXtUuQ2K1gKENt8ONx5a3htl nlsAz9A8jPMF8dMPtv/L5qnyuCMMxN8zqAzpb3arJMG4eGGB7CWOIloqQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedtgedguddvfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvfevufffjgfkgggtsehttdertddtredtnecuhfhrohhmpefuthgv fhgrnhcutfhovghstghhuceoshhhrhesuggvvhhkvghrnhgvlhdrihhoqeenucggtffrrg htthgvrhhnpeevlefggffhheduiedtheejveehtdfhtedvhfeludetvdegieekgeeggfdu geeutdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hshhhrseguvghvkhgvrhhnvghlrdhioh X-ME-Proxy: Feedback-ID: i84614614:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 21 Apr 2023 14:29:10 -0400 (EDT) References: <20230418051342.1919757-1-shr@devkernel.io> <20230418152849.505124-1-david@redhat.com> <20230418152849.505124-2-david@redhat.com> User-agent: mu4e 1.10.1; emacs 28.2.50 From: Stefan Roesch To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-kselftest@vger.kernel.org, Andrew Morton , Rik van Riel , Johannes Weiner , Michal Hocko , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Heiko Carstens , Vasily Gorbik , Sven Schnelle , Shuah Khan Subject: Re: [PATCH v1 1/3] mm/ksm: unmerge and clear VM_MERGEABLE when setting PR_SET_MEMORY_MERGE=0 Date: Fri, 21 Apr 2023 11:28:49 -0700 In-reply-to: Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Stat-Signature: r7rdbmgyrekbqwozfozba98fiimpwsb9 X-Rspam-User: X-Rspamd-Queue-Id: D46E71C0015 X-Rspamd-Server: rspam06 X-HE-Tag: 1682101754-16939 X-HE-Meta: U2FsdGVkX19Eg8i5v6EH7S4NVbNNYhPexDEB4Op70A0ctE+2S4lMQ1Sy2rhB9hdmDsxo9As3GOBxK8wSMmlW2BJvq2YTLDsURiraatrdgbg90h55vHoi0HXLeKPLVqPgZT2R4/s01A4RJKKjQiCCUZVaiEieIYooSFN44PcfK8GNuJOaK+BEmiQtYq5aGW+JjGTJZJuC/y1EN4YEXRHMfdFzpJzpuNHXedqljpvV8zOibvSKrt+UytY+/d7Sip49ZpvoF4YOicaJe4RLTbTZpVXMr89alHFLv24ildm7bgTg3NcUja9P4q4sqxIaMXAh+r666R3KMb0H5KHuvvhjksixydlf2TtPyjJlRUx8yqlmXD/QICxyJeSHbw8ncu0Iao2NJ0CZGtBgJrqg7QkIBTpEpaNAXb/xJPrncIGyzNxrJJeyFw3mqKtwiUf+G7rytFht34KMz6q8Ki4JfW+Xl0Z2+BQoQXb4yujCJO5rdg301uQAoIMVQ4LkH6RopKtcPRv8Kfal5uTaCPwkJrlFzsoYJBxOKhXr+c9bj1jTyVanpa4mb/KVaJ8fugG9NKdJqyayAgTlRqgWgXk28YHd9ttWfVxin933sMceKPkQ7piADA1Tp5VIFIIcc5A1dyP+iJdLV0urIzWDRqeHME02cRZtdjj7O9ZVa0HfIeBvLgplvU6WjpD//Xz44Qh4ORYhWDBHVtqvBlfsfY7CLehUGXGqKnbG7zZgOfIQv7yK0gfIo+wWgnX0dn9tTEx5incud1NfdNX38lEyK2f9AhxyR6qhvrhpiCljHT9GStXhTICCbvfIsz3+IGrSbCJ1NAkmdfbQFHGnk2jc97KQFesPkPDSiZ1++NiQuazYt2pDZAxgcA5rby7+b4EuvgbExb7ClUnbar2PG/TB1T4mytaZ/rQ/tMwqz9dN43Kqp2vx7+MYNkG3w6dW2nHJ7Xhpl3I54yYDDOCznti2kwo7iuB unsHPK4n DCOpjcxTbjXI/ek5IrxOwZ9lmglH5ziXs7uMzOYTob0zknKiOWtbyKG8twmFIuJdfGcZoj4muFt1ig9KNlybEI8gUhr9WRUb+gtcgs1WjaF3pi5cousAKPFlCdVSPbMs11Talp0pV6ZCCSOl+Xlu7I88Tll6AGNSd2Ku7z+IXN6/7pq844hLsTYu0vXP6VY/YPKC1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: David Hildenbrand writes: >>> I understand we want to keep the name "symmetric" with >>> ksm_enable_merge_any, but it also unmerges the ksm pages. Do we want to >>> reflect that in the function name? >> ksm_disable_merge_any_umerge() is suboptimal. >> As ksm_disable_merge_any() now reverts what ksm_enable_merge_any() ended >> up doing, I think it's just fine. >> (it would be a different story if we'd be using "set" / "clear" >> terminology instead of "enable" / "disable"). >> We can describe that in the comment. >> >>> >>> Can we add a comment for the function? >> Can do for symmetry with ksm_enable_merge_any(). >> > > +/** > + * ksm_disable_merge_any - Disable merging on all compatible VMA's of the mm, > + * previously enabled via ksm_enable_merge_any(). > + * > + * Disabling merging implies unmerging any merged pages, like setting > + * MADV_UNMERGEABLE would. If unmerging fails, the whole operation fails and > + * merging on all compatible VMA's remains enabled. > + * > + * @mm: Pointer to mm > + * > + * Returns 0 on success, otherwise error code > + */ LGTM Acked-by: Stefan Roesch