From: Stefan Roesch <shr@devkernel.io>
To: Matthew Wilcox <willy@infradead.org>
Cc: kernel-team@fb.com, linux-block@vger.kernel.org,
linux-mm@kvack.org, axboe@kernel.dk, clm@meta.com
Subject: Re: [RFC PATCH v1 00/14] mm/block: add bdi sysfs knobs
Date: Thu, 13 Oct 2022 13:11:22 -0700 [thread overview]
Message-ID: <qvqwv8oneb2w.fsf@dev1180.prn1.facebook.com> (raw)
In-Reply-To: <Y0Wz28QzRtH+72Pu@casper.infradead.org>
Matthew Wilcox <willy@infradead.org> writes:
> On Mon, Oct 10, 2022 at 06:00:30PM -0700, Stefan Roesch wrote:
>> 2) Part of 10000 internal calculation
>> The max_ratio is based on percentage. With the current machine sizes percentage
>> values can be very high (1% of a 256GB main memory is already 2.5GB). This change
>> uses part of 10000 instead of percentages for the internal calculations.
>
> Why 10,000? If you need better accuracy than 1/1000, the next step
> should normally be parts per million.
For current main memory sizes 1000 is enough. I wanted to give some
additional headroom. Parts per million is too much. In the next version
of the patch, I'll change it to parts per 1000.
next prev parent reply other threads:[~2022-10-13 20:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 1:00 Stefan Roesch
2022-10-11 1:00 ` [RFC PATCH v1 01/14] mm: add bdi_set_strict_limit() function Stefan Roesch
2022-10-11 1:00 ` [RFC PATCH v1 02/14] mm: Add new knob /sys/class/bdi/<bdi>/strict_limit Stefan Roesch
2022-10-11 1:00 ` [RFC PATCH v1 03/14] mm: document new /sys/class/bdi/<bdi>/strict_limit knob Stefan Roesch
2022-10-11 1:00 ` [RFC PATCH v1 04/14] mm: Use part per 10000 for bdi ratios Stefan Roesch
2022-10-11 1:00 ` [RFC PATCH v1 05/14] mm: add bdi_get_max_bytes() function Stefan Roesch
2022-10-11 1:00 ` [RFC PATCH v1 06/14] mm: split off __bdi_set_max_ratio() function Stefan Roesch
2022-10-11 1:00 ` [RFC PATCH v1 07/14] mm: add bdi_set_max_bytes() function Stefan Roesch
2022-10-11 1:00 ` [RFC PATCH v1 08/14] mm: Add new knob /sys/class/bdi/<bdi>/max_bytes Stefan Roesch
2022-10-11 1:00 ` [RFC PATCH v1 09/14] mm: document new /sys/class/bdi/<bdi>/max_bytes knob Stefan Roesch
2022-10-11 1:00 ` [RFC PATCH v1 10/14] mm: add bdi_get_min_bytes() function Stefan Roesch
2022-10-11 1:00 ` [RFC PATCH v1 11/14] mm: split off __bdi_set_min_ratio() function Stefan Roesch
2022-10-11 1:00 ` [RFC PATCH v1 12/14] mm: add bdi_set_min_bytes() function Stefan Roesch
2022-10-11 1:00 ` [RFC PATCH v1 13/14] mm: add new /sys/class/bdi/<bdi>/min_bytes knob Stefan Roesch
2022-10-11 1:00 ` [RFC PATCH v1 14/14] mm: document " Stefan Roesch
2022-10-11 18:20 ` [RFC PATCH v1 00/14] mm/block: add bdi sysfs knobs Matthew Wilcox
2022-10-13 20:11 ` Stefan Roesch [this message]
2022-10-17 7:45 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=qvqwv8oneb2w.fsf@dev1180.prn1.facebook.com \
--to=shr@devkernel.io \
--cc=axboe@kernel.dk \
--cc=clm@meta.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox