From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7D6CC433FE for ; Sat, 19 Nov 2022 00:11:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17FD16B0075; Fri, 18 Nov 2022 19:11:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 130F58E0001; Fri, 18 Nov 2022 19:11:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F3A6A6B007D; Fri, 18 Nov 2022 19:11:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E234D6B0075 for ; Fri, 18 Nov 2022 19:11:51 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C49B2C082B for ; Sat, 19 Nov 2022 00:11:51 +0000 (UTC) X-FDA: 80148263622.03.8225A37 Received: from wnew2-smtp.messagingengine.com (wnew2-smtp.messagingengine.com [64.147.123.27]) by imf09.hostedemail.com (Postfix) with ESMTP id 4E2EE14000B for ; Sat, 19 Nov 2022 00:11:51 +0000 (UTC) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.west.internal (Postfix) with ESMTP id 8F2422B05A6B; Fri, 18 Nov 2022 19:11:49 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 18 Nov 2022 19:11:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=devkernel.io; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1668816709; x=1668820309; bh=Zh0+uHjgzY D7ldqTEsbNdbOwiFL6yteWUBYRj+CHcgI=; b=rNSOHdLHJDT+FAS3o7AFaN7RrI U5G3OqxCI6R32QYiSVFC20y/pcozVLtPoaZhBxvqS7FfwL8rm9nB6tqOvUc9B7F0 X7+JcHlttK3gXf5BahGK3tyaSf/rHrMscN1K52hP4czWkF11tg8kMn9PEo8DN0xA 01fHZReI4WBFk8JqthPiwnR3bwnSrb821N3Udr3ddVE9TBpzl2qcpKGQGkp/GrjR koaiJS2+rji1932HaM0S0rZa7FthmR+5QzMGK70h1F8w6boovmle3KBqMi1iA3Jz yiJsp/Y8ZR4lKrWjJ5p6vh1yRyg8/Ubl9LHmTYcvDbjPGUU4VfWf9Vqx/8yQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1668816709; x=1668820309; bh=Zh0+uHjgzYD7ldqTEsbNdbOwiFL6 yteWUBYRj+CHcgI=; b=o9yHfHMWbXgOisMI++TPg78I9D8JT39PhWE2KJwQ7Xib JBmHJW2/XR0TYJMMFSDezAegORGZW3vgRdDfPZ2km8lBZAPk8PFIZ0ObVrEPERNZ 6uLTD1KUMCRgbXfyxyVqvFsf0gQ02wCV01wOHIPPk+kFTtiL+WZJ5QqmMij8Fbym kTXRIAgGCIfucM6a0OYOyqoFdzNc7G6Ji1AktkakqE7GZmCdzbU2eIPxvgARlHU8 d+s3NE4r4Kv4dPXdrR54nGCkHE3feu/5JLybsT0zGSqJVNUL9QmpdoXvy111/3Ne ZRoYx9W8QEq40BSbA4NORvdCwF36oUQgSXF4D2zfAg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrhedugddvtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfhgfhffvvefuffgjkfggtgesthdtre dttdertdenucfhrhhomhepufhtvghfrghnucftohgvshgthhcuoehshhhrseguvghvkhgv rhhnvghlrdhioheqnecuggftrfgrthhtvghrnhepveelgffghfehudeitdehjeevhedthf etvdfhledutedvgeeikeeggefgudeguedtnecuvehluhhsthgvrhfuihiivgeptdenucfr rghrrghmpehmrghilhhfrhhomhepshhhrhesuggvvhhkvghrnhgvlhdrihho X-ME-Proxy: Feedback-ID: i84614614:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 18 Nov 2022 19:11:48 -0500 (EST) References: <20221024190603.3987969-1-shr@devkernel.io> <20221024190603.3987969-6-shr@devkernel.io> <20221116132904.516884bc7eec135cfcd326a7@linux-foundation.org> User-agent: mu4e 1.6.11; emacs 28.2.50 From: Stefan Roesch To: Andrew Morton Cc: kernel-team@fb.com, linux-block@vger.kernel.org, linux-mm@kvack.org, axboe@kernel.dk, clm@meta.com, willy@infradead.org, hch@infradead.org Subject: Re: [RFC PATCH v3 05/14] mm: add bdi_get_max_bytes() function Date: Fri, 18 Nov 2022 16:10:43 -0800 In-reply-to: <20221116132904.516884bc7eec135cfcd326a7@linux-foundation.org> Message-ID: MIME-Version: 1.0 Content-Type: text/plain ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668816711; a=rsa-sha256; cv=none; b=ccYATrDf5cpfp9svz1EdkP4R2nFsVELkOF3Hv2nK9SPV8C+plAqgt+S5K972UlKEp6KeUi 37x9tWo6jkz4QHAKl7C6VneLhwpiPS314/kO+Vxnp1zZpp7qFeSYifAq6137rtmt4tpEtD zN1KuUeaBUPpyK8vutkTdN4p7U/p13w= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm2 header.b=rNSOHdLH; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=o9yHfHMW; dmarc=none; spf=pass (imf09.hostedemail.com: domain of shr@devkernel.io designates 64.147.123.27 as permitted sender) smtp.mailfrom=shr@devkernel.io ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668816711; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Zh0+uHjgzYD7ldqTEsbNdbOwiFL6yteWUBYRj+CHcgI=; b=XsoeIeMnILVGX/gyMM7zWEQVujkuRAWxBb0B7NpTLUDRYWbDevphgnmTjldErPVV/iWYOW NidvcBa0+jFbC82BoVIQl361HEkL/Ye8FxTOvOHnTcCEg9aHbXD+EZib/m7+pEzVEmF1Ph WEriX1UyrIemFUuVobEnybOvOyGpUds= Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm2 header.b=rNSOHdLH; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=o9yHfHMW; dmarc=none; spf=pass (imf09.hostedemail.com: domain of shr@devkernel.io designates 64.147.123.27 as permitted sender) smtp.mailfrom=shr@devkernel.io X-Rspam-User: X-Stat-Signature: c48m4fneyc8u9uc1xxmcr1a3ittk7pru X-Rspamd-Queue-Id: 4E2EE14000B X-Rspamd-Server: rspam11 X-HE-Tag: 1668816711-570747 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Andrew Morton writes: > On Mon, 24 Oct 2022 12:05:54 -0700 Stefan Roesch wrote: > >> This adds a function to return the specified value for max_bytes. It >> converts the stored max_ratio of the bdi to the corresponding bytes >> value. It introduces the bdi_get_bytes helper function to do the >> conversion. This is an approximation as it is based on the value that is >> returned by global_dirty_limits(), which can change. The helper function >> will also be used by the min_bytes bdi knob. >> >> --- a/include/linux/backing-dev.h >> +++ b/include/linux/backing-dev.h >> @@ -105,6 +105,7 @@ static inline unsigned long wb_stat_error(void) >> /* BDI ratio is expressed as part per 1000 for finer granularity. */ >> #define BDI_RATIO_SCALE 10 >> >> +unsigned long long bdi_get_max_bytes(struct backing_dev_info *bdi); > > We don't use unsigned long long much. If you want a 64-bit unsigned, > use u64? > The next version will use u64. >> +EXPORT_SYMBOL_GPL(bdi_get_max_bytes); > > Is this symbol to be used by modules? The next version will remove the export.