From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 997E1CE79AB for ; Wed, 20 Sep 2023 16:29:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 358336B0080; Wed, 20 Sep 2023 12:29:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 309536B0170; Wed, 20 Sep 2023 12:29:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D0056B0178; Wed, 20 Sep 2023 12:29:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0EDD96B0080 for ; Wed, 20 Sep 2023 12:29:25 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D3C528039D for ; Wed, 20 Sep 2023 16:29:24 +0000 (UTC) X-FDA: 81257511048.08.A9E63DB Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by imf14.hostedemail.com (Postfix) with ESMTP id 7519D10001B for ; Wed, 20 Sep 2023 16:29:22 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm3 header.b=RdvBM4aT; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=oj5YYpNd; dmarc=none; spf=pass (imf14.hostedemail.com: domain of shr@devkernel.io designates 64.147.123.25 as permitted sender) smtp.mailfrom=shr@devkernel.io ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695227362; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dRx230nt4NjZWtPiovmpTS2FKilrb+bo4roUw7JE65U=; b=lrVq5z30FbHs1zKdTPFL9hYbBQGSQj4ZxebjZA0EuxQ8ZyPgb6XwnJYXpL3NJL9n1kA0UY h+cuS8MSXbs3CtROJ4n+EGVWAODqrG93uPthxRrIfrQ/Lfx0Yj3Ki/EkYxV/gEg+Thtq9X D5QFF7jX5PC4Wh2yyTKv/3X8RF1tNiM= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm3 header.b=RdvBM4aT; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=oj5YYpNd; dmarc=none; spf=pass (imf14.hostedemail.com: domain of shr@devkernel.io designates 64.147.123.25 as permitted sender) smtp.mailfrom=shr@devkernel.io ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695227362; a=rsa-sha256; cv=none; b=omjNcrrC6bjIq/z5Hdu27oIGCrbQ0KscJK5wISn6/XnZCpx55WwF83j5ItFK1HnI165pCR IYevgA/eOQ0Gu1+eOGChhi/RktWg9606VGAJTB6Dchlyq1EzwxfmWb+eqL7nnzPBMxdOiI gZcklw8932BatO8BtqD4hT/iXsYHCSw= Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 1C1D03200959; Wed, 20 Sep 2023 12:29:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 20 Sep 2023 12:29:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=devkernel.io; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1695227359; x=1695313759; bh=dR x230nt4NjZWtPiovmpTS2FKilrb+bo4roUw7JE65U=; b=RdvBM4aT024PvV0gRj APTMtWxLswJw6xGUQbAqFsxLDnkQOF1fZ71Xq9uVHmIOS4CFTuxLYv9Nk4UXeEJT ROqeM5so1Ym+iFtOy/cxiRXq32ORPAkt+RdevW7LHtljjnIEC5kQhG6lp52t0YME jELUAKixn6ikFyY7xom8KBhE4+Qd8NiEqHmjXi/t7+vZ2J3dP3HQLibr9grfZuez EBuogKVlbLpokyZjpa3bGOZfIogIAYGeB0vXmZx6nPuXHYJ+tHT1CGoive0fQq16 hxvhtlHXbnY407PcGdQWxzHqx5YGT0F1EgrYdfMg3I8NcYRRXPqBBZ/nwaTFbUGI n8OQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1695227359; x=1695313759; bh=dRx230nt4NjZW tPiovmpTS2FKilrb+bo4roUw7JE65U=; b=oj5YYpNdpnmimqf6QHwn9hCnXiZfG LIhxpErSJ8pwPrY7oNxlWxrX8zN0cR7ooCNFfLt+MleJHz/OpV6K3gsoffqPWmqT ZZ8p2+EeiWIE6ORx3r+O/eeQET/j3PWvFZjprFt6j48bMHz/0WBOGhiF+lH0LUuv nkBqt13dWrIdtt2g7WYVqxGMYn8nyCckgynKMOJ05dh1NilKwJeDiF6QLkBVxs4Z gB9+7SIlHXwtkm7pSlSaH2O2Iv+XXI177YfQHDAkAatoE0wMIOMWx5M92rUuIflz T1Jx2qoD3OvFDC+ZbukvsjbZ7QelCQCaG8uF+dWH5Ve+JaEDFg9pA36CA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudekfedguddtfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enfghrlhcuvffnffculddvfedmnecujfgurhepfhgfhffvvefuffgjkfggtgesthdtredt tdertdenucfhrhhomhepufhtvghfrghnucftohgvshgthhcuoehshhhrseguvghvkhgvrh hnvghlrdhioheqnecuggftrfgrthhtvghrnhepveelgffghfehudeitdehjeevhedthfet vdfhledutedvgeeikeeggefgudeguedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepshhhrhesuggvvhhkvghrnhgvlhdrihho X-ME-Proxy: Feedback-ID: i84614614:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 20 Sep 2023 12:29:18 -0400 (EDT) References: <20230919205158.1897353-1-shr@devkernel.io> <20230919205158.1897353-2-shr@devkernel.io> User-agent: mu4e 1.10.1; emacs 28.2.50 From: Stefan Roesch To: David Hildenbrand Cc: kernel-team@fb.com, akpm@linux-foundation.org, hannes@cmpxchg.org, riel@surriel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Carl Klemm Subject: Re: [PATCH v1 1/2] mm/ksm: support fork/exec for prctl Date: Wed, 20 Sep 2023 09:29:00 -0700 In-reply-to: Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 7519D10001B X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 49spp4uo5dittisxg1w7iycc8m9if4o7 X-HE-Tag: 1695227362-492095 X-HE-Meta: U2FsdGVkX19kqpPeo/P061hHqlxHFGAeAf38OLk93bVIU8nneABZeilF0rILqM37Memg6JjSSak0lKwp6aA8Fc8oQL5VRVpOpQiiSyBmQqmQSjhNhm6atllvD1ffkbbOA18U1gyGi1ciB8/Ne7smDorXjRk26MX0s6HsF1VouKDRLpP3UYJeR5r3GSRDewaWSC81oCVd5OvlzLB5PrhMJp4/wIauHLpmFzRHyFJXWpRY58eiiEzgieT9QUsAeJPsP0bWssSqKlnmskDCc9284CZl0St4ehbdpKzvqN6q+TjsfTB/NUkPYv9GtzBITc+OKDZoZTml3QNLeRZzU1jxzGeQo1yVLAjM1cbDJPoxrv0+dlv8jCP0oXvXC2jvxEG0Eew7+dr6IyNnpIIbaxjr+WaMPhx1Pw8fRE/NIOBb4GmQA2Cr5k2UyYZZy1hgqBr+e3PSFOZRHzJUZno4LseY0mVFT6ex6bhLCjOQ9s7QGhLMLkgCAZ7SpmZ4jsjUc1Q+ted6c7ric9maSlP6xiuen3oib4caNQ1wC70TfWu2gs6YwMeqN3YXSiYD6rKEs8sBqWegVwFmD6QAdTd27QuikxChtNXsJanlo3py4zSLerX0kDJm+rcFCXW+RQvOFdumHPCCVBLuLoqo07kCwVkp0q3p3t4WaG2SJV3XWpvZCTWhA0YJBVgJDoZafEiBvcaNDYisGc3fv5p6XSybiBu1KFK+nJV3JIF4TgYUW9Fb4RhEPDrRu3x2ZKeE7tj/TyalGQbgmAjEepkjQybYR2eHhsLfx2YQUmp+7GgtYFh10J9Gj/pB+MfWMU61E5nC2H6xVbfI9GInKQrc+vVv6qUdUMNfeZko2EJHyGpxJofSv3/2Hy4YKPrsvHX06meRdwcsqGi+mJzG8MaMo7xR4RvACsXYvxJXskfYpVgmf3kGTU9QfzPu6NuSrQ30iVzcDrSCuiCVDdlD1+uPnhLXv+W CYEdjmvN 4RGrIjSz0zDyjKGhuAABp6UWjwbcS4tCGAQhMscO7ORPKOxTGsHm3H6WhSCXkTuw/EeINc79MNdE6HHfNFYHP27lG1PO5yqtlQtysIMf5aQeJcz4UvrUgIeMDJgz1E7lEPZqlai7jD9r3SDmqA/1O4/WqWdQzrS8tMIcbjI43yle2S2s9wA6mDpWYlp3/WYWsM/NvfYEXLp5gqdlsxxpCCo9inBX5SN2+1fXFI6njkrD9D7ugo6/XB3NpPPA1YEPk7B3XHLk2mD5UY51T8UEoy37fFNavnU6TgmebWPsLgkBVFxoeRAW8J81+DxXdfhNYS+2u X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: David Hildenbrand writes: > On 19.09.23 22:51, Stefan Roesch wrote: >> A process can enable KSM with the prctl system call. When the process is >> forked the KSM flag is inherited by the child process. However if the >> process is executing an exec system call directly after the fork, the >> KSM setting is cleared. This patch addresses this problem. >> Signed-off-by: Stefan Roesch >> Reported-by: Carl Klemm >> --- >> include/linux/sched/coredump.h | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> diff --git a/include/linux/sched/coredump.h b/include/linux/sched/coredump.h >> index 0ee96ea7a0e9..205aa9917394 100644 >> --- a/include/linux/sched/coredump.h >> +++ b/include/linux/sched/coredump.h >> @@ -87,8 +87,11 @@ static inline int get_dumpable(struct mm_struct *mm) >> #define MMF_DISABLE_THP_MASK (1 << MMF_DISABLE_THP) >> +#define MMF_VM_MERGE_ANY 29 >> +#define MMF_VM_MERGE_ANY_MASK (1 << MMF_VM_MERGE_ANY) >> + >> #define MMF_INIT_MASK (MMF_DUMPABLE_MASK | MMF_DUMP_FILTER_MASK |\ >> - MMF_DISABLE_THP_MASK | MMF_HAS_MDWE_MASK) >> + MMF_DISABLE_THP_MASK | MMF_HAS_MDWE_MASK |\ >> + MMF_VM_MERGE_ANY_MASK) >> -#define MMF_VM_MERGE_ANY 29 >> #endif /* _LINUX_SCHED_COREDUMP_H */ > > Fixes: tag? > Added fixes tag > Reviewed-by: David Hildenbrand