From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61D9BC636CC for ; Wed, 15 Feb 2023 23:00:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C4AC36B0073; Wed, 15 Feb 2023 18:00:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BFAD26B0074; Wed, 15 Feb 2023 18:00:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC31E6B0078; Wed, 15 Feb 2023 18:00:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9D0F26B0073 for ; Wed, 15 Feb 2023 18:00:39 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 67C361A05E0 for ; Wed, 15 Feb 2023 23:00:39 +0000 (UTC) X-FDA: 80471047398.09.79B30DE Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by imf07.hostedemail.com (Postfix) with ESMTP id 6339940004 for ; Wed, 15 Feb 2023 23:00:35 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm2 header.b=mgmKMDn4; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=CHVUbv05; spf=pass (imf07.hostedemail.com: domain of shr@devkernel.io designates 66.111.4.28 as permitted sender) smtp.mailfrom=shr@devkernel.io; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676502035; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MrWeqROBy78sov0ovwkYg7pAjNANSucFXmXbGwmSYkQ=; b=NpBrX8Z9sA1sTAcD65M86oiSwm0NU37y69thVe7yNsiYssKRbxhGeS+QSbhfWwsAYngYt4 t5QqSD9pH+/4kSJsQ6ybhUhjFtzOYOtBM/mL9holiCzKpQKJQp3qjM2KGrztWrX4xgTK0q K1MYmPH7EIZdlQ89bUHHqQrhnSL3nmw= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm2 header.b=mgmKMDn4; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=CHVUbv05; spf=pass (imf07.hostedemail.com: domain of shr@devkernel.io designates 66.111.4.28 as permitted sender) smtp.mailfrom=shr@devkernel.io; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676502035; a=rsa-sha256; cv=none; b=C8Y5ccKV4yX1C8frnut1rVUNVIoeEQluf1edG2B1zzvBDH8rp4bXQBO5OJrg9jovZC4zjt yxKwvlFnhwBi0LptANpdpDOEVQ5MRs8DSVVfZv8EyTPhumTCnRcMGZEjuc/DaboqanIZPt pDXLbvXcDxBAMpYHMo/47rDG7Y1gUzU= Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id DBDA45C0179; Wed, 15 Feb 2023 18:00:34 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 15 Feb 2023 18:00:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=devkernel.io; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1676502034; x=1676588434; bh=MrWeqROBy7 8sov0ovwkYg7pAjNANSucFXmXbGwmSYkQ=; b=mgmKMDn4/TElWl/eOWdhxAuGrR BgGmw6BMGSW6v8BLSEw+nYeu3dWps3yIwPfkg6KNcvFHQBQBKkPELgWH3MnDoYl7 LghpnTRdRLuzMVg4+TLA33cBOVKiLVGi8+przHq9FWg8tEzBSmTlrWKZkjc554ZK FrZaKjnAyXDhpdOqTBWYKLOksJZreurAAJoz91LK9TPOypPRseywLhEcq0+6vE/r b7zXyu0qzlrZjcP3Iy0NO/V85fHoR5YN4yXRkK6I24IzhGCxaPhTQeEa4/WrOsiN IMklQDbtO5zwKZ9b5I9hFOZw65CH1sYtuXSEBxYedNbDrfB+yU4MYMxqjtqg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1676502034; x=1676588434; bh=MrWeqROBy78sov0ovwkYg7pAjNAN SucFXmXbGwmSYkQ=; b=CHVUbv05PgEWr/kLEYBI1bK6yhdn+/uQSD2ZjDj14yNk T2kI0ClE/wWQbBXgMAj1idVQEz+r5E7abJDt9BYvg63wB3zwKBK88W03ZyT7VvyN 6fJIKNNw4rQh6lZGO8MQLPTA9E+C6dQUniXgDLZvwQCDBQpN1DzmdCATqFfAe5Hf LZsldOJYyciu7qIvLF/dx0xf+8S0gNkJBPQ1T+hEhencimh7Z40Qs3bqvs7cEJwT gSe+hYCHNkvC1oCUYLXrUCT9qk/zdQ18XqOV3ZgQGj+V5sSQTGAUgMMiVMJjf/6p Q40qvZhsnb2nTfZiyDKLSiyHbWaIj05lWXuRs4B07A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeiiedgtdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpehffgfhvfevufffjgfkgggtsehttd ertddtredtnecuhfhrohhmpefuthgvfhgrnhcutfhovghstghhuceoshhhrhesuggvvhhk vghrnhgvlhdrihhoqeenucggtffrrghtthgvrhhnpeevlefggffhheduiedtheejveehtd fhtedvhfeludetvdegieekgeeggfdugeeutdenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehshhhrseguvghvkhgvrhhnvghlrdhioh X-ME-Proxy: Feedback-ID: i84614614:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 15 Feb 2023 18:00:33 -0500 (EST) References: <20230210215023.2740545-1-shr@devkernel.io> <20230210215023.2740545-10-shr@devkernel.io> User-agent: mu4e 1.6.11; emacs 28.2.50 From: Stefan Roesch To: Bagas Sanjaya Cc: kernel-team@fb.com, linux-mm@kvack.org, riel@surriel.com, mhocko@suse.com, david@redhat.com, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, akpm@linux-foundation.org Subject: Re: [RFC PATCH v2 09/19] docs: document general_profit sysfs knob Date: Wed, 15 Feb 2023 15:00:15 -0800 In-reply-to: Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6339940004 X-Rspam-User: X-Stat-Signature: oqo75us9j4y8t5t8q7m95zn1ofauyqsa X-HE-Tag: 1676502035-688280 X-HE-Meta: U2FsdGVkX1/XTJDzwta46yUGaedUI2XDbNAk1ctnbWzBc8XesbZKgnBhpV7F0kwmWiXLkz6gMLRQm7ch76MtCih+SDyghHifJb7T4WxHfIO/fGnATfnjYqCxoQUvmPn/Jn45mNFIsyVq9hXOemz7CJ05P2y85yHIN0fVsiWWWM13jv3U3pE/ASfYZekJUadGiQyACbay16OB1OXA2vCLiCsQ449qsPP2/1zO0eaywglG5e2fDfn26EvMOKgo4e5sfWyNTc7/GHPFSUHh/tEi91kYSI7cUVf2eFuk5JCz2ohYUHsuecYdYU2iPq7msHgEDC3EY3Ngk0YC2O8NuohGhw601xnA1L9UnSjUPsVrAywe+CeK+HATmtvQq6WiqUaG53MDYNzSdC1OHNNO7vDtezu1yZddzVSwjKdNNgVVwSCDjyoVtXXOlT0/0LaXx1rv7Tj/O8569Ry8YPtqA1J+cP3ScEvUB5GJNCnLkl+WaGe7tzIbeM/uhI/Cr1M9VuF0MkUk9qgV3QuYYUnl+1vhFL+3BLd57JqW3JxR7LUIWRJg7a09/PMAt1kL+U3kBrLTKHnbpYwmkB3C/9vBDRf02FO9FACwRZyUQ4u3NNL/0mkciwU4bPE7bmtia5rgqTx+ITVzpeL+wEEBC8c0a2zqDo1dkKXPl/TZlj3eE88HO6FuWbFFXRwTot3iLBGE2n591PoxgvxM7Vr22Cd8u8dsCmyNSweCcU+t3ra2Qe3C1NBC2iI6WU4Yqp10Ty8eO/HTtQGKUDEjgS7xM7E41U0Pk5X5tvCvy2SxzYYLZACPhqNq0sLq6XVrtpFS2ls7y4a5qzoLWXXFiBZzl+bGVSuCc1bz21t8WT5vnvjbauyTNiabL19gNyxPTlCLQgiYUMPPT+3NwBeiClGCriBsFGSjkkAZS6ZKdWqzllPedfSHl1cWY7mgkrjLrpRX8M2KIxRwC9Om349JWjqcmTvDJQb DNaRRx5/ zhsH7hTxTHzMPlh/TMmXoJ2NSlUs8ebVwaCDBty2QRW8i4KM/rjr5ufOhGRlEePt4e+19VX25c1roqxJpqGe2NMSSiPouYhrwMircG/UEPtHiWKjuOYbZ595IGrSdSmR2jo8YkF0Ta+ACefTaabtOvqejQC1EbXDiyOHg8l1NnmQ9Cc8hpLHHqx8WL83sjFeFP/Vo6hLMrOSeG3sH3G7unNUTe/q1TH97RPv5VAkWaLjoyEHNw2PMznWPoCcs2wSbAc6gX5d0tDyxRz/9XhSxdg7JTp9Qe8sGcTlr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Bagas Sanjaya writes: > On 2/11/23 04:50, Stefan Roesch wrote: >> Document general_progit knob. > > Book about Git :); it should have been general_profit. > Thanks, Fixed. >> diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-ksm b/Documentation/ABI/testing/sysfs-kernel-mm-ksm >> index d244674a9480..7768e90f7a8f 100644 >> --- a/Documentation/ABI/testing/sysfs-kernel-mm-ksm >> +++ b/Documentation/ABI/testing/sysfs-kernel-mm-ksm >> @@ -51,3 +51,11 @@ Description: Control merging pages across different NUMA nodes. >> >> When it is set to 0 only pages from the same node are merged, >> otherwise pages from all nodes can be merged together (default). >> + >> +What: /sys/kernel/mm/ksm/general_profit >> +Date: January 2023 >> +KernelVersion: 6.1 >> +Contact: Linux memory management mailing list >> +Description: Measure how effective KSM is. >> + general_profit: how effective is KSM. The formula for the >> + calculation is in Documentation/admin-guide/mm/ksm.rst. >> diff --git a/Documentation/admin-guide/mm/ksm.rst b/Documentation/admin-guide/mm/ksm.rst >> index f160f9487a90..5c4daf44d79d 100644 >> --- a/Documentation/admin-guide/mm/ksm.rst >> +++ b/Documentation/admin-guide/mm/ksm.rst >> @@ -159,6 +159,8 @@ stable_node_chains_prune_millisecs >> >> The effectiveness of KSM and MADV_MERGEABLE is shown in ``/sys/kernel/mm/ksm/``: >> >> +general_profit >> + how effective is KSM. The calculation is explained below. >> pages_shared >> how many shared pages are being used >> pages_sharing > > LGTM, thanks! > > Reviewed-by: Bagas Sanjaya