From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59CA4C6FD1D for ; Fri, 7 Apr 2023 04:11:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D2DDF6B0075; Fri, 7 Apr 2023 00:11:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CDF7E6B0078; Fri, 7 Apr 2023 00:11:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B09B46B007B; Fri, 7 Apr 2023 00:11:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A29AD6B0075 for ; Fri, 7 Apr 2023 00:11:16 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7572214027B for ; Fri, 7 Apr 2023 04:11:15 +0000 (UTC) X-FDA: 80653270110.26.EC3201A Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by imf09.hostedemail.com (Postfix) with ESMTP id 6332114000F for ; Fri, 7 Apr 2023 04:11:13 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm3 header.b="bfiG8qa/"; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=pV8cz3kW; spf=pass (imf09.hostedemail.com: domain of shr@devkernel.io designates 66.111.4.25 as permitted sender) smtp.mailfrom=shr@devkernel.io; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680840673; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E3JXUV5UUgPlKf5dpq97quPJmII3uTDXsdz2sFl5eaI=; b=LDxXotr5UVROykLmy0d5hK7bPmYRX/xYR3zk8dPdNQZVArSQu14kYEdB9z1voIQJfiWEwu yn0yJdCj6gawHnnic6B4yt8fEYyRx3XcDytrCUDKD9WpJKIzYqbwRELbXkH89W8OzYNeMc Ue8kZX6OXjIArdtXnC6DRggXzvudyF0= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm3 header.b="bfiG8qa/"; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=pV8cz3kW; spf=pass (imf09.hostedemail.com: domain of shr@devkernel.io designates 66.111.4.25 as permitted sender) smtp.mailfrom=shr@devkernel.io; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680840673; a=rsa-sha256; cv=none; b=NPPvB4EN0qEl6uaVqs+DgWaS7oheyQQ6eoNRN5D48t7PxBcrMElcAN7DO01FTrymQn3F0Q tC3QzK9OVHBzu+PjrKku5LfNdmsdb4r63kVdx/nyQZjp2fJTqb68kY5CaUR+kLYk7DQ9cv TBuN9iwlHqWtrJ7IYg9qVTxusfLNruI= Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A59405C039E; Fri, 7 Apr 2023 00:11:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 07 Apr 2023 00:11:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=devkernel.io; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1680840672; x=1680927072; bh=E3 JXUV5UUgPlKf5dpq97quPJmII3uTDXsdz2sFl5eaI=; b=bfiG8qa/vSe0uR3INz 6onmEZ/D3PSpSmoUw1TiNuvi4HIewyrANpL3fGS8fGGWNQDJA202R0jw1bsOotId ME2wkoHQn+LHNcbnCmDozma3czMtI4ATCBafIa/zVXDdoHYLlyEi0Wgsy5s2ayjo JTT8Dam7ZdmC4EVgzlkgmmx4xFUzL1MKUQCX6tHK3WB68cgPliKGSeM/qSFtB4X+ 2fyCeWAiUuEiByYjBP/udswJwIg4lPQHb6+vYUk9yOarSnJneazdZ0nIyNKk4f+l 3EOc87eqnVDWyn/7VMuaobsIsysxTNds/c7Cg3sXXaLJp644zuBx3+xJLmevs57S ORJQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1680840672; x=1680927072; bh=E3JXUV5UUgPlK f5dpq97quPJmII3uTDXsdz2sFl5eaI=; b=pV8cz3kW7TxJd9suysUA02sEzDpXd ULPmkh3DWcFL7dTvwDNcGO88T9/rwsnP+j56ykxoMVrDe3J1bQ7++YqvXKCX4FTF XxK01E6ITmddJelnCAfJANiU6SZZGzo8bMbJ48a3WcpK9dP20ULxB6thL0HQD5KD p2DFLsQClqIM44ECWl1iQf21q3NypvGGguFAj1ZEqw61BY3n/osMqxkXypUfQWdB MRBaUj0jBKbV50kKBY5NfC9wGCKb9ZnY7EATf8GOj3Kx8y2RTu6eRvCy2R7LpTt/ yUruCdf45LRq6+DUsTAaS3qWYUffmIO8PeAXC7C7jO2VFi4LWLAt7e8Cg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdejgedgkedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpehffgfhvfevufffjgfkgggtsehttd ertddtredtnecuhfhrohhmpefuthgvfhgrnhcutfhovghstghhuceoshhhrhesuggvvhhk vghrnhgvlhdrihhoqeenucggtffrrghtthgvrhhnpeevlefggffhheduiedtheejveehtd fhtedvhfeludetvdegieekgeeggfdugeeutdenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehshhhrseguvghvkhgvrhhnvghlrdhioh X-ME-Proxy: Feedback-ID: i84614614:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 7 Apr 2023 00:11:10 -0400 (EDT) References: <20230406165339.1017597-1-shr@devkernel.io> <20230406165339.1017597-2-shr@devkernel.io> <20230406162957.57fa69a46691a97d4600f444@linux-foundation.org> User-agent: mu4e 1.6.11; emacs 28.2.50 From: Stefan Roesch To: Andrew Morton Cc: kernel-team@fb.com, linux-mm@kvack.org, riel@surriel.com, mhocko@suse.com, david@redhat.com, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, hannes@cmpxchg.org, Bagas Sanjaya Subject: Re: [PATCH v5 1/3] mm: add new api to enable ksm per process Date: Thu, 06 Apr 2023 21:09:23 -0700 In-reply-to: <20230406162957.57fa69a46691a97d4600f444@linux-foundation.org> Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6332114000F X-Rspam-User: X-Stat-Signature: 1p1qgf1c1freeqhtx9ormik58jnboiu6 X-HE-Tag: 1680840673-896961 X-HE-Meta: U2FsdGVkX1/xMDJ83w7HDm2uXLGiu7psoM0pz8rc4QvQEYBRuhDsFGqlSC036UWtWvVEfVyRwBbUQH+erN8z8uVpjj4asRJUnsBLTd21HFhk7irRJYSWavvBITloFGuuCpkDkj8Zfuz3C9y6JWowNlIBTh/dJ7T+VmcDHRF4yhwKTcrt7smhl0j4Su07uOVQV8dRVCdbbFvxFan6dHBGE0nP+leQfpT6IGYVhN8cHcHvaJZv9dws7DPOBz9NtQqPfB5RMJUYhKS+41G7WcpSReFwukGW1tEu1BTlbGyyo6bApp2gnEUTFnGxh+JEHp9a1fClSD5AiYXRHG9vNzbEWBBmaiUP4kNH3I6kVetF4e6buLMa5Q2rntRz5RjINvTsRtan4Mw/oTUiqJt5TQPQXzov95NqZhwf7zvlA2trtnoQpiuVOAO8Ct8dknMoO5nQ6ALYxIeXi2xtfzLAAdkaRo1QFcUZrkJB8AF+2ycA8Gj0G5GhmK76BxOc/xXjBIG3UVNBbL8gz5oec9WM3dibrX9ZYjDVuZEhVXRJqRoE/gt7wnORHK+CAgHGwK5R8mG1D/pGqQTXN7RVUIWW9mtU48RHJRLsUtH7yf6B/ygojLuzM+Tpd8h1xntWRQ3pvrC33BCGoubBi8PthA7LiNm0gG6B0HmHplKLlHnmBHBlDQaSUQS3PQdxS0++gYSo/kD1wtWm/cbrwOhxfIYQVtIlg6oiFuH66aZ4UJLtABy6DUH6vP1Lz4vMo9/QsamwU/CdAjhA25xA89juz0TiqtFFGwRPxkaW9p8SlviRtep0t2H5Mqobaq9Cw4Sby8ydV6d8HCOlZ37BjsCU9E7T8sZqjm7mbev/71wHn1jvWdHp3TsNb1OITfHljB+yr1LptWA02Eo5EiaaDLfzM/9k8jZ1sw43OEzSuY+9wtEpew07RrErgOx8G9PCVXjwehsajx2dMXuHs9GuUbawnbSYaQg w8SA/TY1 Q29QgSADSSz6eiUbH/GVfSXc0DYExTbLzIXC224WbiTlm4vWXQSW/taLSoDsYyFYRBEgCS/ZY5vPJSvbZZeBBpNU0NswHXP059m29ggUXv7SROz+1bAZXWWXuf65/jFPq0fIuBzW78xEAh13Cj1Y6OsJe0caeRpaSC1n0Hd0d0PjwZD54N4UtcatvFj53s6ERC46l X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Andrew Morton writes: > On Thu, 6 Apr 2023 09:53:37 -0700 Stefan Roesch wrote: > >> So far KSM can only be enabled by calling madvise for memory regions. To >> be able to use KSM for more workloads, KSM needs to have the ability to be >> enabled / disabled at the process / cgroup level. >> >> ... >> >> @@ -53,6 +62,18 @@ void folio_migrate_ksm(struct folio *newfolio, struct folio *folio); >> >> #else /* !CONFIG_KSM */ >> >> +static inline int ksm_add_mm(struct mm_struct *mm) >> +{ >> +} > > The compiler doesn't like the lack of a return value. > > I queued up a patch to simply delete the above function - seems that > ksm_add_mm() has no callers if CONFIG_KSM=n. > > The same might be true of the ksm_add_vma()...ksm_exit() stubs also, > Perhaps some kind soul could take a look at whether we can simply clean > those out. ksm_add_mm() and ksm_add_vmas() is not needed. However ksm_add_vma() is required. It is called from mm/mmap.c