From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21229C77B7C for ; Mon, 17 Apr 2023 16:40:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A4936B0072; Mon, 17 Apr 2023 12:40:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 853676B0074; Mon, 17 Apr 2023 12:40:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7429A8E0002; Mon, 17 Apr 2023 12:40:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 656AF6B0072 for ; Mon, 17 Apr 2023 12:40:42 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3F08A1C66E8 for ; Mon, 17 Apr 2023 16:40:42 +0000 (UTC) X-FDA: 80691446724.23.B7A9280 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by imf02.hostedemail.com (Postfix) with ESMTP id 2DFE880006 for ; Mon, 17 Apr 2023 16:40:39 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm1 header.b=MzPxUJ3U; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=ZguVOLyf; spf=pass (imf02.hostedemail.com: domain of shr@devkernel.io designates 66.111.4.28 as permitted sender) smtp.mailfrom=shr@devkernel.io; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681749640; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BXhqaNdZoSfWVMrAt/T4aVq7tNwxkU+VJy/AREti7rM=; b=IZ359Se2NfS0fxhEg5J4JbYdNXXaomeJsSvybQdv8n1+GNcoxRcfFKB3pnjh0NSvU0ny6Y qxWt8VHDI4IstiEqXEQKzTnaP7/K4NFe0u3WNrJZvVh9Gt+AukktZ6EzDog2/NSE3g2woy P97YqpXUnKKuouX6uuZyBKwlDLXSDHM= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm1 header.b=MzPxUJ3U; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=ZguVOLyf; spf=pass (imf02.hostedemail.com: domain of shr@devkernel.io designates 66.111.4.28 as permitted sender) smtp.mailfrom=shr@devkernel.io; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681749640; a=rsa-sha256; cv=none; b=w/UJ3wMcQc4GCVMZfR3HMBHv8mehzXpmvGBO9qEXUTZ/RrNWOMoXe6Fs6nwVc26mCis9oY 9Y7gTjcvjX0m4PBMwFZF2WrB7b7+M/ouq3jSqRm467XHvdkH//6e88UTgOyeqSdYJZmPpW 8ohRjppdom9E6ltWcDFl9svyEBuhm5Q= Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id F00CF5C01D3; Mon, 17 Apr 2023 12:40:37 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 17 Apr 2023 12:40:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=devkernel.io; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1681749637; x=1681836037; bh=BX hqaNdZoSfWVMrAt/T4aVq7tNwxkU+VJy/AREti7rM=; b=MzPxUJ3UmwYBJognTb XPWvNxa7bzSLI4adjiLIm5xQkLSmahFWwMrI0+oh9osJ+NXS+vlJEwA8b+DKAAGY 7dLD3t1xFTg5TB0D0z+nR3R3aUAiAxtwPqUGWkaM7UsLgc+LC7SqIDANDRkJjgVv EsSbnrUu7W7WMP3PCJ13+9IKcS2zoAlmr2zYCdnor/3DLsD7VQSBc9abuBTKQ0m1 arhrlxeymtX9GZYv+0Sk1OEMoiH2S1IpvsJY7v2KC8sT9KSQ7dafPMUfmRl/TNne guyIN/ul4mN2itFMh6vjm1kCQGqBdg9chAENPyGFReuyGsjoSdTVdL2FVCMTsJum kNkw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1681749637; x=1681836037; bh=BXhqaNdZoSfWV MrAt/T4aVq7tNwxkU+VJy/AREti7rM=; b=ZguVOLyfeRNG+jVKyJZD4ON/zyxtV NivALjETnZEMOMN+LkELs+wytylULWKs8N2F09xpSIQM8G04U2WTX+67SVTzccqH D4IoLrShT264KJqQWFepvv40Ma6tY6JIKV/a7X08q3CmPHiq1jt7sypD1yVbZeXn XIQ5uUR9BbmV5HvfPMAg+mI+8jRnEc/BRVSzikFtaymM/gUG0Jqlg+OhZ4IPnT2p Mucnw7ILKzq5K6hOlNYQazQJq9DRaPkbbgWEYXXVldn4FiDxbd48lZE7L6J5oAcK 29jPVt0tJfPnWmHcghHDI1iIRld65jmjU2pym7tDrPU7EpcBVmw3ID7bg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeliedguddtfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvfevufffjgfkgggtsehttdertddtredtnecuhfhrohhmpefuthgv fhgrnhcutfhovghstghhuceoshhhrhesuggvvhhkvghrnhgvlhdrihhoqeenucggtffrrg htthgvrhhnpeevlefggffhheduiedtheejveehtdfhtedvhfeludetvdegieekgeeggfdu geeutdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hshhhrseguvghvkhgvrhhnvghlrdhioh X-ME-Proxy: Feedback-ID: i84614614:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 17 Apr 2023 12:40:36 -0400 (EDT) References: <20230415225913.3206647-1-shr@devkernel.io> <20230415225913.3206647-4-shr@devkernel.io> <355f42d1-4354-376d-ab27-7e55d06e64a6@redhat.com> User-agent: mu4e 1.10.1; emacs 28.2.50 From: Stefan Roesch To: David Hildenbrand Cc: kernel-team@fb.com, linux-mm@kvack.org, riel@surriel.com, mhocko@suse.com, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, akpm@linux-foundation.org, hannes@cmpxchg.org, willy@infradead.org, Bagas Sanjaya Subject: Re: [PATCH v8 3/3] selftests/mm: add new selftests for KSM Date: Mon, 17 Apr 2023 09:40:19 -0700 In-reply-to: <355f42d1-4354-376d-ab27-7e55d06e64a6@redhat.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 2DFE880006 X-Stat-Signature: atm4whdmjocs1zaqa355g43qf7sq6ro9 X-HE-Tag: 1681749639-544590 X-HE-Meta: U2FsdGVkX18GM5Gk/PCesJ4bLSsvYcTAHaArFb7fhZH9ENzx/INLxSJsZqL4n0dZUT6YVOgsJqm7Mnt1Ma3mGIxzliYsJZ3tWX8peZuWaHjQiZ0mDR7QgsjMxCBAmxZK2p0FI3zloe9KpO4tQSHu+7aEUwH6j1BiaqYJmrF4EWEpvmlYF5G4bkHnpVeJAjDoIPyLyd36JwSXvIMUBcXhtf/SeA/+G48KUS2MFSWcXk68SzuCQfBpN/UNREYwGPlnFEtF60P0reOQe3UGfptqIsc8pxf0iol0QC8fe3zmKgH8YWl63CFGfb7wJX/4QOa/zf3VC5CYMlv0Cm+oKqTRR03WxkKSGi0oamaAfdUTjJuHLslN1vM1Ln1v0/q5E+Qnz2X9/auD1ixOLsXU151aNkhJLHIlMdB1MbszDUCgBpijjYnXL4JWbZb8Out7ChYRpSKqBOGlbLZB5smalnWq+6FCAbGudRxsGoa9BzKggbc4nGGKDlkEEx8R3Hgd4Bh8LwTnnNNW/Xx4F620797+qp2C7CqkKaSVbzUlDnEl9PODhrmw6zmAOFqAsLnurpyfzyN8OwpB3wlzEKnNwl5oQkyKUeoVJxfhNL/ON6DLT3FnFO64BhFaJ4h1Vg+ET6lk4ZePR44qKvxtBXts57j65m4LM1xPpbL7QYkZMnE27ppVPYUsS1MmBaQXQ2+u/Q2O97lgKx2rV/cbwwB4lRIRcEyW13mM7BI8+5UFo6AaonQxQkym9yonmHCz/pEWjqGCUDR05a4vHUyHTDJhfNKnBf/nHsEpQM4xtKjV05IqCShCrZTBUnjXuD5x++t/nMH6f0KfSOp0Yc7I3Fgi0SB02z9vljgUjAOjk9nMH23XpUB5r5vRKlMOTTaqkqaXgYseBSDkZIX3zyKqc+pBeBzjLli053EestpQVWKSUjGmsjhACNlefrjF1lgnaf+TKyuTcW6igVXfcrsP1Pe/06a ELql/1/b chfhlkOCsR/kLMooBJmPbqB0EHVgfxAjx9yo5gWIPN/K7sZWFHPY/e1ARFcWhT1OYVg4cG7W4im0uitEIMoMfpLdCavrtUtQihoItfrciSK0Wb85/8oeO5SCmmhh5Xs2gWLlXSWXMStdS/PVXlqO+f80GOOYfNW/nbnExJgNKruYTPv+TzyRuT9KE0g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: David Hildenbrand writes: >> +/* Verify that KSM can be enabled / queried with prctl. */ >> +static void test_prctl(void) >> +{ >> + int ret; >> + >> + ksft_print_msg("[RUN] %s\n", __func__); >> + >> + ret = prctl(PR_SET_MEMORY_MERGE, 1, 0, 0, 0); >> + if (ret < 0 && errno == EINVAL) { >> + ksft_test_result_skip("PR_SET_MEMORY_MERGE not supported\n"); >> + return; >> + } else if (ret) { >> + ksft_test_result_fail("PR_SET_MEMORY_MERGE=1 failed\n"); >> + } > > Just realized we're missing a "return;" in case of the failure here. > I'll fix it in the next version.