From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CA0CE7F14B for ; Wed, 27 Sep 2023 00:39:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E7AD18D0066; Tue, 26 Sep 2023 20:39:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E29D48D0002; Tue, 26 Sep 2023 20:39:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF1EB8D0066; Tue, 26 Sep 2023 20:39:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BE1798D0002 for ; Tue, 26 Sep 2023 20:39:31 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 90659A0D7C for ; Wed, 27 Sep 2023 00:39:31 +0000 (UTC) X-FDA: 81280518942.01.FF8E9BD Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by imf06.hostedemail.com (Postfix) with ESMTP id 7EA82180019 for ; Wed, 27 Sep 2023 00:39:29 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm3 header.b=Dw9OQxS+; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=P7wJVG+i; spf=pass (imf06.hostedemail.com: domain of shr@devkernel.io designates 66.111.4.26 as permitted sender) smtp.mailfrom=shr@devkernel.io; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695775169; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FJcCaP4MuvryHEoEUOeUXajPd8VqAGlTE+SmLU44ry4=; b=bal//9KRttLYeqhQ9rUjw6p4/oigRNCDSUfYO8midxoUmGsKRR8FSUlqKDG4pCWpu8OK4q OIxfjKkzySRALDTbasvScRuYMgymkl9aR4XqOmlLjtdXqZbfznMndAcAY3HXrJdg7Uybw4 r3NTxvcqA4sA/pxJrZAyPKw2ANmEIqg= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm3 header.b=Dw9OQxS+; dkim=pass header.d=messagingengine.com header.s=fm2 header.b=P7wJVG+i; spf=pass (imf06.hostedemail.com: domain of shr@devkernel.io designates 66.111.4.26 as permitted sender) smtp.mailfrom=shr@devkernel.io; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695775169; a=rsa-sha256; cv=none; b=wib8OA/PRWvBnvJLnFrMbI2fRUhi3tqaLqQkVgH+sF+KR3c+v7laneHRnY1OYU+U/nCWRY gwi/+lY8mfE7of2YrEvOfEHL1LRR735VdhoR9t4wNz7jHN+AZPKuoUt6RRhm2Vl/kgjmEI M7PlPwmvmhx9GCGtVtnIuhenGF3eg9I= Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id AFAC15C2646; Tue, 26 Sep 2023 20:39:28 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 26 Sep 2023 20:39:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=devkernel.io; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1695775168; x=1695861568; bh=FJ cCaP4MuvryHEoEUOeUXajPd8VqAGlTE+SmLU44ry4=; b=Dw9OQxS+KdAP3Jr5JK +M6z7yEbV0uBDa8LNmm9KcarKaVgRCoLoDcx7lcPUsWRbBxyXMZtDAqFdjg3IfOU 1eA1ucrxMaA9/Mm5qIgL8ZraGgEOO+98sJgaz70PlvbXODMbQq5XSmvRj73G/KzF kc4Ohl2I14T645tdIHj4VapJHk0S3bT8kB9+v+nxDZblTV7gvAPBctllj7wLOb0b bdQ204SV20eAcXTM93q75KlYz+D9gV3asSTTrRdiMty2EPtcCeBOvNrfynlhl7fZ WcT/RwBq6tWlF3ThVCBumz1rJtet4nu2q2NuCApNHoktIo68ZNNco+4bTL0GDFL/ tEKQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1695775168; x=1695861568; bh=FJcCaP4MuvryH EoEUOeUXajPd8VqAGlTE+SmLU44ry4=; b=P7wJVG+iBD4UMTt1qLcnPrIwHXJOL sU6KpFrfdEZiyW2Ddi0tnq6tVhRpfeP+YA/lJZLF02zn5Q020liZzSK9w9WPPbmU hH0nbcwnITbOvVgBktU6pz6TeME4W3tfEgl6uxyQsPB7NpjtiOCBlYg9IoeJ8Ppp BlKXQQcLNwPX2fPd3Jm1UVn2Rw6IrcQhdLk23X8nUW36LXES5vDufCEoqW/CpV8K bEnFngBEgq0v0KR8WB8YVoS5SQuxCXjx8+dShbSG4I8jR05xMe9xmGqdxSTGfgBc ElD4un7mBAlqId+bKQ5g5RVTqS8XZNydNrQ9RfKezL0rI3NGvO+mOvF2g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvjedrtddugdefjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpehffgfhvfevufffjgfkgggtsehttdertddtredtnecuhfhrohhmpefuthgvfhgr nhcutfhovghstghhuceoshhhrhesuggvvhhkvghrnhgvlhdrihhoqeenucggtffrrghtth gvrhhnpeevlefggffhheduiedtheejveehtdfhtedvhfeludetvdegieekgeeggfdugeeu tdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehshh hrseguvghvkhgvrhhnvghlrdhioh X-ME-Proxy: Feedback-ID: i84614614:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 26 Sep 2023 20:39:27 -0400 (EDT) References: <20230926040939.516161-1-shr@devkernel.io> <20230926040939.516161-2-shr@devkernel.io> <20230926140955.8b2627711116339af80731f2@linux-foundation.org> User-agent: mu4e 1.10.1; emacs 28.2.50 From: Stefan Roesch To: Andrew Morton Cc: David Hildenbrand , kernel-team@fb.com, hannes@cmpxchg.org, riel@surriel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 1/4] mm/ksm: add "smart" page scanning mode Date: Tue, 26 Sep 2023 17:39:09 -0700 In-reply-to: <20230926140955.8b2627711116339af80731f2@linux-foundation.org> Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 7EA82180019 X-Rspam-User: X-Stat-Signature: 4mpwpqox3eo6458z7bjagh74r98asnjk X-Rspamd-Server: rspam01 X-HE-Tag: 1695775169-130114 X-HE-Meta: U2FsdGVkX1/SezIuB3zVwFwMg/lvj2uROe9zZqpNmnJJjTV7pOD0jmACnvSjKx9jI9BHnqaMVx/VqNE4rXpWqg9N7NppjDyJxuFR2aQL81KWJk3yQiKQB+3X2GG44PTXXotcZviZDzqK2zeCzWiBxfZYtl1ZTyg3JAfIYI4uar/SwGVkQdv+4ARmHz42RY465HEp3EiW8EnsKAFnuuaLfuLVxPxmkViUSwI6HImt1MUrez3x+3gJinEHGG7+QvcxfUYWIVqP52Xw73JXq0SEYcX0WKtaMxwm2qlLhYEgvirYnl3hl2XcKy0M8VAE8qBuFx19G3/tm2tx6GHLxPsTt4P+GTDRmfXT25rqE9uJpnUH1tKPTYu0x6XRsLatWqQrASXcdW76f8GG8pdwLFd9h97hA0SgZ02YqiQYauwfwMU3529RlEv4yt60BwR6owlQ90+XD1clKNm7F2TdbdI6y7IllGZLA2f229hcLlQY9daPf4KwlbZDtB1IDrflYVtoNR4rrgQ8qaE9C8TLJ0e5kq6IH7R8wgJY45UgxM52EqZgDByn/u9zpHE2xHI/2sRXNVG3nDDMRSQPJdNp+66rtlTHD9D8yVXf6k/piW4Ep3sxn2QELYlVqk5mRkfIRWnykewJIZKpk/nHA5R+nlBowPLIagGABHQG6CBAxWoQ61u+FX28u4WdHooKX3HKfBRwc0xyI40xvs8sYPzXuS9m3+PBoFbdwPVAdzZfzREum0WCpnX0hgyIKfuRROJeHI/BSoJVFAO934oohd+1rjIwUqAhJ4pMKNtLBRgD7Qr2Xbf31vNlo2D+W5q7hvaok7Rzy66nryRng88wQp3Y9mhiVwBFtNNjVqL+CBvEwdKRBT+U3KlMBvBNNjiXMq2ds3uU6GnyIhqvARJkSVjKdgROzFaQbXfs7xXxrpR7aHhE5hVBnkilt6Fhkq4MSHE4yekGSQiJOoRFld0fiAA8nSy wji81QgA zKYUt7mFLHB65JScDsrOnurx/aNJIzwiW52ExxXr//+rzsC699oeZ3AP1bednoN0BfG3EOaKgNdwfuZXAqXOQbNVztNDAVvSP5bpfBRpZVeRssOsETt74BXmK3BemslvpvZNpwcVP6yJEl18jp9aKrTlvd+5M/KDOg3rR2yZxetG5NMiaG+FyTd/CfA75Iv/Q4fLL6+RhPEVh34Z1wwEQ4nJKd27skGm9nqXD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Andrew Morton writes: > On Tue, 26 Sep 2023 09:13:31 -0700 Stefan Roesch wrote: > >> > Thinking about it, what are the cons of just enabling this always and not >> > exposing new toggles? Alternatively, we could make this a compile-time option. >> > >> > In general, LGTM, just curious if we really have to make this configurable. >> > >> >> The only downside I can see is that it might take a longer time for some >> pages to be de-duplicated (a new candidate page is added, but its >> duplicate is skipped in this round). So it will take longer to >> de-duplicate this page. >> >> I tested with more than one workload, but it might be useful to get some >> data with additional workloads. I was thinking of enabling it after one or >> two releases. > > We could keep the tunable and make it default "on"? Sounds good to me